All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Yacoub <markyacoub@chromium.org>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: seanpaul@chromium.org, Rodrigo.Siqueira@amd.com,
	anson.jacob@amd.com, "Mark Yacoub" <markyacoub@google.com>,
	"Mark Yacoub" <markyacoub@chromium.org>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>
Subject: [PATCH 2/2] amd/amdgpu_dm: Verify Gamma and Degamma LUT sizes using DRM Core check
Date: Wed, 29 Sep 2021 15:39:26 -0400	[thread overview]
Message-ID: <20210929194012.3433306-2-markyacoub@chromium.org> (raw)
In-Reply-To: <20210929194012.3433306-1-markyacoub@chromium.org>

From: Mark Yacoub <markyacoub@google.com>

[Why]
drm_atomic_helper_check_crtc now verifies both legacy and non-legacy LUT
sizes. There is no need to check it within amdgpu_dm_atomic_check.

[How]
Remove the local call to verify LUT sizes and use DRM Core function
instead.

Tested on ChromeOS Zork.

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 07adac1a8c42b..96a1d006b777e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -10683,6 +10683,10 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
 		}
 	}
 #endif
+	ret = drm_atomic_helper_check_crtc(state);
+	if (ret)
+		return ret;
+
 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
 		dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
 
@@ -10692,10 +10696,6 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
 			dm_old_crtc_state->dsc_force_changed == false)
 			continue;
 
-		ret = amdgpu_dm_verify_lut_sizes(new_crtc_state);
-		if (ret)
-			goto fail;
-
 		if (!new_crtc_state->enable)
 			continue;
 
-- 
2.33.0.685.g46640cef36-goog


  reply	other threads:[~2021-09-29 19:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 19:39 [PATCH 1/2] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate Mark Yacoub
2021-09-29 19:39 ` Mark Yacoub
2021-09-29 19:39 ` Mark Yacoub [this message]
2021-10-01 19:56   ` [PATCH 2/2] amd/amdgpu_dm: Verify Gamma and Degamma LUT sizes using DRM Core check Sean Paul
2021-10-04 14:12     ` Harry Wentland
2021-10-01 20:34 ` [PATCH 1/2] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate Sean Paul
2021-10-01 20:34   ` Sean Paul
2021-10-02 14:28   ` Sean Paul
2021-10-02 14:28     ` Sean Paul
2021-10-13 18:18   ` Mark Yacoub
2021-10-13 18:18     ` Mark Yacoub
2021-10-13 18:12 ` Mark Yacoub
2021-10-13 18:12   ` Mark Yacoub
2021-10-13 18:12   ` [Intel-gfx] " Mark Yacoub
2021-10-13 18:12   ` Mark Yacoub
2021-10-13 18:12   ` [PATCH 2/2] amd/amdgpu_dm: Verify Gamma and Degamma LUT sizes using DRM Core check Mark Yacoub
2021-10-13 18:12     ` [Intel-gfx] " Mark Yacoub
2021-10-14 23:42     ` Sean Paul
2021-10-14 23:42       ` [Intel-gfx] " Sean Paul
2021-10-26  1:26   ` [Intel-gfx] [PATCH 1/2] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate Sean Paul
2021-10-26  1:26     ` Sean Paul
2021-10-26  1:26     ` Sean Paul
2021-10-26 19:25     ` Mark Yacoub
2021-10-26 19:25       ` Mark Yacoub
2021-10-26 19:25       ` Mark Yacoub
2021-10-26 12:02   ` Paul Menzel
2021-10-26 12:02     ` [Intel-gfx] " Paul Menzel
2021-10-26 12:02     ` Paul Menzel
2021-10-26 12:02     ` Paul Menzel
2021-10-26 19:24     ` Mark Yacoub
2021-10-26 19:24       ` Mark Yacoub
2021-10-26 19:24       ` [Intel-gfx] " Mark Yacoub
2021-10-26 19:24       ` Mark Yacoub
2021-10-26 19:26       ` [Intel-gfx] " Mark Yacoub
2021-10-26 19:26         ` Mark Yacoub
2021-10-26 19:26         ` Mark Yacoub
2021-10-26 19:26         ` Mark Yacoub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929194012.3433306-2-markyacoub@chromium.org \
    --to=markyacoub@chromium.org \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=anson.jacob@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=markyacoub@google.com \
    --cc=seanpaul@chromium.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.