From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF171C4332F for ; Thu, 30 Sep 2021 14:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7B9961A02 for ; Thu, 30 Sep 2021 14:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352073AbhI3PAE (ORCPT ); Thu, 30 Sep 2021 11:00:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51072 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352018AbhI3O77 (ORCPT ); Thu, 30 Sep 2021 10:59:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633013895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zptMMX+xorScj8oCKZfu7vNyw+QcA+InPw6+3Zh+fcA=; b=WdqNw6J0B+IZB9mZa9kbTLPEdzqL1iWo4eWniUwapPQ6/TYKAFM3hg9FA1wLqu6Pk1KDp+ 9dEkHghzE+s6jRWUKp1dMoBzano4jhv9IZD5bE82OwC6jtTWzi9BydfuD9cJWPrdzQa8iy xR5voX0Bf+4T/zpqW6PGgmEkp03H5ug= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-kLYA-t4RMoOIfZVpa1lShw-1; Thu, 30 Sep 2021 10:58:14 -0400 X-MC-Unique: kLYA-t4RMoOIfZVpa1lShw-1 Received: by mail-wm1-f71.google.com with SMTP id f10-20020a7bcd0a000000b0030d2def848dso868215wmj.0 for ; Thu, 30 Sep 2021 07:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zptMMX+xorScj8oCKZfu7vNyw+QcA+InPw6+3Zh+fcA=; b=nIIrqAKh6/8MdmyuVcTXqDJ2BdXDL5ESfdCh2jInkSH7BiuyljI3EfS53WgAY11jTH 8wQ5TsidT9SQJxvi9jOmdppMkB1TAG3CoBTpYvMj/Mrthcjfjlh8mqptW4akfKW3a2o/ xaJsnkt15oaMIVe1jzkTucg0fV6HObcaDiBI4y63DPbuNWugH4jngVxqe9pdln7+kYjn 15Tekg/58btCJmk+2MEnj/A9M19RkrG+CeHJF06DSOJL7B+qjmTPOra7QmX9OFDdI34K ZEhHdmE4n5g6ZTdMk8JpIvofnG7cq+rtcl5vc/aDOQtS+XUJbb1gphptQ2MD4ORVklhn m3wQ== X-Gm-Message-State: AOAM532xk4m63yVNGMrfCKndqBleRNBM8D7pBJhIHRI3VgRUU8WxJkuA mDusur43iRlQkhtaGBVFUAF7VqGQhV8Nq4mkoDXDQDl3aKBwRx6j7fTrkOyH6xN2cD+3eoF4fUB jTo1W0DQLsgyFAUTJ4ht60KQc X-Received: by 2002:a1c:7e87:: with SMTP id z129mr5645386wmc.75.1633013893057; Thu, 30 Sep 2021 07:58:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaSf6qIxOAUaDvu9F6CRNxVN7kuMkgxNG2gPYtmYIu+P3izWa6fLM0ccmLZ3hvWl8yaURe3A== X-Received: by 2002:a1c:7e87:: with SMTP id z129mr5645358wmc.75.1633013892858; Thu, 30 Sep 2021 07:58:12 -0700 (PDT) Received: from redhat.com ([2.55.134.220]) by smtp.gmail.com with ESMTPSA id q18sm5031993wmc.7.2021.09.30.07.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 07:58:12 -0700 (PDT) Date: Thu, 30 Sep 2021 10:58:07 -0400 From: "Michael S. Tsirkin" To: Alan Stern Cc: Greg Kroah-Hartman , Kuppuswamy Sathyanarayanan , Borislav Petkov , x86@kernel.org, Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , Michael Jamet , Yehezkel Bernat , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Dan Williams , Andi Kleen , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices Message-ID: <20210930104924-mutt-send-email-mst@kernel.org> References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-3-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930065807-mutt-send-email-mst@kernel.org> <20210930144305.GA464826@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930144305.GA464826@rowland.harvard.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 10:43:05AM -0400, Alan Stern wrote: > I don't see any point in talking about "untrusted drivers". If a > driver isn't trusted then it doesn't belong in your kernel. Period. > When you load a driver into your kernel, you are implicitly trusting > it (aside from limitations imposed by security modules). Trusting it to do what? Historically a ton of drivers did not validate input from devices they drive. Most still don't. > The code > it contains, the module_init code in particular, runs with full > superuser permissions. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F688C433EF for ; Thu, 30 Sep 2021 14:58:21 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15EA061882 for ; Thu, 30 Sep 2021 14:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15EA061882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D211F613FD; Thu, 30 Sep 2021 14:58:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k9SRiz_icnyx; Thu, 30 Sep 2021 14:58:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8DC03613F3; Thu, 30 Sep 2021 14:58:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6DC74C000F; Thu, 30 Sep 2021 14:58:19 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 114B2C000D for ; Thu, 30 Sep 2021 14:58:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id ED6F740346 for ; Thu, 30 Sep 2021 14:58:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3acP2rDXmGWa for ; Thu, 30 Sep 2021 14:58:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 27676400FE for ; Thu, 30 Sep 2021 14:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633013895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zptMMX+xorScj8oCKZfu7vNyw+QcA+InPw6+3Zh+fcA=; b=WdqNw6J0B+IZB9mZa9kbTLPEdzqL1iWo4eWniUwapPQ6/TYKAFM3hg9FA1wLqu6Pk1KDp+ 9dEkHghzE+s6jRWUKp1dMoBzano4jhv9IZD5bE82OwC6jtTWzi9BydfuD9cJWPrdzQa8iy xR5voX0Bf+4T/zpqW6PGgmEkp03H5ug= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-hYLgZfinOuiZKQwWv7VL4w-1; Thu, 30 Sep 2021 10:58:14 -0400 X-MC-Unique: hYLgZfinOuiZKQwWv7VL4w-1 Received: by mail-wm1-f70.google.com with SMTP id n3-20020a7bcbc3000000b0030b68c4de38so2061738wmi.8 for ; Thu, 30 Sep 2021 07:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zptMMX+xorScj8oCKZfu7vNyw+QcA+InPw6+3Zh+fcA=; b=336D5KC39QNvwjsDMONMEWypsehsTtqjMrdWiwiWCcdz36aoXW12YS6u8SB1voypp/ MAqo/FaKPRlM9k4QpLXN+dSkEPQp6ce4V/JjVDUBRlxvhSDY0Zz9OPwPKg7czgryagQl lxcOVzAG3V2yqaFqwjDj5Yj5nHDe4xQz247wLYR1VrrfCTQrZvqVy+4ihPKAFTd03rw3 oIggl0n1M/3ILge1ngdIkAH6JYcLRqm4tmivUx45AZbK/SqVZo1bQM/CgMUUMnZgC5Ql ImuTAIbFvocCDLGWxkNrb1L1EvpU98CsHm/LihtWtKazwqy+gTZaLCCEplgVMqm+PdBi o7Wg== X-Gm-Message-State: AOAM530ctY47oDtvTvnkxeylrgDzQKVc3S/NldRcYmHbeQYVoeo/pnDe 4ukad4HyLvORaoe+b2saxNX9lht2EqKcoYkGFMjeSKVKjudrRP/6spDJYZW2CPJ41lxv9iERynz DmODMaeZ7q5pmVmSgVKWfjXkusPTaufCWqx2Vv7/Kjw== X-Received: by 2002:a1c:7e87:: with SMTP id z129mr5645376wmc.75.1633013893040; Thu, 30 Sep 2021 07:58:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaSf6qIxOAUaDvu9F6CRNxVN7kuMkgxNG2gPYtmYIu+P3izWa6fLM0ccmLZ3hvWl8yaURe3A== X-Received: by 2002:a1c:7e87:: with SMTP id z129mr5645358wmc.75.1633013892858; Thu, 30 Sep 2021 07:58:12 -0700 (PDT) Received: from redhat.com ([2.55.134.220]) by smtp.gmail.com with ESMTPSA id q18sm5031993wmc.7.2021.09.30.07.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 07:58:12 -0700 (PDT) Date: Thu, 30 Sep 2021 10:58:07 -0400 From: "Michael S. Tsirkin" To: Alan Stern Subject: Re: [PATCH v2 2/6] driver core: Add common support to skip probe for un-authorized devices Message-ID: <20210930104924-mutt-send-email-mst@kernel.org> References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-3-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930065807-mutt-send-email-mst@kernel.org> <20210930144305.GA464826@rowland.harvard.edu> MIME-Version: 1.0 In-Reply-To: <20210930144305.GA464826@rowland.harvard.edu> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Jonathan Corbet , Kuppuswamy Sathyanarayanan , Andi Kleen , "Rafael J . Wysocki" , Michael Jamet , Greg Kroah-Hartman , x86@kernel.org, virtualization@lists.linux-foundation.org, Yehezkel Bernat , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, Andreas Noever , Ingo Molnar , Borislav Petkov , linux-pci@vger.kernel.org, Bjorn Helgaas , Thomas Gleixner , linux-usb@vger.kernel.org, Mika Westerberg , Dan Williams X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Sep 30, 2021 at 10:43:05AM -0400, Alan Stern wrote: > I don't see any point in talking about "untrusted drivers". If a > driver isn't trusted then it doesn't belong in your kernel. Period. > When you load a driver into your kernel, you are implicitly trusting > it (aside from limitations imposed by security modules). Trusting it to do what? Historically a ton of drivers did not validate input from devices they drive. Most still don't. > The code > it contains, the module_init code in particular, runs with full > superuser permissions. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization