From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88CFC433EF for ; Thu, 30 Sep 2021 13:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7DF2617E5 for ; Thu, 30 Sep 2021 13:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349419AbhI3NG1 (ORCPT ); Thu, 30 Sep 2021 09:06:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:59464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349366AbhI3NG0 (ORCPT ); Thu, 30 Sep 2021 09:06:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 980FF61528; Thu, 30 Sep 2021 13:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633007084; bh=+s6LJxFuBmlJp9/9dcn48u7vnNbcZ8iPNN4iyAdSDPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAOSz70qSb1/bv1kHlkZDOvTg6wttP2zJv3px1/YqJm0Nkout2msVt9Z7nDY73GAo IOXXwUdhK3TOZmhdrG/nZwueGWjuzn643i9AYHDZlUA0YElj0iGWcNIWN8u9PLJ+k6 Ja2+FCVgU9FMvV0SnGhUngXQAZryBYCwibjq0iYqhH4HIyuj8njLPx98MhcScnjTbZ ewyKZGdTTN2cuiES30Azq3cB48JBVsTvj9EA6zyu41+eWw88Q8nTLYkNPLwuDVuhjk C+Yx4N6m86OLcA6uH0W9bXGAPlpcJg475/K/ePPzUDVwJaSJpYOJlAUCucyi38qcKC oBFc0p1Hjsejw== Date: Thu, 30 Sep 2021 14:04:38 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v6 01/12] KVM: arm64: Move __get_fault_info() and co into their own include file Message-ID: <20210930130437.GA23809@willie-the-truck> References: <20210922124704.600087-1-tabba@google.com> <20210922124704.600087-2-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210922124704.600087-2-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Sep 22, 2021 at 01:46:53PM +0100, Fuad Tabba wrote: > From: Marc Zyngier > > In order to avoid including the whole of the switching helpers > in unrelated files, move the __get_fault_info() and related helpers > into their own include file. > > Signed-off-by: Marc Zyngier > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/hyp/include/hyp/fault.h | 75 +++++++++++++++++++++++++ > arch/arm64/kvm/hyp/include/hyp/switch.h | 61 +------------------- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 3 files changed, 77 insertions(+), 61 deletions(-) > create mode 100644 arch/arm64/kvm/hyp/include/hyp/fault.h > > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > new file mode 100644 > index 000000000000..1b8a2dcd712f > --- /dev/null > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -0,0 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2015 - ARM Ltd > + * Author: Marc Zyngier May as well fix the broken email address? ^^ > + */ > + > +#ifndef __ARM64_KVM_HYP_FAULT_H__ > +#define __ARM64_KVM_HYP_FAULT_H__ > + > +#include > +#include > +#include > +#include Strictly speaking, I think you're probably missing a bunch of includes here (e.g. asm/sysreg.h, asm/kvm_arm.h, asm/cpufeature.h, ...) Nits aside: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FCBEC433EF for ; Thu, 30 Sep 2021 13:04:50 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C74F9613A7 for ; Thu, 30 Sep 2021 13:04:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C74F9613A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5A7214B0ED; Thu, 30 Sep 2021 09:04:49 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iDkWZU5IwDmQ; Thu, 30 Sep 2021 09:04:48 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3BBDF4B0D6; Thu, 30 Sep 2021 09:04:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E79A34B0CC for ; Thu, 30 Sep 2021 09:04:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KEQMOooWjDMX for ; Thu, 30 Sep 2021 09:04:45 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D25C949DE3 for ; Thu, 30 Sep 2021 09:04:45 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 980FF61528; Thu, 30 Sep 2021 13:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633007084; bh=+s6LJxFuBmlJp9/9dcn48u7vnNbcZ8iPNN4iyAdSDPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAOSz70qSb1/bv1kHlkZDOvTg6wttP2zJv3px1/YqJm0Nkout2msVt9Z7nDY73GAo IOXXwUdhK3TOZmhdrG/nZwueGWjuzn643i9AYHDZlUA0YElj0iGWcNIWN8u9PLJ+k6 Ja2+FCVgU9FMvV0SnGhUngXQAZryBYCwibjq0iYqhH4HIyuj8njLPx98MhcScnjTbZ ewyKZGdTTN2cuiES30Azq3cB48JBVsTvj9EA6zyu41+eWw88Q8nTLYkNPLwuDVuhjk C+Yx4N6m86OLcA6uH0W9bXGAPlpcJg475/K/ePPzUDVwJaSJpYOJlAUCucyi38qcKC oBFc0p1Hjsejw== Date: Thu, 30 Sep 2021 14:04:38 +0100 From: Will Deacon To: Fuad Tabba Subject: Re: [PATCH v6 01/12] KVM: arm64: Move __get_fault_info() and co into their own include file Message-ID: <20210930130437.GA23809@willie-the-truck> References: <20210922124704.600087-1-tabba@google.com> <20210922124704.600087-2-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210922124704.600087-2-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kernel-team@android.com, kvm@vger.kernel.org, maz@kernel.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Sep 22, 2021 at 01:46:53PM +0100, Fuad Tabba wrote: > From: Marc Zyngier > > In order to avoid including the whole of the switching helpers > in unrelated files, move the __get_fault_info() and related helpers > into their own include file. > > Signed-off-by: Marc Zyngier > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/hyp/include/hyp/fault.h | 75 +++++++++++++++++++++++++ > arch/arm64/kvm/hyp/include/hyp/switch.h | 61 +------------------- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 3 files changed, 77 insertions(+), 61 deletions(-) > create mode 100644 arch/arm64/kvm/hyp/include/hyp/fault.h > > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > new file mode 100644 > index 000000000000..1b8a2dcd712f > --- /dev/null > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -0,0 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2015 - ARM Ltd > + * Author: Marc Zyngier May as well fix the broken email address? ^^ > + */ > + > +#ifndef __ARM64_KVM_HYP_FAULT_H__ > +#define __ARM64_KVM_HYP_FAULT_H__ > + > +#include > +#include > +#include > +#include Strictly speaking, I think you're probably missing a bunch of includes here (e.g. asm/sysreg.h, asm/kvm_arm.h, asm/cpufeature.h, ...) Nits aside: Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A589C433FE for ; Thu, 30 Sep 2021 13:08:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CB6B61425 for ; Thu, 30 Sep 2021 13:08:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6CB6B61425 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x11hzB57nfFrluKvQ9A1s8U07pVSpuOOCzh/iUYgi9s=; b=qWpVoXq2Imiljr jdbnZR3LJvhS6oAVszOM3jNdp49592ESt5L/9zb7lRWjPMpZe7QJ91h9Jz6VZu7D2o/E13EpatZuL 27PlrFXk0/kC0UUdGH2HCmKZe5B3OeKVTTSqOc2KaY6rxozUDpMD24H0zvCBdP7u+fRzX9rOmgcRS IjWP1XjJaNFIFGz7AliSeQPQQG/S4rnKx+ycDcbgiYznC2Ta160P/uzqRPcG07jJUBjxO+ZA1JTCj koioXGPUbiSA4mcuXUv61fOeT9fq3JN4R5QU7r/DB83auSUGIODGdHbBL8cMZn4l4OZzybKQtsQu1 CXAEE90Jhz3Qnzj4IsOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVvkF-00ELZ4-2v; Thu, 30 Sep 2021 13:05:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVvjw-00ELV7-Nm for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 13:04:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 980FF61528; Thu, 30 Sep 2021 13:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633007084; bh=+s6LJxFuBmlJp9/9dcn48u7vnNbcZ8iPNN4iyAdSDPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAOSz70qSb1/bv1kHlkZDOvTg6wttP2zJv3px1/YqJm0Nkout2msVt9Z7nDY73GAo IOXXwUdhK3TOZmhdrG/nZwueGWjuzn643i9AYHDZlUA0YElj0iGWcNIWN8u9PLJ+k6 Ja2+FCVgU9FMvV0SnGhUngXQAZryBYCwibjq0iYqhH4HIyuj8njLPx98MhcScnjTbZ ewyKZGdTTN2cuiES30Azq3cB48JBVsTvj9EA6zyu41+eWw88Q8nTLYkNPLwuDVuhjk C+Yx4N6m86OLcA6uH0W9bXGAPlpcJg475/K/ePPzUDVwJaSJpYOJlAUCucyi38qcKC oBFc0p1Hjsejw== Date: Thu, 30 Sep 2021 14:04:38 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v6 01/12] KVM: arm64: Move __get_fault_info() and co into their own include file Message-ID: <20210930130437.GA23809@willie-the-truck> References: <20210922124704.600087-1-tabba@google.com> <20210922124704.600087-2-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210922124704.600087-2-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_060444_838980_10821BA8 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 22, 2021 at 01:46:53PM +0100, Fuad Tabba wrote: > From: Marc Zyngier > > In order to avoid including the whole of the switching helpers > in unrelated files, move the __get_fault_info() and related helpers > into their own include file. > > Signed-off-by: Marc Zyngier > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/hyp/include/hyp/fault.h | 75 +++++++++++++++++++++++++ > arch/arm64/kvm/hyp/include/hyp/switch.h | 61 +------------------- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 3 files changed, 77 insertions(+), 61 deletions(-) > create mode 100644 arch/arm64/kvm/hyp/include/hyp/fault.h > > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > new file mode 100644 > index 000000000000..1b8a2dcd712f > --- /dev/null > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -0,0 +1,75 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2015 - ARM Ltd > + * Author: Marc Zyngier May as well fix the broken email address? ^^ > + */ > + > +#ifndef __ARM64_KVM_HYP_FAULT_H__ > +#define __ARM64_KVM_HYP_FAULT_H__ > + > +#include > +#include > +#include > +#include Strictly speaking, I think you're probably missing a bunch of includes here (e.g. asm/sysreg.h, asm/kvm_arm.h, asm/cpufeature.h, ...) Nits aside: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel