From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3EAC433F5 for ; Thu, 30 Sep 2021 16:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D90E61350 for ; Thu, 30 Sep 2021 16:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349585AbhI3QUy (ORCPT ); Thu, 30 Sep 2021 12:20:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:47178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349271AbhI3QUv (ORCPT ); Thu, 30 Sep 2021 12:20:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B059613CE; Thu, 30 Sep 2021 16:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633018748; bh=rP34b39rMFTFSLIOSBofnZPX8DgrVC8oLCH2ImSxRzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upqkO0jQqG04MpzU7EQzRxEsEw2yZCGH0LLKUT4K63+m9c14nHg5GekQkMZsX5r6Z k2+4gtTIw5CEvLGuEaTedahU84A9pB1Iykha5hPmB3dV+MARmDvNebC9FshMZ5Ku0Y uoX5wHWBcmOvpYJmLl76NBS7VVOSSo32Ccx734bir9mGBIrKbA0jkUen6yRgEDZ2Y7 CW646+9irG5tRofdD6rumh1OScYBCPd9Nexp5UcSNUgdx3qed7767Jzh0jd3HRCRAU bP8dBdc39vLehuiMxazZPq4WgzHXjGrxIvlZ/aZoUm6ZPaxsZiAxFBMfU1USizUCH9 B8ER/Vvv6Yi8A== Received: by pali.im (Postfix) id 05893E79; Thu, 30 Sep 2021 18:19:05 +0200 (CEST) Date: Thu, 30 Sep 2021 18:19:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jonas =?utf-8?Q?Dre=C3=9Fler?= Cc: Andy Shevchenko , Brian Norris , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski , Tsuchiya Yuto , linux-wireless , netdev@vger.kernel.org, Linux Kernel , linux-pci , Maximilian Luz , Andy Shevchenko , Bjorn Helgaas Subject: Re: [PATCH 1/2] mwifiex: Use non-posted PCI register writes Message-ID: <20210930161905.5a552go73c2o4e7l@pali> References: <0ce93e7c-b041-d322-90cd-40ff5e0e8ef0@v0yd.nl> <20210923202231.t2zjoejpxrbbe5hc@pali> <20210930154202.cvw3it3edv7pmqtb@pali> <6ba104fa-a659-c192-4dc0-291ca3413f99@v0yd.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ba104fa-a659-c192-4dc0-291ca3413f99@v0yd.nl> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thursday 30 September 2021 18:14:04 Jonas Dreßler wrote: > On 9/30/21 5:42 PM, Pali Rohár wrote: > > On Thursday 30 September 2021 17:38:43 Jonas Dreßler wrote: > > > On 9/23/21 10:22 PM, Pali Rohár wrote: > > > > On Thursday 23 September 2021 22:41:30 Andy Shevchenko wrote: > > > > > On Thu, Sep 23, 2021 at 6:28 PM Jonas Dreßler wrote: > > > > > > On 9/22/21 2:50 PM, Jonas Dreßler wrote: > > > > > > > > > > ... > > > > > > > > > > > - Just calling mwifiex_write_reg() once and then blocking until the card > > > > > > wakes up using my delay-loop doesn't fix the issue, it's actually > > > > > > writing multiple times that fixes the issue > > > > > > > > > > > > These observations sound a lot like writes (and even reads) are actually > > > > > > being dropped, don't they? > > > > > > > > > > It sounds like you're writing into a not ready (fully powered on) device. > > > > > > > > This reminds me a discussion with Bjorn about CRS response returned > > > > after firmware crash / reset when device is not ready yet: > > > > https://lore.kernel.org/linux-pci/20210922164803.GA203171@bhelgaas/ > > > > > > > > Could not be this similar issue? You could check it via reading > > > > PCI_VENDOR_ID register from config space. And if it is not valid value > > > > then card is not really ready yet. > > > > > > > > > To check this, try to put a busy loop for reading and check the value > > > > > till it gets 0. > > > > > > > > > > Something like > > > > > > > > > > unsigned int count = 1000; > > > > > > > > > > do { > > > > > if (mwifiex_read_reg(...) == 0) > > > > > break; > > > > > } while (--count); > > > > > > > > > > > > > > > -- > > > > > With Best Regards, > > > > > Andy Shevchenko > > > > > > I've tried both reading PCI_VENDOR_ID and the firmware status using a busy > > > loop now, but sadly none of them worked. It looks like the card always > > > replies with the correct values even though it sometimes won't wake up after > > > that. > > > > > > I do have one new observation though, although I've no clue what could be > > > happening here: When reading PCI_VENDOR_ID 1000 times to wakeup we can > > > "predict" the wakeup failure because exactly one (usually around the 20th) > > > of those 1000 reads will fail. > > > > What does "fail" means here? > > ioread32() returns all ones, that's interpreted as failure by > mwifiex_read_reg(). Ok. And can you check if PCI Bridge above this card has enabled CRSSVE bit (CRSVisible in RootCtl+RootCap in lspci output)? To determinate if Bridge could convert CRS response to all-ones as failed transaction. > > > > > Maybe the firmware actually tries to wake up, > > > encounters an error somewhere in its wakeup routines and then goes down a > > > special failure code path. That code path keeps the cards CPU so busy that > > > at some point a PCI_VENDOR_ID request times out? > > > > > > Or well, maybe the card actually wakes up fine, but we don't receive the > > > interrupt on our end, so many possibilities...