From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A998BC433F5 for ; Thu, 30 Sep 2021 16:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9144B615A7 for ; Thu, 30 Sep 2021 16:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351395AbhI3Qca (ORCPT ); Thu, 30 Sep 2021 12:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351165AbhI3QcY (ORCPT ); Thu, 30 Sep 2021 12:32:24 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF6B0C06176D for ; Thu, 30 Sep 2021 09:30:41 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id e7so6849640pgk.2 for ; Thu, 30 Sep 2021 09:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ciyh0EVHcl3WRsnW2ZREWfVT9JlEKA9hfP6r96v0iyo=; b=KLa5TC+QH0mRltEWVuTIoKEr3I5WlJ5ps07gPtG+fFyGEdV1U/dfQymhN/OCTfFMB9 Y7+88FcoTDrTJg23LJDHozJMKKBrw1K+Cf1qDSuKJe+iDC2e4yju2MKv7h+5KATiNn51 0z+EpCXkz4hgoHRq2xu2wdBaorGBdI+Cw8KN08f2UQfJlPBfTclLpIjTHLKaIMhCUz1F B+TvY7+bfat4KzRY/LvcdNCxOYpJD0qZUuZI0K4VtD+g1iLDQrTqBm2oSCndAtEeQStQ AFKlCWAbvVu1NDaQ251VibzsX3vBLQtFql8481C2fo8BdtOorsLXcCp6Ce7kavuT+nro WpXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ciyh0EVHcl3WRsnW2ZREWfVT9JlEKA9hfP6r96v0iyo=; b=iqXNsLXOo2VEQyvTr/Oinqca5cwbi4Q9np94OFDVqjMEPk/RooyG1DBwCkm3BIYXpm fXWLj+3yFo9XHht5u9Otu47qBTX1GUNzNkxQlxoYJfxjuJG1c+vaCS+LtwW9MkCRcDJh RmgbZUQUzt2ofZEvR9Bz2vegHyQQMOqwHqpcVYbBIKvCAdE40yzfmYzbMfMTkj2qtgIe 5h4oTl9OwHYbdrdK7Db92e2j8cEbq728pEM7HJyfKLXlivrJyAiJ9mNVetSaWq/fl9Sn O2b0roD/KwJ8EMY0QLQp2ihHvwq10OMX3j1tyXcGtUPpZpD9TxQrNDPvpvRACIv2aCBL orNw== X-Gm-Message-State: AOAM531CwWvG00A08e+EZODMCp3/Act39iab+7VqugzbBvUKPO/2GmWX Y2QKHj5zFZUx9UxCblpUKt1GPw== X-Google-Smtp-Source: ABdhPJwypV3JkcUF52yFwFeC0CYHKTJzN0cIsYLiSO0D2ExL+no2wARl/7UePGspmFaRIyeVnclmmw== X-Received: by 2002:a62:1d4d:0:b0:443:eac2:8a1b with SMTP id d74-20020a621d4d000000b00443eac28a1bmr5281219pfd.2.1633019440914; Thu, 30 Sep 2021 09:30:40 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 127sm3663367pfw.10.2021.09.30.09.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 09:30:39 -0700 (PDT) Date: Thu, 30 Sep 2021 10:30:37 -0600 From: Mathieu Poirier To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format Message-ID: <20210930163037.GA3047827@p14s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210923162434.GA2189675@p14s> <67a54101-a514-6077-96ba-8809226181eb@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67a54101-a514-6077-96ba-8809226181eb@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 01:09:16PM +0100, German Gomez wrote: > Hi Mathieu, > > Thanks for your feedback. I will keep these points in mind for future > submissions. > > On 23/09/2021 17:24, Mathieu Poirier wrote: > > Hi German, > > > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > > > [...] > > Reviewed-by: Mathieu Poirier > > > > A couple of things to improve for your next interactions with the Linux community: > > > > 1) Using a cover letter, even for small changes, is always a good idea. > > 2) RB tags should be picked up publicly rather than done internally and added to > > a patchset. > > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > > with 01, 02 and 03. > Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 > because > they were related to snapshot mode. Yes - you are correct. It should have been 01 and 02 in one set and the rest in another set. > > Thanks, > German > > > > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > > this patchset. As such he will not see your work. Ask James about how to > > proceed when submitting patches to the perf tools. > > > > Thanks, > > Mathieu > > > > > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > > do { > > > -- > > > 2.17.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B03C433F5 for ; Thu, 30 Sep 2021 16:33:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 380BB6138F for ; Thu, 30 Sep 2021 16:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 380BB6138F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3sEIkr8wbp/zymyQEMZrm0cPykKEDOSHpCLlDRDQppU=; b=F/twZi+42ut5F5 /QYeqHf7RwSnHRBHryHFT681fJ+Q7V/ciNo1Eaac+vVlsNnXvDwssH6YQfYgT/42VyE6QYAStMT2c C/qaV/rieSvvFyH7bwz1YPHRBN03GhsTgAVUijMRlvAci6VIaNRuCDWV7HV1AfDMVIs7SVzw4tRRC L74iTnWliUyVbLKhKTgodZaN1LOMBf6cTuVtJanC4674B26QzsJ44fyGmDeYsyQPnT4MU5QPB+Od9 daSVdYo3znsaVEEiCrPU9wzNe/FdWHYy767mTKhfoys/AR/jDehfMW7N6BFnzVMmN2KC5Pzxee9x8 x+USJ2+ckPdym25S4qHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyxK-00FFVg-B2; Thu, 30 Sep 2021 16:30:46 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyxG-00FFV4-SG for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 16:30:44 +0000 Received: by mail-pg1-x534.google.com with SMTP id s11so6813302pgr.11 for ; Thu, 30 Sep 2021 09:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ciyh0EVHcl3WRsnW2ZREWfVT9JlEKA9hfP6r96v0iyo=; b=KLa5TC+QH0mRltEWVuTIoKEr3I5WlJ5ps07gPtG+fFyGEdV1U/dfQymhN/OCTfFMB9 Y7+88FcoTDrTJg23LJDHozJMKKBrw1K+Cf1qDSuKJe+iDC2e4yju2MKv7h+5KATiNn51 0z+EpCXkz4hgoHRq2xu2wdBaorGBdI+Cw8KN08f2UQfJlPBfTclLpIjTHLKaIMhCUz1F B+TvY7+bfat4KzRY/LvcdNCxOYpJD0qZUuZI0K4VtD+g1iLDQrTqBm2oSCndAtEeQStQ AFKlCWAbvVu1NDaQ251VibzsX3vBLQtFql8481C2fo8BdtOorsLXcCp6Ce7kavuT+nro WpXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ciyh0EVHcl3WRsnW2ZREWfVT9JlEKA9hfP6r96v0iyo=; b=yg2JsotqthLm2u3OK/J68f79ofLvWSMjoL4DsIZAf0+JKR3fNDnq+90k3cVjNNdoWI onbpTkYtW4rIFMcI3t2xx60IHUk6BaBJMztaT//KcufnADRx/o1+tCxXU/mS7GXVvSKo iq8rw25D54WKI4iojx6nSePnmv/6/D61j0kfuCd2ENNjp5k7KuDL6Mq/4ZQVdx22adjk am3BAWjO3rY936vw0c0v/78t2+vQJ2Ab4FkNXCORglcNCmujbK/PRbbQzgrKD7TqJEiY 9LK/E3/rlwioFRQrbg+VD74pUbRmVnLjIBmx9xOu+rWZ5liPSBo1jXj+TWWjIyo9cskL Ow3Q== X-Gm-Message-State: AOAM530dBj1/xR63rQRzWzj/HG5oWEt4fObLCrnIdd3rPw6EyiRljZlC PN4mu9tilJFGawH7xLweMiu6RA== X-Google-Smtp-Source: ABdhPJwypV3JkcUF52yFwFeC0CYHKTJzN0cIsYLiSO0D2ExL+no2wARl/7UePGspmFaRIyeVnclmmw== X-Received: by 2002:a62:1d4d:0:b0:443:eac2:8a1b with SMTP id d74-20020a621d4d000000b00443eac28a1bmr5281219pfd.2.1633019440914; Thu, 30 Sep 2021 09:30:40 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 127sm3663367pfw.10.2021.09.30.09.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 09:30:39 -0700 (PDT) Date: Thu, 30 Sep 2021 10:30:37 -0600 From: Mathieu Poirier To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format Message-ID: <20210930163037.GA3047827@p14s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210923162434.GA2189675@p14s> <67a54101-a514-6077-96ba-8809226181eb@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <67a54101-a514-6077-96ba-8809226181eb@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_093042_937809_51E033BB X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 01:09:16PM +0100, German Gomez wrote: > Hi Mathieu, > > Thanks for your feedback. I will keep these points in mind for future > submissions. > > On 23/09/2021 17:24, Mathieu Poirier wrote: > > Hi German, > > > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > > > [...] > > Reviewed-by: Mathieu Poirier > > > > A couple of things to improve for your next interactions with the Linux community: > > > > 1) Using a cover letter, even for small changes, is always a good idea. > > 2) RB tags should be picked up publicly rather than done internally and added to > > a patchset. > > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > > with 01, 02 and 03. > Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 > because > they were related to snapshot mode. Yes - you are correct. It should have been 01 and 02 in one set and the rest in another set. > > Thanks, > German > > > > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > > this patchset. As such he will not see your work. Ask James about how to > > proceed when submitting patches to the perf tools. > > > > Thanks, > > Mathieu > > > > > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > > do { > > > -- > > > 2.17.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel