From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B0672 for ; Thu, 30 Sep 2021 16:49:18 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id oj16so1354682pjb.1 for ; Thu, 30 Sep 2021 09:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2I7JkxI5MtVO/SyPk3TCAjamGg2Qcc2s2nk2OwgS+3M=; b=ngwDdmByPwIgkkXgFt4PuFRkQs+EX+S4DN8pih1MtZr0R+zQ2oYxwEhx9xLBVrV1g7 ooSCyl3JWt1hC16qYly/ZhJFHKvMMif/udNuIgtJGabd4OXnCbaZ0+4I0ryizbkVLY/h 5bso0MtXrSg1ZVkgO2mynN3ZPQRQP0dW0+kL2pwbtxajoGLB5cTjPpjN33Mzg/MixN3v tRsxOjnm+gJCuCFyaolzbaEHhlOU+WWdi7x5/GzUjoVFsYFz/KWM1iobnYnxecJuzMAi 7QBPr5I6asPaThNLRPjDnDkwmYfMLjLOJoVj4vzFI3t4c8dTORPwU2M/Ar4lt0OMlpWF 7wkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2I7JkxI5MtVO/SyPk3TCAjamGg2Qcc2s2nk2OwgS+3M=; b=3VoPVVJd+6ogKznh2Bjs7uSzvT8g4OhqoB5/FEO0MzNEOwBfgB7rv9cl/DB1H6jihN EFaa1N0NIiTkmRBSceGWEBWTjK+iSvYqk1dYEV0pZLy1nWSGihtapkW1I5YUvOeQPR5q 7rhETmP8/sXccgxYpFA6XP6XiqwHyJkN0G4nmX55C7s1mvnmU1kereuC7/dKW74Dz2ih Qyd7+U3AFFavf875BAygmhl2iww/p+Ez7gkmg0AHR6yYI5XFmgq6QVYcMaU6ui4welFK 3GRekF03xPpC+Gq1GAwZlBJ5n7KaGR73nxXNmtqRZwxnmJnD+IHGw/llG9MJHKBMOAV0 Mzfw== X-Gm-Message-State: AOAM533wmqCkKtLTgt+o4g/LY6xD3ffcS5d6P+VH702dxVRaqJLro8FD +zyBwzgoqU+WLXeewMWffdE= X-Google-Smtp-Source: ABdhPJw9f0dIAgX81zXwy3xIgo0j+HskjqhZyObvNTVqJ5QhNKZFIf8DsBaSOscyvMaaR8VD4NnGUg== X-Received: by 2002:a17:90b:946:: with SMTP id dw6mr7680100pjb.41.1633020557621; Thu, 30 Sep 2021 09:49:17 -0700 (PDT) Received: from ojas ([122.161.49.24]) by smtp.gmail.com with ESMTPSA id y3sm3728261pfr.140.2021.09.30.09.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 09:49:17 -0700 (PDT) Date: Thu, 30 Sep 2021 22:19:11 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq: Update TODO file Message-ID: <20210930164911.GA4746@ojas> References: <20210927181323.10931-1-ojaswin98@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 28, 2021 at 09:10:44AM +0200, Greg KH wrote: > On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote: > > Remove completed tasks from TODO and add some relevant details to task > > 14. > > > > Signed-off-by: Ojaswin Mujoo > > --- > > drivers/staging/vc04_services/interface/TODO | 43 ++++---------------- > > 1 file changed, 7 insertions(+), 36 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > > index 39810ce017cd..5a6b3fc2663a 100644 > > --- a/drivers/staging/vc04_services/interface/TODO > > +++ b/drivers/staging/vc04_services/interface/TODO > > @@ -16,23 +16,6 @@ some of the ones we want: > > to manage these buffers as dmabufs so that we can zero-copy import > > camera images into vc4 for rendering/display. > > > > -2) Garbage-collect unused code > > - > > -One of the reasons this driver wasn't upstreamed previously was that > > -there's a lot code that got built that's probably unnecessary these > > -days. Once we have the set of VCHI-using drivers we want in tree, we > > -should be able to do a sweep of the code to see what's left that's > > -unused. > > - > > -3) Make driver more portable > > - > > -Building this driver with arm/multi_v7_defconfig or arm64/defconfig > > -leads to data corruption during the following command: > > - > > - vchiq_test -f 1 > > - > > -This should be fixed. > > - > > 4) Fix kernel module support Hi Greg, > > Now the numbering is out of order? It was already out of order (No point 11). I assumed it was so that references to the tasks nos in discussion that took place before this patch will make sense. > > How about a first patch to remove the numbering and just replace it with > a list of items that are not numbered, and then remove the tasks that > are already done? Sure I can do that. Thanks for the review. ojaswin > > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC01DC433F5 for ; Thu, 30 Sep 2021 16:52:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC2EA61247 for ; Thu, 30 Sep 2021 16:52:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BC2EA61247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GvpxGaEsfqS0tK2VW339QY9zu7Zk/Lauh2anElJfJRE=; b=qTBVFGvXXDELq+ FwF2jBRunwo3Lwxz2f8SkChPGij5jCFE1DbkX9pDtPNrEeqOno2ieUCmeORchwT9kwOtzLiE1LjUo JC4or3ONygwOq1jQ87MMrWdu96+edyrvc2gK4WhYW6VWuPZQnAgqreyCEKacn/6WLyHSqr0sHEPjs VwPs2QnABL0Jr/QMcg1oSG/tgeYdyuYygZyBLDDILz6k+EkVyoOxF2wvlR2F0julhxHa6+pFQL1f6 2rWv87alrI/agjcHQfjezs5ga7qR9klI8ph3i2miRh2c1/8agWP0RK6qja5+Z9ufJxUPSslvEpCTT p2Q2jV4m6EE0Vjj2Bikw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVzFL-00FH42-JH; Thu, 30 Sep 2021 16:49:23 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVzFI-00FH3C-Dw for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 16:49:21 +0000 Received: by mail-pj1-x102e.google.com with SMTP id v19so4635915pjh.2 for ; Thu, 30 Sep 2021 09:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2I7JkxI5MtVO/SyPk3TCAjamGg2Qcc2s2nk2OwgS+3M=; b=ngwDdmByPwIgkkXgFt4PuFRkQs+EX+S4DN8pih1MtZr0R+zQ2oYxwEhx9xLBVrV1g7 ooSCyl3JWt1hC16qYly/ZhJFHKvMMif/udNuIgtJGabd4OXnCbaZ0+4I0ryizbkVLY/h 5bso0MtXrSg1ZVkgO2mynN3ZPQRQP0dW0+kL2pwbtxajoGLB5cTjPpjN33Mzg/MixN3v tRsxOjnm+gJCuCFyaolzbaEHhlOU+WWdi7x5/GzUjoVFsYFz/KWM1iobnYnxecJuzMAi 7QBPr5I6asPaThNLRPjDnDkwmYfMLjLOJoVj4vzFI3t4c8dTORPwU2M/Ar4lt0OMlpWF 7wkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2I7JkxI5MtVO/SyPk3TCAjamGg2Qcc2s2nk2OwgS+3M=; b=DLSVcFCd9gowETqoKd8qsgeZuxlUBJKi8JWzPrs+kB7WYuU3Q6pVuE7Eg6y84ZsLVl TmFK5m2QwJKY5gxHLwEeb/W8I+rZmjAZv9zA+MJBnPoeeyJ3ThOfw3S3cb3iBb0kMr4a M6zBjideyuJjk119fgXIRvB4cpg5WrbE2f1eFc8L1i5DSEzL5K1531dzUydCkc7ubFxs LgJy4wka0vQK/AlDZ174cl8NYwgQZ/3pTYPVKbQyTliD4MrQwYQ5iZA9SYCXq+Li55+f DcpoCxZig8RXD5fBgOAcYrZHEVbGy8gcJaeZdBbmPvZYwjWagNiaYM7aRl+IrTW5XcgF K1bQ== X-Gm-Message-State: AOAM530nFcINe6+R1AgVyGlK3a6rbAHiX0/5dPLWuspbu2aTebT4VF00 WH75NebopzjMQ6O5iHTmNsY= X-Google-Smtp-Source: ABdhPJw9f0dIAgX81zXwy3xIgo0j+HskjqhZyObvNTVqJ5QhNKZFIf8DsBaSOscyvMaaR8VD4NnGUg== X-Received: by 2002:a17:90b:946:: with SMTP id dw6mr7680100pjb.41.1633020557621; Thu, 30 Sep 2021 09:49:17 -0700 (PDT) Received: from ojas ([122.161.49.24]) by smtp.gmail.com with ESMTPSA id y3sm3728261pfr.140.2021.09.30.09.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 09:49:17 -0700 (PDT) Date: Thu, 30 Sep 2021 22:19:11 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq: Update TODO file Message-ID: <20210930164911.GA4746@ojas> References: <20210927181323.10931-1-ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_094920_493062_4738F122 X-CRM114-Status: GOOD ( 29.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 09:10:44AM +0200, Greg KH wrote: > On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote: > > Remove completed tasks from TODO and add some relevant details to task > > 14. > > > > Signed-off-by: Ojaswin Mujoo > > --- > > drivers/staging/vc04_services/interface/TODO | 43 ++++---------------- > > 1 file changed, 7 insertions(+), 36 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > > index 39810ce017cd..5a6b3fc2663a 100644 > > --- a/drivers/staging/vc04_services/interface/TODO > > +++ b/drivers/staging/vc04_services/interface/TODO > > @@ -16,23 +16,6 @@ some of the ones we want: > > to manage these buffers as dmabufs so that we can zero-copy import > > camera images into vc4 for rendering/display. > > > > -2) Garbage-collect unused code > > - > > -One of the reasons this driver wasn't upstreamed previously was that > > -there's a lot code that got built that's probably unnecessary these > > -days. Once we have the set of VCHI-using drivers we want in tree, we > > -should be able to do a sweep of the code to see what's left that's > > -unused. > > - > > -3) Make driver more portable > > - > > -Building this driver with arm/multi_v7_defconfig or arm64/defconfig > > -leads to data corruption during the following command: > > - > > - vchiq_test -f 1 > > - > > -This should be fixed. > > - > > 4) Fix kernel module support Hi Greg, > > Now the numbering is out of order? It was already out of order (No point 11). I assumed it was so that references to the tasks nos in discussion that took place before this patch will make sense. > > How about a first patch to remove the numbering and just replace it with > a list of items that are not numbered, and then remove the tasks that > are already done? Sure I can do that. Thanks for the review. ojaswin > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel