All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Markus Armbruster <armbru@redhat.com>,
	Eric Blake <eblake@redhat.com>, Cleber Rosa <crosa@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types
Date: Thu, 30 Sep 2021 16:57:13 -0400	[thread overview]
Message-ID: <20210930205716.1148693-11-jsnow@redhat.com> (raw)
In-Reply-To: <20210930205716.1148693-1-jsnow@redhat.com>

The fix for this comment is forthcoming in a future commit, but this
will keep me honest. The linting configuration in ./python/setup.cfg
prohibits 'FIXME' comments. A goal of this long-running series is to
move ./scripts/qapi to ./python/qemu/qapi so that the QAPI generator is
regularly type-checked by GitLab CI.

This comment is a time-bomb to force me to address this issue prior to
that step.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/qapi/parser.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 73c1c4ef599..0265b47b955 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -43,6 +43,10 @@
 # Return value alias for get_expr().
 _ExprValue = Union[List[object], Dict[str, object], str, bool]
 
+# FIXME: Consolidate and centralize definitions for TopLevelExpr,
+# _ExprValue, _JSONValue, and _JSONObject; currently scattered across
+# several modules.
+
 
 class QAPIParseError(QAPISourceError):
     """Error class for all QAPI schema parsing errors."""
-- 
2.31.1



  parent reply	other threads:[~2021-09-30 21:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 20:57 [PATCH v4 00/13] qapi: static typing conversion, pt5b John Snow
2021-09-30 20:57 ` [PATCH v4 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning John Snow
2021-09-30 20:57 ` [PATCH v4 02/13] qapi/gen: use dict.items() to iterate over _modules John Snow
2021-09-30 20:57 ` [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments John Snow
2021-10-01 14:11   ` Markus Armbruster
2021-10-01 18:55     ` John Snow
2021-09-30 20:57 ` [PATCH v4 04/13] qapi: Add spaces after symbol declaration for consistency John Snow
2021-09-30 20:57 ` [PATCH v4 05/13] qapi/parser: remove FIXME comment from _append_body_line John Snow
2021-09-30 20:57 ` [PATCH v4 06/13] qapi/parser: clarify _end_section() logic John Snow
2021-09-30 20:57 ` [PATCH v4 07/13] qapi/parser: Introduce NullSection John Snow
2021-09-30 20:57 ` [PATCH v4 08/13] qapi/parser: add import cycle workaround John Snow
2021-09-30 20:57 ` [PATCH v4 09/13] qapi/parser: add type hint annotations (QAPIDoc) John Snow
2021-09-30 20:57 ` John Snow [this message]
2021-09-30 20:57 ` [PATCH v4 11/13] qapi/parser: enable mypy checks John Snow
2021-09-30 20:57 ` [PATCH v4 12/13] qapi/parser: Silence too-few-public-methods warning John Snow
2021-09-30 20:57 ` [PATCH v4 13/13] qapi/parser: enable pylint checks John Snow
2021-10-01 14:11 ` [PATCH v4 00/13] qapi: static typing conversion, pt5b Markus Armbruster
2021-10-02  6:20   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930205716.1148693-11-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.