From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B861EC433EF for ; Fri, 1 Oct 2021 05:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9859561994 for ; Fri, 1 Oct 2021 05:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352011AbhJAFVh (ORCPT ); Fri, 1 Oct 2021 01:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351982AbhJAFVg (ORCPT ); Fri, 1 Oct 2021 01:21:36 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F575C06176D for ; Thu, 30 Sep 2021 22:19:52 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id m21so8333923pgu.13 for ; Thu, 30 Sep 2021 22:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EyTaw5QtAJ4bW8Vm8xYfacGbohlYt9c/AnSihiB9j34=; b=lHWczr+OPdwO6X6MxEziwiIYJTBe2iPHyLjFCYgLTl/SDrIXrQSS6vb7hnCYEx5bZs d9rHB0J91KliCK2wBSHSVBMNFc5ozW8CIi+2CARgkV1a8mv4S6Xg1wwZ+hD6nn2xdNJE qb+heFtlqPryXdSvgJZC8fLl3cg6iDg4rAcpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EyTaw5QtAJ4bW8Vm8xYfacGbohlYt9c/AnSihiB9j34=; b=TFS5i6cJVs2UpkpuG3VsrHOfPo9JyrVJcZjz5wWX4y53nP49nl85kNtMwn83MqHV7+ BT+h5J6RurVV6WXwUoF18lp6DCYJhGTg3i85BdYot2mixXJt7kMyA6yOLPKhz5+bsL5q 1x2TctxHqvlxFrFHrYzZ9DKwD619QGmSMUy2Nl6UomS8xnWZhO3IZDqjy4OyNuuATlk6 iyzDjc6IjokHyCtMx3BEQojvFr0sm80T65m0XVpx0Fv0KqiYUugeaJOB56gCRnJhuoAr n2km2q7RtXSo7N5cx/1GgPGkNTuBs5BHAE/lWIEvHhjs9DODxbdo+5NdVda/nnXf6rBI QkBg== X-Gm-Message-State: AOAM532sf+pF856gdPNFV3L6gpJ32/j1kppTon9yytHbq4cKaYi0sljh qQg+iDuc8iyxVkAaHPBhR9FgJg== X-Google-Smtp-Source: ABdhPJzprmCx1Nw75Isx1VIHD4op+s7oTt9KX5oRihjuhzp0VAPFJJOk8T2ufUoBr/6/fUvG1cvJ0g== X-Received: by 2002:a65:51c7:: with SMTP id i7mr8248588pgq.300.1633065592032; Thu, 30 Sep 2021 22:19:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k2sm6543077pjq.28.2021.09.30.22.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 22:19:51 -0700 (PDT) Date: Thu, 30 Sep 2021 22:19:50 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: Andrew Morton , Colin Cross , Sumit Semwal , Michal Hocko , Dave Hansen , Matthew Wilcox , "Kirill A . Shutemov" , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Al Viro , Randy Dunlap , Kalesh Singh , Peter Xu , rppt@kernel.org, Peter Zijlstra , Catalin Marinas , vincenzo.frascino@arm.com, Chinwen Chang =?utf-8?B?KOW8temMpuaWhyk=?= , Axel Rasmussen , Andrea Arcangeli , Jann Horn , apopple@nvidia.com, John Hubbard , Yu Zhao , Will Deacon , fenghua.yu@intel.com, thunder.leizhen@huawei.com, Hugh Dickins , feng.tang@intel.com, Jason Gunthorpe , Roman Gushchin , Thomas Gleixner , krisman@collabora.com, chris.hyser@oracle.com, Peter Collingbourne , "Eric W. Biederman" , Jens Axboe , legion@kernel.org, Rolf Eike Beer , Cyrill Gorcunov , Muchun Song , Viresh Kumar , Thomas Cedeno , sashal@kernel.org, cxfcosmos@gmail.com, Rasmus Villemoes , LKML , linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm , kernel-team Subject: Re: [PATCH v9 2/3] mm: add a field to store names for private anonymous memory Message-ID: <202109302219.FF1F3E24@keescook> References: <20210902231813.3597709-1-surenb@google.com> <20210902231813.3597709-2-surenb@google.com> <202109031439.B58932AF0@keescook> <202109031522.ACDF5BA8@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 08:44:25PM -0700, Suren Baghdasaryan wrote: > While testing v10 I found one case when () are used in the name > "dalvik-main space (region space)". So I can add ` and $ to the > restricted set but not ( and ). Kees, would you be happy with: > > static inline bool is_valid_name_char(char ch) > { > return ch > 0x1f && ch < 0x7f && !strchr("\\`$[]", ch); > } > > ? That works for me! :) -- Kees Cook