From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDABC433F5 for ; Fri, 1 Oct 2021 08:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D382161A80 for ; Fri, 1 Oct 2021 08:56:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241512AbhJAI55 (ORCPT ); Fri, 1 Oct 2021 04:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhJAI55 (ORCPT ); Fri, 1 Oct 2021 04:57:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 746C9C061775 for ; Fri, 1 Oct 2021 01:56:13 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWEKw-0004mI-Og; Fri, 01 Oct 2021 10:56:10 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mWEKw-00041u-55; Fri, 01 Oct 2021 10:56:10 +0200 Date: Fri, 1 Oct 2021 10:56:10 +0200 From: Michael Tretter To: vkoul@kernel.org, dmaengine@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, appana.durga.rao@xilinx.com, michal.simek@xilinx.com, kernel@pengutronix.de Subject: Re: [PATCH 0/7] dmaengine: zynqmp_dma: fix lockdep warning and cleanup Message-ID: <20211001085610.GD28226@pengutronix.de> References: <20210826094742.1302009-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210826094742.1302009-1-m.tretter@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:54:53 up 225 days, 12:18, 134 users, load average: 0.18, 0.29, 0.26 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, 26 Aug 2021 11:47:35 +0200, Michael Tretter wrote: > I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0]. > This series fixes the reported warning and performs some cleanup that I found > while looking at the driver more closely. > > Patches 1-4 are the cleanups. They affect the log output of the driver, allow > to compile the driver on other platforms when COMPILE_TEST is enabled, and > remove unused included header files from the driver. > > Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the > locking in the driver to make it more fine-grained instead of holding the lock > for the entire tasklet. Patch 7 finally fixes the warning. Gentle ping. Michael > > Michael > > [0] https://lore.kernel.org/linux-arm-kernel/20210601130108.GA12967@pengutronix.de/ > > Michael Tretter (7): > dmaengine: zynqmp_dma: simplify with dev_err_probe > dmaengine: zynqmp_dma: drop message on probe success > dmaengine: zynqmp_dma: enable COMPILE_TEST > dmaengine: zynqmp_dma: cleanup includes > dmaengine: zynqmp_dma: cleanup after completing all descriptors > dmaengine: zynqmp_dma: refine dma descriptor locking > dmaengine: zynqmp_dma: fix lockdep warning in tasklet > > drivers/dma/Kconfig | 2 +- > drivers/dma/xilinx/zynqmp_dma.c | 67 +++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 34 deletions(-) > > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845DFC433F5 for ; Fri, 1 Oct 2021 08:58:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 511C261A7D for ; Fri, 1 Oct 2021 08:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 511C261A7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5NW4jtMVzcPee6e9BYpDQ4klAHSpaDN4qJz3IaKKWyM=; b=4sWIRjgYJyWzF6 /mpIPQJKeDVrjZ6th8lWnz9hO2YqK2OCwXyll7GZ72kHCcQCPz0HKxHL7+f2G4OYT/0juKno9BhVQ VnbhhFDEgHdzTuYN4rD8RzZrkUCJqQZ5zjwQ3+LgN0PUzkKalRJna47QRrrPHCrday/ey6smACqPv 4V+2J3abnwKLRC023IXuijNEEtjQhwTiFn3zzvHWwwoMNF62PmgptUWsfP1hqjgvIGeffgmxbqZAt Xmn7u/JM+ZvDXXg8zJtjlgbxnOqbbQX/Iw9qAUQCf5GLBctnVes+HhAqfgQmbUomUzqiBr8lu5VTx OiDk1xiXVaPqa96AoyXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWEL7-00H8m6-9Y; Fri, 01 Oct 2021 08:56:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWEL3-00H8kd-5C for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 08:56:18 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWEKw-0004mI-Og; Fri, 01 Oct 2021 10:56:10 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mWEKw-00041u-55; Fri, 01 Oct 2021 10:56:10 +0200 Date: Fri, 1 Oct 2021 10:56:10 +0200 From: Michael Tretter To: vkoul@kernel.org, dmaengine@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, appana.durga.rao@xilinx.com, michal.simek@xilinx.com, kernel@pengutronix.de Subject: Re: [PATCH 0/7] dmaengine: zynqmp_dma: fix lockdep warning and cleanup Message-ID: <20211001085610.GD28226@pengutronix.de> References: <20210826094742.1302009-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210826094742.1302009-1-m.tretter@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:54:53 up 225 days, 12:18, 134 users, load average: 0.18, 0.29, 0.26 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_015617_220143_FB8F6CAB X-CRM114-Status: GOOD ( 22.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Aug 2021 11:47:35 +0200, Michael Tretter wrote: > I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0]. > This series fixes the reported warning and performs some cleanup that I found > while looking at the driver more closely. > > Patches 1-4 are the cleanups. They affect the log output of the driver, allow > to compile the driver on other platforms when COMPILE_TEST is enabled, and > remove unused included header files from the driver. > > Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the > locking in the driver to make it more fine-grained instead of holding the lock > for the entire tasklet. Patch 7 finally fixes the warning. Gentle ping. Michael > > Michael > > [0] https://lore.kernel.org/linux-arm-kernel/20210601130108.GA12967@pengutronix.de/ > > Michael Tretter (7): > dmaengine: zynqmp_dma: simplify with dev_err_probe > dmaengine: zynqmp_dma: drop message on probe success > dmaengine: zynqmp_dma: enable COMPILE_TEST > dmaengine: zynqmp_dma: cleanup includes > dmaengine: zynqmp_dma: cleanup after completing all descriptors > dmaengine: zynqmp_dma: refine dma descriptor locking > dmaengine: zynqmp_dma: fix lockdep warning in tasklet > > drivers/dma/Kconfig | 2 +- > drivers/dma/xilinx/zynqmp_dma.c | 67 +++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 34 deletions(-) > > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel