All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	jic23@kernel.org
Subject: Re: [PATCH v1 1/1] seq_file: Move seq_escape() to a header
Date: Fri, 1 Oct 2021 16:39:31 -0700	[thread overview]
Message-ID: <20211001163931.e3bb7bf5a401fa982fda5bb2@linux-foundation.org> (raw)
In-Reply-To: <20211001122917.67228-1-andriy.shevchenko@linux.intel.com>

On Fri,  1 Oct 2021 15:29:17 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Move seq_escape() to the header as inliner.

Some reason for doing this would be nice.  Does it make the kernel
smaller?  Is this performance-sensitive?

> --- a/include/linux/seq_file.h
> +++ b/include/linux/seq_file.h
> @@ -4,6 +4,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/string.h>
> +#include <linux/string_helpers.h>

Why was this added?

>  #include <linux/bug.h>
>  #include <linux/mutex.h>
>  #include <linux/cpumask.h>


  reply	other threads:[~2021-10-01 23:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 12:29 [PATCH v1 1/1] seq_file: Move seq_escape() to a header Andy Shevchenko
2021-10-01 23:39 ` Andrew Morton [this message]
2021-10-02  7:57   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001163931.e3bb7bf5a401fa982fda5bb2@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.