From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A70C433FE for ; Sat, 2 Oct 2021 16:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 197D761B04 for ; Sat, 2 Oct 2021 16:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233528AbhJBQGz (ORCPT ); Sat, 2 Oct 2021 12:06:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:38896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232575AbhJBQGy (ORCPT ); Sat, 2 Oct 2021 12:06:54 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A896E61B20; Sat, 2 Oct 2021 16:05:03 +0000 (UTC) Date: Sat, 2 Oct 2021 17:09:01 +0100 From: Jonathan Cameron To: Martin Blumenstingl Cc: Cai Huoqing , Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Andy Gross , Bjorn Andersson , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() Message-ID: <20211002170901.7378fcc4@jic23-huawei> In-Reply-To: References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-6-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, 2 Oct 2021 15:01:56 +0200 Martin Blumenstingl wrote: > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > > > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing > Reviewed-by: Martin Blumenstingl > as well as: > Reviewed-by: Martin Blumenstingl > # Odroid-C1 Hi Martin, Confusing tag. Was the second meant to be a Tested-by? Thanks, Jonathan > > Thanks for your contribution! > > > Best regards, > Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4CDBC433EF for ; Sat, 2 Oct 2021 16:05:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CCE761B20 for ; Sat, 2 Oct 2021 16:05:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CCE761B20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kV/uQzZ0lSHpQ2oyDlNta7OJ4DupceykNhGyL4D34Ys=; b=DymHjc7qPdp9Iq v19CWLdak6TcamOk+3cexERJzggRl6UPEcDnj/hGDv4UB8afEvpN8kEVKQKyjbVQRdkjvnltqE6/g 3gLbBcVuDLkJP+HC4ce5gyvwgxoMRlwPmhOgI25ct9dDCBM5qfs8Y2bZBQ+0xEhUQKfNSbkuw86qq mdDOTHR/rG/F2JmDlvBkSgxh86udxywn1ehj9ssicsWIwzfEM5atKQCd5iqbpoR9kD4Kerw5dMW9o UUgut3P4JtGZF3OJzVM1wKzaYr438mUujU0B8BKo0bkMnxTdxS9vmAECpKu4TV7GMfBQzEVMkk2tc e0PIhKsNKpO8rVGzv1yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVs-002PQM-Vx; Sat, 02 Oct 2021 16:05:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVf-002PNn-Hq; Sat, 02 Oct 2021 16:05:12 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A896E61B20; Sat, 2 Oct 2021 16:05:03 +0000 (UTC) Date: Sat, 2 Oct 2021 17:09:01 +0100 From: Jonathan Cameron To: Martin Blumenstingl Cc: Cai Huoqing , Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Andy Gross , Bjorn Andersson , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() Message-ID: <20211002170901.7378fcc4@jic23-huawei> In-Reply-To: References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-6-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211002_090511_643650_F58CAF61 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, 2 Oct 2021 15:01:56 +0200 Martin Blumenstingl wrote: > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > > > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing > Reviewed-by: Martin Blumenstingl > as well as: > Reviewed-by: Martin Blumenstingl > # Odroid-C1 Hi Martin, Confusing tag. Was the second meant to be a Tested-by? Thanks, Jonathan > > Thanks for your contribution! > > > Best regards, > Martin _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A5AC433F5 for ; Sat, 2 Oct 2021 16:05:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64CA961B04 for ; Sat, 2 Oct 2021 16:05:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64CA961B04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iFdxBPDpNTPb9oRzcsj9lQl4njuIj0bIyhnPLwlsWOI=; b=YgZ/9Jd7f9J6bJ 5zwTvuHmawopex64yXb0zh04GMm3fuoN8JLql34WPXQHDscMLZpknov9jE88W85W7ldk6zdye2BdO G7deSRYM953gUUGotUfnaJ0IGxLam+ylOEQoPlFPgNKcw8YpYfaLOJ24xb5etxikwfjy0RPkT+9Q1 CkaGk4u3ukKLV3ptONFZcEF+GS4lOUrjLEPv+1Zx6r3e4GuUM1Xamsq6rPBIkt1jbI/I1Pl0iblOl dX4eAkEhAkVcaNX1Ja8t7gyz1vUwmVtmffg7Ykauh2BxjYt6oT7v3sLMmhtwR42ngZoRWpbGli1cV xGGsb1iq755Zu06SDJPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVi-002POi-K2; Sat, 02 Oct 2021 16:05:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVf-002PNn-Hq; Sat, 02 Oct 2021 16:05:12 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A896E61B20; Sat, 2 Oct 2021 16:05:03 +0000 (UTC) Date: Sat, 2 Oct 2021 17:09:01 +0100 From: Jonathan Cameron To: Martin Blumenstingl Cc: Cai Huoqing , Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Andy Gross , Bjorn Andersson , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() Message-ID: <20211002170901.7378fcc4@jic23-huawei> In-Reply-To: References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-6-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211002_090511_643650_F58CAF61 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, 2 Oct 2021 15:01:56 +0200 Martin Blumenstingl wrote: > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > > > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing > Reviewed-by: Martin Blumenstingl > as well as: > Reviewed-by: Martin Blumenstingl > # Odroid-C1 Hi Martin, Confusing tag. Was the second meant to be a Tested-by? Thanks, Jonathan > > Thanks for your contribution! > > > Best regards, > Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFE2C433F5 for ; Sat, 2 Oct 2021 16:07:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6C2F61A05 for ; Sat, 2 Oct 2021 16:07:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6C2F61A05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NaONAHiP1hGtmqr1WL20Xx9y0mu4bkupXxvi5mUpy9A=; b=2wNr86DIG0fTWy gSkLML+8TRvGxHgHDBDvvBYq+5jiEQ2Jt8gWHVQIk5hJ5yG3r2ePfAI3eLy3lgUH9cIZfQcxuhug0 miBARJE2jQpboPzNh3cTKJhFKEFzaCKPwrSXRcw2mDNReISAGzPBc4Ps2463M05Hqpz8kBhJ1nSr8 4h6OWvrSSUeAVtjyGBNiL8knojsJJgVkJtd3A83ulumIP4bIIL2YFNY/FJszxzi9H09JPndV9tCcj aTkML7TwUkKobbeVS6czwt7PchS1qKEZnzeKg4PliarnNY2ISJFawjo1OeljvHtSIVIZ8Bzoyyn6g Tb3GIVHlgLlq3SD05wtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVk-002POw-8z; Sat, 02 Oct 2021 16:05:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWhVf-002PNn-Hq; Sat, 02 Oct 2021 16:05:12 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A896E61B20; Sat, 2 Oct 2021 16:05:03 +0000 (UTC) Date: Sat, 2 Oct 2021 17:09:01 +0100 From: Jonathan Cameron To: Martin Blumenstingl Cc: Cai Huoqing , Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Andy Gross , Bjorn Andersson , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() Message-ID: <20211002170901.7378fcc4@jic23-huawei> In-Reply-To: References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-6-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211002_090511_643650_F58CAF61 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2 Oct 2021 15:01:56 +0200 Martin Blumenstingl wrote: > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > > > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing > Reviewed-by: Martin Blumenstingl > as well as: > Reviewed-by: Martin Blumenstingl > # Odroid-C1 Hi Martin, Confusing tag. Was the second meant to be a Tested-by? Thanks, Jonathan > > Thanks for your contribution! > > > Best regards, > Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel