All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: linux-bluetooth@vger.kernel.org
Cc: "Thomas Weißschuh" <thomas@t-8ch.de>
Subject: [PATCH BlueZ] Use accurate icons for headphones and headsets
Date: Sun,  3 Oct 2021 12:18:34 +0200	[thread overview]
Message-ID: <20211003101834.45448-1-thomas@t-8ch.de> (raw)

While these icon names are not part of the spec standard names [0] they
are in practice implemented by at least Adwaita, Gnome, Oxygen, Arc and Breeze
themes.

[0] https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html
---
 src/dbus-common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/dbus-common.c b/src/dbus-common.c
index 384f27700..5e2c83d52 100644
--- a/src/dbus-common.c
+++ b/src/dbus-common.c
@@ -72,9 +72,9 @@ const char *class_to_icon(uint32_t class)
 		switch ((class & 0xfc) >> 2) {
 		case 0x01:
 		case 0x02:
-			return "audio-card";	/* Headset */
+			return "audio-headset";
 		case 0x06:
-			return "audio-card";	/* Headphone */
+			return "audio-headphones";
 		case 0x0b: /* VCR */
 		case 0x0c: /* Video Camera */
 		case 0x0d: /* Camcorder */

base-commit: c1e6d6c46fcab55ec820bb83396fff57ffd22e26
-- 
2.33.0


             reply	other threads:[~2021-10-03 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-03 10:18 Thomas Weißschuh [this message]
2021-10-03 10:37 ` [BlueZ] Use accurate icons for headphones and headsets bluez.test.bot
2021-10-05  4:15   ` Luiz Augusto von Dentz
2021-10-05  7:07     ` thomas
2021-10-12 21:50       ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211003101834.45448-1-thomas@t-8ch.de \
    --to=thomas@t-8ch.de \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.