From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF4CC433EF for ; Sun, 3 Oct 2021 16:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1627F6124C for ; Sun, 3 Oct 2021 16:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbhJCQCW (ORCPT ); Sun, 3 Oct 2021 12:02:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:50476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbhJCQCW (ORCPT ); Sun, 3 Oct 2021 12:02:22 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E58A961215; Sun, 3 Oct 2021 16:00:33 +0000 (UTC) Date: Sun, 3 Oct 2021 17:04:31 +0100 From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Jonathan Cameron , Gwendal Grignou , Guenter Roeck , Enric Balletbo i Serra Subject: Re: [PATCH] iio: cros_ec: Update header includes Message-ID: <20211003170431.00dab6bc@jic23-huawei> In-Reply-To: <20210608212834.4046618-1-jic23@kernel.org> References: <20210608212834.4046618-1-jic23@kernel.org> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 8 Jun 2021 22:28:34 +0100 Jonathan Cameron wrote: > From: Jonathan Cameron > > General driver churn doesn't always include updates of header includes. > Manual review of the output of the include-what-you-use checker lead to the > following cleanup. Hopefuly this brings things back to a good state for the > cros_ec sensor drivers. > > Signed-off-by: Jonathan Cameron > Cc: Gwendal Grignou > Cc: Guenter Roeck > Cc: Enric Balletbo i Serra I've sent a new version of this (at least partly because I'd forgotten I'd done it before and no reply to this since posting in June :( Anyhow, that version only deals with IIO headers so is smaller and easier to consider in isolation. If people prefer this one I'm happy as well. Thanks, Jonathan > --- > drivers/iio/accel/cros_ec_accel_legacy.c | 7 +------ > drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c | 8 ++------ > drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 7 ++----- > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 6 ++++-- > drivers/iio/light/cros_ec_light_prox.c | 8 ++------ > drivers/iio/pressure/cros_ec_baro.c | 7 ++----- > 6 files changed, 13 insertions(+), 30 deletions(-) > > diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c b/drivers/iio/accel/cros_ec_accel_legacy.c > index b6f3471b62dc..5b24b762b2dd 100644 > --- a/drivers/iio/accel/cros_ec_accel_legacy.c > +++ b/drivers/iio/accel/cros_ec_accel_legacy.c > @@ -9,17 +9,12 @@ > * Accelerometer access is presented through iio sysfs. > */ > > -#include > #include > -#include > #include > #include > -#include > -#include > -#include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c b/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > index af801e203623..497deaf9d96a 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_lid_angle.c > @@ -10,20 +10,16 @@ > * iio sysfs. > */ > > -#include > #include > -#include > #include > #include > -#include > -#include > #include > -#include > #include > #include > +#include > +#include > #include > #include > -#include > > #define DRV_NAME "cros-ec-lid-angle" > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > index 376a5b30010a..de8b01501cc5 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > @@ -9,18 +9,15 @@ > */ > > #include > -#include > #include > #include > -#include > -#include > -#include > #include > #include > +#include > +#include > #include > #include > #include > -#include > > #define CROS_EC_SENSORS_MAX_CHANNELS 4 > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > index 28bde13003b7..370d1017b533 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -12,12 +12,14 @@ > #include > #include > #include > -#include > #include > #include > +#include > #include > #include > -#include > +#include > +#include > +#include > #include > #include > #include > diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c > index de472f23d1cb..062e02adac65 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -6,19 +6,15 @@ > */ > > #include > -#include > #include > #include > -#include > -#include > -#include > -#include > #include > #include > +#include > +#include > #include > #include > #include > -#include > > /* > * We only represent one entry for light or proximity. EC is merging different > diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c > index 2f882e109423..5a0d9dd1e78a 100644 > --- a/drivers/iio/pressure/cros_ec_baro.c > +++ b/drivers/iio/pressure/cros_ec_baro.c > @@ -6,16 +6,13 @@ > */ > > #include > -#include > #include > #include > -#include > -#include > -#include > #include > #include > #include > -#include > +#include > +#include > #include > #include > #include