* [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
@ 2021-09-24 12:45 James Hilliard
2021-10-01 10:25 ` Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
0 siblings, 2 replies; 5+ messages in thread
From: James Hilliard @ 2021-09-24 12:45 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro, James Hilliard, Philippe Normand
This is only a runtime dependency not a build dependency.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/wpewebkit/wpewebkit.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index 5c5e6625f8..50714b4366 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
WPEWEBKIT_CONF_OPTS += \
-DENABLE_VIDEO=ON \
-DENABLE_WEB_AUDIO=ON
-WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
+WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
else
WPEWEBKIT_CONF_OPTS += \
-DENABLE_VIDEO=OFF \
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
2021-09-24 12:45 [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies James Hilliard
@ 2021-10-01 10:25 ` Adrian Perez de Castro
2021-10-01 10:35 ` Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
1 sibling, 1 reply; 5+ messages in thread
From: Adrian Perez de Castro @ 2021-10-01 10:25 UTC (permalink / raw)
To: James Hilliard; +Cc: James Hilliard, Philippe Normand, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1024 bytes --]
On Fri, 24 Sep 2021 06:45:25 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> This is only a runtime dependency not a build dependency.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Reviewed-by: Adrian perez de Castro <aperez@igalia.com>
> ---
> package/wpewebkit/wpewebkit.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 5c5e6625f8..50714b4366 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
> WPEWEBKIT_CONF_OPTS += \
> -DENABLE_VIDEO=ON \
> -DENABLE_WEB_AUDIO=ON
> -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
> else
> WPEWEBKIT_CONF_OPTS += \
> -DENABLE_VIDEO=OFF \
> --
> 2.25.1
>
We should do the same edit in package/webkitgtk/webkitgtk.mk :)
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
2021-10-01 10:25 ` Adrian Perez de Castro
@ 2021-10-01 10:35 ` Adrian Perez de Castro
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Perez de Castro @ 2021-10-01 10:35 UTC (permalink / raw)
To: James Hilliard; +Cc: James Hilliard, Philippe Normand, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1274 bytes --]
On Fri, 01 Oct 2021 13:25:59 +0300 Adrian Perez de Castro <aperez@igalia.com> wrote:
> On Fri, 24 Sep 2021 06:45:25 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> > This is only a runtime dependency not a build dependency.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> Reviewed-by: Adrian perez de Castro <aperez@igalia.com>
>
> > ---
> > package/wpewebkit/wpewebkit.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> > index 5c5e6625f8..50714b4366 100644
> > --- a/package/wpewebkit/wpewebkit.mk
> > +++ b/package/wpewebkit/wpewebkit.mk
> > @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
> > WPEWEBKIT_CONF_OPTS += \
> > -DENABLE_VIDEO=ON \
> > -DENABLE_WEB_AUDIO=ON
> > -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> > +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
> > else
> > WPEWEBKIT_CONF_OPTS += \
> > -DENABLE_VIDEO=OFF \
> > --
> > 2.25.1
> >
>
> We should do the same edit in package/webkitgtk/webkitgtk.mk :)
Done in https://patchwork.ozlabs.org/project/buildroot/patch/20211001103417.1078082-1-aperez@igalia.com/
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
2021-09-24 12:45 [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies James Hilliard
2021-10-01 10:25 ` Adrian Perez de Castro
@ 2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2021-10-03 20:15 UTC (permalink / raw)
To: James Hilliard; +Cc: Adrian Perez de Castro, Philippe Normand, buildroot
James, All,
On 2021-09-24 06:45 -0600, James Hilliard spake thusly:
> This is only a runtime dependency not a build dependency.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/wpewebkit/wpewebkit.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 5c5e6625f8..50714b4366 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
> WPEWEBKIT_CONF_OPTS += \
> -DENABLE_VIDEO=ON \
> -DENABLE_WEB_AUDIO=ON
> -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
> else
> WPEWEBKIT_CONF_OPTS += \
> -DENABLE_VIDEO=OFF \
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies
2021-10-03 20:15 ` Yann E. MORIN
@ 2021-10-06 15:18 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-10-06 15:18 UTC (permalink / raw)
To: Yann E. MORIN
Cc: Adrian Perez de Castro, James Hilliard, Philippe Normand, buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> James, All,
> On 2021-09-24 06:45 -0600, James Hilliard spake thusly:
>> This is only a runtime dependency not a build dependency.
>>
>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> Applied to master, thanks.
> Regards,
> Yann E. MORIN.
>> ---
>> package/wpewebkit/wpewebkit.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
>> index 5c5e6625f8..50714b4366 100644
>> --- a/package/wpewebkit/wpewebkit.mk
>> +++ b/package/wpewebkit/wpewebkit.mk
>> @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
>> WPEWEBKIT_CONF_OPTS += \
>> -DENABLE_VIDEO=ON \
>> -DENABLE_WEB_AUDIO=ON
>> -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
>> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
NIT: we normally add a # runtime comment to the select line in Config.in
then to make it clear why it isn't listed in _DEPENDENCIES.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-06 15:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 12:45 [Buildroot] [PATCH 1/1] package/wpewebkit: remove gst1-plugins-good from dependencies James Hilliard
2021-10-01 10:25 ` Adrian Perez de Castro
2021-10-01 10:35 ` Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.