From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: linux-usb@vger.kernel.org
Cc: balbi@kernel.org, laurent.pinchart@ideasonboard.com,
paul.elder@ideasonboard.com, kernel@pengutronix.de,
caleb.connolly@ideasonboard.com
Subject: [PATCH v2 6/7] usb: gadget: uvc: ensure the vdev is unset
Date: Sun, 3 Oct 2021 22:29:38 +0200 [thread overview]
Message-ID: <20211003202939.306-7-m.grzeschik@pengutronix.de> (raw)
In-Reply-To: <20211003202939.306-1-m.grzeschik@pengutronix.de>
Since the uvc video device is created on demand, we have to ensure
that the struct is always zeroed. Otherwise the previous settings
might collide with the new values.
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
v2: - added reviewed by
- fixed patch description
drivers/usb/gadget/function/f_uvc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
index 1e93ab5c0c88d..b3279ba357331 100644
--- a/drivers/usb/gadget/function/f_uvc.c
+++ b/drivers/usb/gadget/function/f_uvc.c
@@ -417,6 +417,7 @@ uvc_register_video(struct uvc_device *uvc)
int ret;
/* TODO reference counting. */
+ memset(&uvc->vdev, 0, sizeof(struct video_device));
uvc->vdev.v4l2_dev = &uvc->v4l2_dev;
uvc->vdev.v4l2_dev->dev = &cdev->gadget->dev;
uvc->vdev.fops = &uvc_v4l2_fops;
--
2.30.2
next prev parent reply other threads:[~2021-10-03 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 20:29 [PATCH v2 0/7] usb: gadget: uvc: smaller fixes for stability Michael Grzeschik
2021-10-03 20:29 ` [PATCH v2 1/7] usb: gadget: uvc: consistently use define for headerlen Michael Grzeschik
2021-10-03 20:29 ` [PATCH v2 2/7] usb: gadget: uvc: rename function to be more consistent Michael Grzeschik
2021-10-03 20:29 ` [PATCH v2 3/7] usb: gadget: uvc: test if ep->desc is valid on ep_queue Michael Grzeschik
2021-10-03 20:29 ` [PATCH v2 4/7] usb: gadget: uvc: only schedule stream in streaming state Michael Grzeschik
2021-10-03 20:29 ` [PATCH v2 5/7] usb: gadget: uvc: only pump video data if necessary Michael Grzeschik
2021-10-03 20:29 ` Michael Grzeschik [this message]
2021-10-03 20:29 ` [PATCH v2 7/7] usb: gadget: udc: ensure the gadget is still available Michael Grzeschik
2021-10-04 22:43 ` [PATCH v2 0/7] usb: gadget: uvc: smaller fixes for stability Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003202939.306-7-m.grzeschik@pengutronix.de \
--to=m.grzeschik@pengutronix.de \
--cc=balbi@kernel.org \
--cc=caleb.connolly@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-usb@vger.kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.