From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B210C433F5 for ; Mon, 4 Oct 2021 03:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ECFD61354 for ; Mon, 4 Oct 2021 03:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbhJDD1v (ORCPT ); Sun, 3 Oct 2021 23:27:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:43930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230295AbhJDD1u (ORCPT ); Sun, 3 Oct 2021 23:27:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4BD9B61351; Mon, 4 Oct 2021 03:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633317962; bh=rnrznOFRMDEvjI/ziBQpTfMzTrkNi2HgQnQTm+R3nLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H6XFNi8ael9eduJ+H+QacrO11faHRWze0V0LBL8ngcegV4r8AVjdyYt5CetaS6oBH j8e6/PyZ50aRIOPHQZJpHG7oh/NnPlAnbMJ6YP3hcBugWHQ93f3P8TSaFvzTRn9Yp5 OmmCSIv7GscQRkxz/S72REVMcECfNpYy6KUHTBVtnbPwZZMN0r93kA9NUTYd/xdkx8 GZmKsYXyGnGhihOsgoRDVKrTF52YcuqPKJMexL5AIp30fNxiS4Nrlmq1zM3aYvLWb2 qdYeKm5/hd9kAPw7h7wh31QG5hpZ35DB2EB7Dl/wfb8raDT+m7bVWJhYfioHnSXdwY e/V4VjhEHi24A== Date: Mon, 4 Oct 2021 11:25:57 +0800 From: Shawn Guo To: haibo.chen@nxp.com Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: imx: change the spi-nor tx Message-ID: <20211004032556.GA15650@dragon> References: <1629451790-10507-1-git-send-email-haibo.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1629451790-10507-1-git-send-email-haibo.chen@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 20, 2021 at 05:29:49PM +0800, haibo.chen@nxp.com wrote: > From: Haibo Chen > > Before commit 0e30f47232ab5 ("mtd: spi-nor: add support for DTR protocol"), > for all PP command, it only support 1-1-1 mode, no matter the tx setting > in dts. But after the upper commit, the logic change. It will choose > the best mode(fastest mode) which flash device and spi-nor host controller > both support. > > Though the spi-nor device on imx6sx-sdb/imx6ul(l/z)-14x14-evk board > do not support PP-1-4-4/PP-1-1-4, but if tx is 4 in dts file, it will also > impact the read mode selection. For the spi-nor device on the upper mentioned > boards, they support read 1-4-4 mode and read 1-1-4 mode according to the > device internal sfdp register. But qspi host controller do not support > read 1-4-4 mode. so need to set the tx to 1, let the common code finally > select read 1-1-4 mode, PP-1-1-1 mode. > > Signed-off-by: Haibo Chen Applied both, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08CFC433F5 for ; Mon, 4 Oct 2021 03:28:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C7D461075 for ; Mon, 4 Oct 2021 03:28:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C7D461075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8SeZXDFHsd4DGMXs7GOmcKb7nDX42Wd2i+2aGoCs7Ik=; b=D4/726iCbMP6G9 otwyAC/Aawbz8LTGTraadMwdoytgS3WQRgnUnAONUY4LgBdE5OCDU7YBkdF+qgjHzyxcnLbIIB49G mcV1xUr1YSnoGaHXjOS+HrhZrJ9GVuH5Nk8BZEzbvVCVDoci7cKYq3VZbv3eJXwAQsP06WXvvVR+c opccxaO+WwLm3ZSn67wmlNN87SwhA00FT+d/tzTtglyEQ+5XP3kUyE9WnkxUsBP4pfggKIBwYEAXQ /z5VH211GBNRdJhqoVZBvW7lor6BfkVsyFf+Yt+pE383AzTQ9BMXu4Be/kTkymH3Wr3pAnPnNj/eR ULICZ//48h5d8ECC3vqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXEcB-004yCJ-4G; Mon, 04 Oct 2021 03:26:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXEc7-004yBh-NY for linux-arm-kernel@lists.infradead.org; Mon, 04 Oct 2021 03:26:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4BD9B61351; Mon, 4 Oct 2021 03:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633317962; bh=rnrznOFRMDEvjI/ziBQpTfMzTrkNi2HgQnQTm+R3nLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H6XFNi8ael9eduJ+H+QacrO11faHRWze0V0LBL8ngcegV4r8AVjdyYt5CetaS6oBH j8e6/PyZ50aRIOPHQZJpHG7oh/NnPlAnbMJ6YP3hcBugWHQ93f3P8TSaFvzTRn9Yp5 OmmCSIv7GscQRkxz/S72REVMcECfNpYy6KUHTBVtnbPwZZMN0r93kA9NUTYd/xdkx8 GZmKsYXyGnGhihOsgoRDVKrTF52YcuqPKJMexL5AIp30fNxiS4Nrlmq1zM3aYvLWb2 qdYeKm5/hd9kAPw7h7wh31QG5hpZ35DB2EB7Dl/wfb8raDT+m7bVWJhYfioHnSXdwY e/V4VjhEHi24A== Date: Mon, 4 Oct 2021 11:25:57 +0800 From: Shawn Guo To: haibo.chen@nxp.com Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: imx: change the spi-nor tx Message-ID: <20211004032556.GA15650@dragon> References: <1629451790-10507-1-git-send-email-haibo.chen@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1629451790-10507-1-git-send-email-haibo.chen@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211003_202603_825043_F6D4F2D5 X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 20, 2021 at 05:29:49PM +0800, haibo.chen@nxp.com wrote: > From: Haibo Chen > > Before commit 0e30f47232ab5 ("mtd: spi-nor: add support for DTR protocol"), > for all PP command, it only support 1-1-1 mode, no matter the tx setting > in dts. But after the upper commit, the logic change. It will choose > the best mode(fastest mode) which flash device and spi-nor host controller > both support. > > Though the spi-nor device on imx6sx-sdb/imx6ul(l/z)-14x14-evk board > do not support PP-1-4-4/PP-1-1-4, but if tx is 4 in dts file, it will also > impact the read mode selection. For the spi-nor device on the upper mentioned > boards, they support read 1-4-4 mode and read 1-1-4 mode according to the > device internal sfdp register. But qspi host controller do not support > read 1-4-4 mode. so need to set the tx to 1, let the common code finally > select read 1-1-4 mode, PP-1-1-1 mode. > > Signed-off-by: Haibo Chen Applied both, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel