[PATCH] turbostat: fix PC6 displaying on some systems

[PATCH] turbostat: fix PC6 displaying on some systems

[Artem Bityutskiy]

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
and turbostat decodes it.

Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
(ICX), treats it as "unknown", and does not display any package C-states in the
results table.

After this patch: turbostat recognizes value 3 on ICX, treats it as "PC6", and
correctly displays package C-states in the results table.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 47d3ba895d6d..bc5ae0872fed 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -2323,7 +2323,7 @@ int skx_pkg_cstate_limits[16] =
 };
 
 int icx_pkg_cstate_limits[16] =
-    { PCL__0, PCL__2, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
+    { PCL__0, PCL__2, PCL__6, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
 	PCLRSV, PCLRSV
 };
 
-- 
2.31.1

Re: [PATCH] turbostat: fix PC6 displaying on some systems

[Artem Bityutskiy]

On Mon, 2021-10-04 at 13:52 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> 'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
> and turbostat decodes it.
> 
> Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
> (ICX), treats it as "unknown", and does not display any package C-states in the
> results table.
> 
> After this patch: turbostat recognizes value 3 on ICX, treats it as "PC6", and
> correctly displays package C-states in the results table.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Hi,

any chance for this patch to be picked?

Thanks,
Artem.

Re: [PATCH] turbostat: fix PC6 displaying on some systems

[Artem Bityutskiy]

Hi, any feed-back on this patch, or a chance for it to be picked up?

Thanks!

On Mon, 2021-10-04 at 13:52 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> 'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state
> limit,
> and turbostat decodes it.
> 
> Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
> (ICX), treats it as "unknown", and does not display any package C-states in
> the
> results table.
> 
> After this patch: turbostat recognizes value 3 on ICX, treats it as "PC6", and
> correctly displays package C-states in the results table.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Re: [PATCH] turbostat: fix PC6 displaying on some systems

[Artem Bityutskiy]

On Mon, 2021-10-04 at 13:52 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> 'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
> and turbostat decodes it.
> 
> Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
> (ICX), treats it as "unknown", and does not display any package C-states in the
> results table.
> 
> After this patch: turbostat recognizes value 3 on ICX, treats it as "PC6", and
> correctly displays package C-states in the results table.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Hi Rafael,

would you please take a look at this patch and possibly apply it? Thanks!

[PATCH] turbostat: fix PC6 displaying on some systems

[me_gmail]

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
and turbostat decodes it.

Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
(ICX) and Sapphire Rapids Xeon (SPR), treats it as "unknown", and does not
display any package C-states in the results table.

After this patch: turbostat recognizes value 3 on ICX and SPR, treats it as
"PC6", and correctly displays package C-states in the results table.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 47d3ba895d6d..bc5ae0872fed 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -2323,7 +2323,7 @@ int skx_pkg_cstate_limits[16] =
 };
 
 int icx_pkg_cstate_limits[16] =
-    { PCL__0, PCL__2, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
+    { PCL__0, PCL__2, PCL__6, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
 	PCLRSV, PCLRSV
 };
 
-- 
2.31.1