From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CBC433EF for ; Mon, 4 Oct 2021 14:36:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3138361163 for ; Mon, 4 Oct 2021 14:36:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3138361163 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C8BBE940040; Mon, 4 Oct 2021 10:36:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3BA194000B; Mon, 4 Oct 2021 10:36:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADC6F940040; Mon, 4 Oct 2021 10:36:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 9F54E94000B for ; Mon, 4 Oct 2021 10:36:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5D3A8182B0485 for ; Mon, 4 Oct 2021 14:36:39 +0000 (UTC) X-FDA: 78659006118.15.7FC897C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 0DB78D037991 for ; Mon, 4 Oct 2021 14:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=EpAmadTHgh/gl19p+6/qMZi8dpvy7AwV+VtuwRVjv04=; b=emcNFiV41DTZYMOzYXkYlZEI4K oCTg6HAEgG+OGF8UL7yqFdQvEGZOjYzfOl6Wc9NKPiJjD9WEyukHV0CwX/QDOBT9XgNzJ7NRRd5N6 oTYFllRwCH4GtfX4vgG5DmELzPHNch89RDwPSY0dd6iaccV9O546NnpD+hGi/u8S4aT4d2hF1vwNr wx+XSRLqnsvbuaCqhFgN2+X0mcTbiIsmIU66btuaoou8dL+0v5CLSa8m2O2U46b1QHMX4ViisCY0N 6ZNpudcaWVk5FzpaN5VlJZHDSeeQFj7EBrXAoyPKN7C2U6VzdQwt4416vIuYnWfcf6zePkmDGI4aj rZmVTn8w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXP1h-00H0Da-86; Mon, 04 Oct 2021 14:34:04 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" Subject: [PATCH 36/62] mm/slub: Convert full slab management to struct slab Date: Mon, 4 Oct 2021 14:46:24 +0100 Message-Id: <20211004134650.4031813-37-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211004134650.4031813-1-willy@infradead.org> References: <20211004134650.4031813-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0DB78D037991 X-Stat-Signature: g16893xg3s9wa5abu9wdwffc466fsyq1 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=emcNFiV4; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1633358198-624677 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Pass struct slab to add_full() and remove_full(). Improves type safety. Signed-off-by: Matthew Wilcox (Oracle) --- mm/slub.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 6d81e54e61df..32a1bd4c8a88 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1185,22 +1185,22 @@ static void trace(struct kmem_cache *s, struct pa= ge *page, void *object, * Tracking of fully allocated slabs for debugging purposes. */ static void add_full(struct kmem_cache *s, - struct kmem_cache_node *n, struct page *page) + struct kmem_cache_node *n, struct slab *slab) { if (!(s->flags & SLAB_STORE_USER)) return; =20 lockdep_assert_held(&n->list_lock); - list_add(&page->slab_list, &n->full); + list_add(&slab->slab_list, &n->full); } =20 -static void remove_full(struct kmem_cache *s, struct kmem_cache_node *n,= struct page *page) +static void remove_full(struct kmem_cache *s, struct kmem_cache_node *n,= struct slab *slab) { if (!(s->flags & SLAB_STORE_USER)) return; =20 lockdep_assert_held(&n->list_lock); - list_del(&page->slab_list); + list_del(&slab->slab_list); } =20 /* Tracking of the number of slabs for debugging purposes */ @@ -1616,9 +1616,9 @@ static inline int slab_pad_check(struct kmem_cache = *s, struct page *page) static inline int check_object(struct kmem_cache *s, struct page *page, void *object, u8 val) { return 1; } static inline void add_full(struct kmem_cache *s, struct kmem_cache_node= *n, - struct page *page) {} + struct slab *slab) {} static inline void remove_full(struct kmem_cache *s, struct kmem_cache_n= ode *n, - struct page *page) {} + struct slab *slab) {} slab_flags_t kmem_cache_flags(unsigned int object_size, slab_flags_t flags, const char *name) { @@ -2402,12 +2402,12 @@ static void deactivate_slab(struct kmem_cache *s,= struct slab *slab, if (l =3D=3D M_PARTIAL) remove_partial(n, slab); else if (l =3D=3D M_FULL) - remove_full(s, n, slab_page(slab)); + remove_full(s, n, slab); =20 if (m =3D=3D M_PARTIAL) add_partial(n, slab, tail); else if (m =3D=3D M_FULL) - add_full(s, n, slab_page(slab)); + add_full(s, n, slab); } =20 l =3D m; @@ -3361,7 +3361,7 @@ static void __slab_free(struct kmem_cache *s, struc= t slab *slab, * then add it. */ if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) { - remove_full(s, n, slab_page(slab)); + remove_full(s, n, slab); add_partial(n, slab, DEACTIVATE_TO_TAIL); stat(s, FREE_ADD_PARTIAL); } @@ -3377,7 +3377,7 @@ static void __slab_free(struct kmem_cache *s, struc= t slab *slab, stat(s, FREE_REMOVE_PARTIAL); } else { /* Slab must be on the full list */ - remove_full(s, n, slab_page(slab)); + remove_full(s, n, slab); } =20 spin_unlock_irqrestore(&n->list_lock, flags); --=20 2.32.0