All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Burton <ross.burton@arm.com>
To: meta-arm@lists.yoctoproject.org
Subject: [PATCH 4/8] arm/hafnium: clean up install
Date: Mon,  4 Oct 2021 20:56:08 +0100	[thread overview]
Message-ID: <20211004195612.188487-4-ross.burton@arm.com> (raw)
In-Reply-To: <20211004195612.188487-1-ross.burton@arm.com>

Hafnium hard-codes a lot of this logic, so do_install can be simplified.

Change-Id: If4f941dff392a6e8d0b7ee9fff68a9836a7fd806
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-arm/recipes-bsp/hafnium/hafnium_2.5.bb | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/meta-arm/recipes-bsp/hafnium/hafnium_2.5.bb b/meta-arm/recipes-bsp/hafnium/hafnium_2.5.bb
index 8b4184b5..bacf684d 100644
--- a/meta-arm/recipes-bsp/hafnium/hafnium_2.5.bb
+++ b/meta-arm/recipes-bsp/hafnium/hafnium_2.5.bb
@@ -43,25 +43,7 @@ do_install() {
     cd ${B}/${HAFNIUM_PLATFORM}_clang
     install -d -m 755 ${D}/firmware
     for bldfile in ${HAFNIUM_INSTALL_TARGET}; do
-        processed="0"
-        if [ -f $bldfile.bin ]; then
-            echo "Install $bldfile.bin"
-            install -m 0755 $bldfile.bin \
-                ${D}/firmware/$bldfile-${HAFNIUM_PLATFORM}.bin
-            ln -sf $bldfile-${HAFNIUM_PLATFORM}.bin ${D}/firmware/$bldfile.bin
-            processed="1"
-        fi
-        if [ -f $bldfile.elf ]; then
-            echo "Install $bldfile.elf"
-            install -m 0755 $bldfile.elf \
-                ${D}/firmware/$bldfile-${HAFNIUM_PLATFORM}.elf
-            ln -sf $bldfile-${HAFNIUM_PLATFORM}.elf ${D}/firmware/$bldfile.elf
-            processed="1"
-        fi
-        if [ "$processed" = "0" ]; then
-            bberror "Unsupported HAFNIUM_INSTALL_TARGET target $bldfile"
-            exit 1
-        fi
+        install -m 0755 $bldfile.bin $bldfile.elf ${D}/firmware/
     done
 }
 
-- 
2.25.1



  parent reply	other threads:[~2021-10-04 19:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 19:56 [PATCH 1/8] arm/hafnium: add missing pkg-config dependency Ross Burton
2021-10-04 19:56 ` [PATCH 2/8] arm/hafnium: remove python symlink workaround Ross Burton
2021-10-04 19:56 ` [PATCH 3/8] arm/hafnium: do out-of-tree builds Ross Burton
2021-10-04 19:56 ` Ross Burton [this message]
2021-10-04 19:56 ` [PATCH 5/8] arm/hafnium: package the ELF in hafnium-dbg Ross Burton
2021-10-04 19:56 ` [PATCH 6/8] arm: add recipe for gn Ross Burton
2021-10-04 19:56 ` [PATCH 7/8] arm/hafnium: use our gn/ninja/dtc Ross Burton
2021-10-04 19:56 ` [PATCH 8/8] CI: build a proper TC0 image on x86-64 Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004195612.188487-4-ross.burton@arm.com \
    --to=ross.burton@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.