* [PATCH] leds: LP50XX should select REGMAP_I2C
@ 2021-10-04 23:20 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2021-10-04 23:20 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Jacek Anaszewski, Dan Murphy, Pavel Machek, linux-leds
REGMAP_I2C is not a user visible kconfig symbol so driver configs
should not "depend on" it. They should depend on I2C and then
select REGMAP_I2C.
If this worked, it was only because some other driver had set/enabled
REGMAP_I2C.
Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org
---
drivers/leds/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- lnx-515-rc4.orig/drivers/leds/Kconfig
+++ lnx-515-rc4/drivers/leds/Kconfig
@@ -370,7 +370,8 @@ config LEDS_LP3952
config LEDS_LP50XX
tristate "LED Support for TI LP5036/30/24/18/12/09 LED driver chip"
- depends on LEDS_CLASS && REGMAP_I2C
+ depends on LEDS_CLASS && I2C
+ select REGMAP_I2C
depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
help
If you say yes here you get support for the Texas Instruments
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-04 23:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 23:20 [PATCH] leds: LP50XX should select REGMAP_I2C Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.