All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Jeevan B" <jeevan.b@intel.com>,
	"Swati Sharma" <swati2.sharma@intel.com>,
	"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/kms_psr2_su: Skip test when necessary
Date: Mon,  4 Oct 2021 17:01:45 -0700	[thread overview]
Message-ID: <20211005000145.311228-2-jose.souza@intel.com> (raw)
In-Reply-To: <20211005000145.311228-1-jose.souza@intel.com>

The whole test needs to skip in display 13 platforms as
PSR2_SU_STATUS is not being updated anymore by HW.
It was not reliable in older display versions and now it is 100% dead.

For display 12 and newer platforms now we have PSR2 selective fetch
enabled default, so software is doing all the tracking of the areas
that needs updates but we still can't do that for frontbuffer
rendering so we are doing full frame fetches for now what will cause
this test to fail, so also skipping it for the frontbuffer subtest.

Cc: Jeevan B <jeevan.b@intel.com>
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/i915/kms_psr2_su.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
index 318deefdf..3018bcc6c 100644
--- a/tests/i915/kms_psr2_su.c
+++ b/tests/i915/kms_psr2_su.c
@@ -251,6 +251,9 @@ igt_main
 					       data.debugfs_fd, PSR_MODE_2),
 			      "Sink does not support PSR2\n");
 
+		igt_require_f(intel_display_ver(intel_get_drm_devid(data.drm_fd)) < 13,
+			      "Registers used by this test do not work on display 13\n");
+
 		display_init(&data);
 
 		/* Test if PSR2 can be enabled */
@@ -280,6 +283,21 @@ igt_main
 	for (data.op = PAGE_FLIP; data.op < LAST; data.op++) {
 		igt_describe("Test that selective update works when screen changes");
 		igt_subtest_f("%s", op_str(data.op)) {
+
+			if (data.op == FRONTBUFFER &&
+			    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
+				/*
+				 * FIXME: Display 12+ platforms now have PSR2
+				 * selective fetch enabled by default but we
+				 * still can't properly handle frontbuffer
+				 * rendering, so right it does full frame
+				 * fetches at every frontbuffer rendering.
+				 * So it is expected that this test will fail
+				 * in display 12+ platform fow now.
+				 */
+				igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n");
+			}
+
 			prepare(&data);
 			run(&data);
 			cleanup(&data);
-- 
2.33.0

  reply	other threads:[~2021-10-04 23:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  0:01 [igt-dev] [PATCH i-g-t 1/2] Revert "tests/kms_psr: Skip h/w tracking PSR2 tests for ADL-P" José Roberto de Souza
2021-10-05  0:01 ` José Roberto de Souza [this message]
2021-10-06  8:56   ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_psr2_su: Skip test when necessary Gwan-gyeong Mun
2021-10-05  0:49 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Revert "tests/kms_psr: Skip h/w tracking PSR2 tests for ADL-P" Patchwork
2021-10-05  1:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-10-06  8:53 ` [igt-dev] [PATCH i-g-t 1/2] " Gwan-gyeong Mun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005000145.311228-2-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.