All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	Douglas Gilbert <dgilbert@interlog.com>
Cc: Song Liu <songliubraving@fb.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	David Rientjes <rientjes@google.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@suse.cz>, Rik van Riel <riel@surriel.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v3 17/66] mm: Use maple tree operations for find_vma_intersection() and find_vma()
Date: Tue, 5 Oct 2021 01:30:38 +0000	[thread overview]
Message-ID: <20211005012959.1110504-18-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20211005012959.1110504-1-Liam.Howlett@oracle.com>

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Move find_vma_intersection() to mmap.c and change implementation to
maple tree.

When searching for a vma within a range, it is easier to use the maple
tree interface.  This means the find_vma() call changes to a special
case of the find_vma_intersection().

Exported for kvm module.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 include/linux/mm.h | 25 ++++++-------------------
 mm/mmap.c          | 38 ++++++++++++++++++++++++++++----------
 2 files changed, 34 insertions(+), 29 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 10a997fb60dc..21f2f6dbea64 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2679,26 +2679,13 @@ extern struct vm_area_struct * find_vma(struct mm_struct * mm, unsigned long add
 extern struct vm_area_struct * find_vma_prev(struct mm_struct * mm, unsigned long addr,
 					     struct vm_area_struct **pprev);
 
-/**
- * find_vma_intersection() - Look up the first VMA which intersects the interval
- * @mm: The process address space.
- * @start_addr: The inclusive start user address.
- * @end_addr: The exclusive end user address.
- *
- * Returns: The first VMA within the provided range, %NULL otherwise.  Assumes
- * start_addr < end_addr.
+/*
+ * Look up the first VMA which intersects the interval [start_addr, end_addr)
+ * NULL if none.  Assume start_addr < end_addr.
  */
-static inline
-struct vm_area_struct *find_vma_intersection(struct mm_struct *mm,
-					     unsigned long start_addr,
-					     unsigned long end_addr)
-{
-	struct vm_area_struct *vma = find_vma(mm, start_addr);
-
-	if (vma && end_addr <= vma->vm_start)
-		vma = NULL;
-	return vma;
-}
+extern struct vm_area_struct *find_vma_intersection(struct mm_struct *mm,
+						    unsigned long start_addr,
+						    unsigned long end_addr);
 
 /**
  * vma_lookup() - Find a VMA at a specific address
diff --git a/mm/mmap.c b/mm/mmap.c
index b1f7c080b9da..3b1de99d0ea0 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2027,32 +2027,50 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,
 EXPORT_SYMBOL(get_unmapped_area);
 
 /**
- * find_vma() - Find the VMA for a given address, or the next vma.
- * @mm: The mm_struct to check
- * @addr: The address
+ * find_vma_intersection() - Look up the first VMA which intersects the interval
+ * @mm: The process address space.
+ * @start_addr: The inclusive start user address.
+ * @end_addr: The exclusive end user address.
  *
- * Returns: The VMA associated with addr, or the next vma.
- * May return %NULL in the case of no vma at addr or above.
+ * Returns: The first VMA within the provided range, %NULL otherwise.  Assumes
+ * start_addr < end_addr.
  */
-struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
+struct vm_area_struct *find_vma_intersection(struct mm_struct *mm,
+					     unsigned long start_addr,
+					     unsigned long end_addr)
 {
 	struct vm_area_struct *vma;
-	MA_STATE(mas, &mm->mm_mt, addr, addr);
+	MA_STATE(mas, &mm->mm_mt, start_addr, start_addr);
 
 	mmap_assert_locked(mm);
 	/* Check the cache first. */
-	vma = vmacache_find(mm, addr);
+	vma = vmacache_find(mm, start_addr);
 	if (likely(vma))
 		return vma;
 
 	rcu_read_lock();
-	vma = mas_find(&mas, -1);
+	vma = mas_find(&mas, end_addr - 1);
 	rcu_read_unlock();
 	if (vma)
-		vmacache_update(addr, vma);
+		vmacache_update(mas.index, vma);
 
 	return vma;
 }
+EXPORT_SYMBOL(find_vma_intersection);
+
+/**
+ * find_vma() - Find the VMA for a given address, or the next vma.
+ * @mm:  The mm_struct to check
+ * @addr: The address
+ *
+ * Returns: The VMA associated with addr, or the next vma.
+ * May return NULL in the case of no vma at addr or above.
+ */
+inline struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
+{
+	// Note find_vma_intersection will decrease 0 to underflow to ULONG_MAX
+	return find_vma_intersection(mm, addr, 0);
+}
 EXPORT_SYMBOL(find_vma);
 
 /**
-- 
2.30.2

  parent reply	other threads:[~2021-10-05  1:35 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  1:30 [PATCH v3 00/66] Introducing the Maple Tree Liam Howlett
2021-10-05  1:30 ` [PATCH v3 01/66] radix tree test suite: Add pr_err define Liam Howlett
2021-10-05  1:30 ` [PATCH v3 02/66] radix tree test suite: Add kmem_cache_set_non_kernel() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 04/66] radix tree test suite: Add support for slab bulk APIs Liam Howlett
2021-10-05  1:30 ` [PATCH v3 03/66] radix tree test suite: Add allocation counts and size to kmem_cache Liam Howlett
2021-10-05  1:30 ` [PATCH v3 05/66] Maple Tree: Add new data structure Liam Howlett
2021-10-05  1:30 ` [PATCH v3 06/66] mm: Start tracking VMAs with maple tree Liam Howlett
2021-10-05  1:30 ` [PATCH v3 07/66] mm/mmap: Use the maple tree in find_vma() instead of the rbtree Liam Howlett
2021-10-05  1:30 ` [PATCH v3 08/66] mm/mmap: Use the maple tree for find_vma_prev() " Liam Howlett
2021-10-05  1:30 ` [PATCH v3 09/66] mm/mmap: Use maple tree for unmapped_area{_topdown} Liam Howlett
2021-10-05  1:30 ` [PATCH v3 10/66] kernel/fork: Use maple tree for dup_mmap() during forking Liam Howlett
2021-10-05  1:30 ` [PATCH v3 11/66] mm: Remove rb tree Liam Howlett
2021-10-05  1:30 ` [PATCH v3 14/66] mm: Optimize find_exact_vma() to use vma_lookup() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 12/66] mmap: Change zeroing of maple tree in __vma_adjust Liam Howlett
2021-10-05  1:30 ` [PATCH v3 13/66] xen/privcmd: Optimized privcmd_ioctl_mmap() by using vma_lookup() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 16/66] mm/mmap: Change do_brk_flags() to expand existing VMA and add do_brk_munmap() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 15/66] mm/khugepaged: Optimize collapse_pte_mapped_thp() by using vma_lookup() Liam Howlett
2021-10-05  1:30 ` Liam Howlett [this message]
2021-10-05  1:30 ` [PATCH v3 18/66] mm/mmap: Use advanced maple tree API for mmap_region() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 19/66] mm: Remove vmacache Liam Howlett
2021-10-05  1:30 ` [PATCH v3 20/66] mm/mmap: Move mmap_region() below do_munmap() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 21/66] mm/mmap: Convert count_vma_pages_range() to use ma_state Liam Howlett
2021-10-05  1:30 ` [PATCH v3 22/66] mm/mmap: Reorganize munmap to use maple states Liam Howlett
2021-10-05  1:30 ` [PATCH v3 24/66] mm: Introduce vma_next() and vma_prev() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 23/66] mm/mmap: Change do_brk_munmap() to use do_mas_align_munmap() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 25/66] arch/arm64: Remove mmap linked list from vdso Liam Howlett
2021-10-05  1:30 ` [PATCH v3 26/66] arch/parisc: Remove mmap linked list from kernel/cache Liam Howlett
2021-10-05  1:30 ` [PATCH v3 27/66] arch/powerpc: Remove mmap linked list from mm/book3s32/tlb Liam Howlett
2021-10-05  1:30 ` [PATCH v3 28/66] arch/powerpc: Remove mmap linked list from mm/book3s64/subpage_prot Liam Howlett
2021-10-05  1:30 ` [PATCH v3 29/66] arch/s390: Use maple tree iterators instead of linked list Liam Howlett
2021-10-05  1:30 ` [PATCH v3 31/66] arch/xtensa: Use maple tree iterators for unmapped area Liam Howlett
2021-10-05  1:30 ` [PATCH v3 30/66] arch/x86: Use maple tree iterators for vdso/vma Liam Howlett
2021-10-05  1:30 ` [PATCH v3 34/66] fs/binfmt_elf: Use maple tree iterators for fill_files_note() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 32/66] drivers/misc/cxl: Use maple tree iterators for cxl_prefault_vma() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 33/66] drivers/tee/optee: Use maple tree iterators for __check_mem_type() Liam Howlett
2021-10-05  1:30 ` [PATCH v3 35/66] fs/coredump: Use maple tree iterators in place of linked list Liam Howlett
2021-10-05  1:30 ` [PATCH v3 36/66] fs/exec: Use vma_next() instead " Liam Howlett
2021-10-05  1:30 ` [PATCH v3 37/66] fs/proc/base: Use maple tree iterators in place " Liam Howlett
2021-10-05  1:30 ` [PATCH v3 38/66] fs/proc/task_mmu: Stop using linked list and highest_vm_end Liam Howlett
2021-10-05  1:30 ` [PATCH v3 39/66] fs/userfaultfd: Stop using vma linked list Liam Howlett
2021-10-05  1:30 ` [PATCH v3 40/66] ipc/shm: Stop using the " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 41/66] kernel/acct: Use maple tree iterators instead of " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 43/66] kernel/events/uprobes: " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 42/66] kernel/events/core: " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 46/66] arch/um/kernel/tlb: Stop using " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 44/66] kernel/sched/fair: Use maple tree iterators instead of " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 45/66] kernel/fork: " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 47/66] bpf: Remove VMA " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 48/66] mm/gup: Use maple tree navigation instead of " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 51/66] mm/madvise: Use vma_next instead of vma " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 49/66] mm/khugepaged: Use maple tree iterators " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 50/66] mm/ksm: " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 52/66] mm/memcontrol: Stop using mm->highest_vm_end Liam Howlett
2021-10-05  1:31 ` [PATCH v3 53/66] mm/mempolicy: Use maple tree iterators instead of vma linked list Liam Howlett
2021-10-05  1:31 ` [PATCH v3 54/66] mm/mlock: " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 56/66] mm/mremap: Use vma_next() " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 55/66] mm/mprotect: Use maple tree navigation " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 57/66] mm/msync: Use vma_next() " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 58/66] mm/oom_kill: Use maple tree iterators " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 59/66] mm/pagewalk: Use vma_next() " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 61/66] damon: Change vma iterator to mas_for_each Liam Howlett
2021-10-05  1:31 ` [PATCH v3 60/66] mm/swapfile: Use maple tree iterator instead of vma linked list Liam Howlett
2021-10-05  1:31 ` [PATCH v3 63/66] s390: Use the maple tree iterator for vdso Liam Howlett
2021-10-05  1:31 ` [PATCH v3 62/66] powerpc: Use " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 64/66] i915: Use the " Liam Howlett
2021-10-05  1:31 ` [PATCH v3 65/66] mm: Remove the vma linked list Liam Howlett
2021-10-05  1:31 ` [PATCH v3 66/66] mm/mmap: Drop range_has_overlap() function Liam Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005012959.1110504-18-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=dgilbert@interlog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=rientjes@google.com \
    --cc=songliubraving@fb.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.