From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 0/5] btrfs-progs: use direct-IO for zoned device
Date: Tue, 5 Oct 2021 06:11:18 +0000 [thread overview]
Message-ID: <20211005061117.evmfdzr6z3g5zzdx@naota-xeon> (raw)
In-Reply-To: <20210929102223.GM9286@twin.jikos.cz>
On Wed, Sep 29, 2021 at 12:22:23PM +0200, David Sterba wrote:
> On Wed, Sep 29, 2021 at 02:24:22AM +0000, Naohiro Aota wrote:
> > On Mon, Sep 27, 2021 at 11:51:39PM +0200, David Sterba wrote:
> > > On Mon, Sep 27, 2021 at 01:15:49PM +0900, Naohiro Aota wrote:
> > > I was doing some btrfs-convert changes and found that it crashed, rough
> > > bisection points to this series. With the last patch applied, convert
> > > fails with the following ASAN error:
> >
> > It looks like eb->fs_info == NULL at this point. In case of
> > btrfs-convert, we can assume it is non-zoned because we do not support
> > the converting on a zoned device (we can't create ext*, reiserfs on a
> > zoned device anyway).
>
> That would mean that extN/reiserfs was created on a zoned device. One
> can still do a image copy to a zoned device and then convert. Even if
> this is possible in theory I'd rather not allow that right now because
> there are probably more changes required to do full support.
>
> I've just noticed that ZONED bit is mistakenly among the feature flag
> bits allowed in convert. Added in 242c8328bcd55175 "btrfs-progs: zoned:
> add new ZONED feature flag":
>
> BTRFS_CONVERT_ALLOWED_FEATURES must not contain
> BTRFS_FEATURE_INCOMPAT_ZONED.
Oops, I thought I did not list BTRFS_FEATURE_INCOMPAT_ZONED in the
ALLOWED_FEATURES list. I'll fix it in the new series.
prev parent reply other threads:[~2021-10-05 6:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 4:15 [PATCH 0/5] btrfs-progs: use direct-IO for zoned device Naohiro Aota
2021-09-27 4:15 ` [PATCH 1/5] btrfs-progs: mkfs: do not set zone size on non-zoned mode Naohiro Aota
2021-09-27 9:19 ` Johannes Thumshirn
2021-09-27 4:15 ` [PATCH 2/5] btrfs-progs: introduce btrfs_pwrite wrapper for pwrite Naohiro Aota
2021-09-27 9:39 ` Johannes Thumshirn
2021-09-27 4:15 ` [PATCH 3/5] btrfs-progs: introduce btrfs_pread wrapper for pread Naohiro Aota
2021-09-27 10:23 ` Johannes Thumshirn
2021-09-27 18:41 ` David Sterba
2021-09-27 4:15 ` [PATCH 4/5] btrfs-progs: temporally set zoned flag for initial tree reading Naohiro Aota
2021-09-27 12:38 ` Johannes Thumshirn
2021-09-27 4:15 ` [PATCH 5/5] btrfs-progs: use direct-IO for zoned device Naohiro Aota
2021-09-27 18:48 ` David Sterba
2021-09-27 19:26 ` [PATCH 0/5] " David Sterba
2021-09-29 2:21 ` Naohiro Aota
2021-09-29 10:16 ` David Sterba
2021-09-27 21:51 ` David Sterba
2021-09-29 2:24 ` Naohiro Aota
2021-09-29 10:22 ` David Sterba
2021-10-05 6:11 ` Naohiro Aota [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005061117.evmfdzr6z3g5zzdx@naota-xeon \
--to=naohiro.aota@wdc.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.