From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102C4C433EF for ; Tue, 5 Oct 2021 06:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE32E613AC for ; Tue, 5 Oct 2021 06:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbhJEGvc (ORCPT ); Tue, 5 Oct 2021 02:51:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:36224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbhJEGvb (ORCPT ); Tue, 5 Oct 2021 02:51:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1683A6137F; Tue, 5 Oct 2021 06:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633416581; bh=am9djVxIkg8W2+HaNT26dMc7/VJKG3pWaAhj9MsVOpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AIxfWutvh/k+OJhI4qaIiphhYrti7ug+t70bHe+cjhOQc+VsrOwXRrXEmmTu5vbXo zS1vDvR31vtFkkCzoiqHljJ4q75CaSFMWg/gTOuCsWiWGMUdxgonnMoTGRxjsxHLOP 4u3WlT9U0saEapGe8VW76AtagEi6ZlO1Nv1I5yVerEPFoyOboXoV9hdRIJ59aKLuY0 Za8gF2OL3A0unIbGK7gGUwx7ywf0VUxrBlLPdBqtPHbwGG/ttWbWcTKutPKX8zgj++ ARWFf+9TUT5/uyOE8eJ0lYEwDd5HZqmk7gWHoAQQcHTLGA+/YbpbqQ+20OVsm/UEHW 1yDnZWF7TouTQ== Date: Tue, 5 Oct 2021 14:49:35 +0800 From: Shawn Guo To: Frieder Schrempf Cc: Frieder Schrempf , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Message-ID: <20211005064934.GY20743@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-3-frieder@fris.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 06:02:01PM +0200, Frieder Schrempf wrote: > On 30.09.21 17:56, Frieder Schrempf wrote: > > From: Frieder Schrempf > > > > VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM > > should be 950 mV for DDR clock frequencies of 1.5 GHz. > > > > This information is taken from the datasheet and the uboot-imx code. > > > > Signed-off-by: Frieder Schrempf > > This should also have: > > Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and > baseboards") $ git log 21c4f45b335f fatal: ambiguous argument '21c4f45b335f': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' Shawn > Cc: stable@vger.kernel.org > > > --- > > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > index 03b3516abd64..b12fb7ce6686 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > @@ -92,10 +92,12 @@ regulators { > > reg_vdd_soc: BUCK1 { > > regulator-name = "buck1"; > > regulator-min-microvolt = <800000>; > > - regulator-max-microvolt = <900000>; > > + regulator-max-microvolt = <850000>; > > regulator-boot-on; > > regulator-always-on; > > regulator-ramp-delay = <3125>; > > + nxp,dvs-run-voltage = <850000>; > > + nxp,dvs-standby-voltage = <800000>; > > }; > > > > reg_vdd_arm: BUCK2 { > > @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 { > > reg_vdd_dram: BUCK3 { > > regulator-name = "buck3"; > > regulator-min-microvolt = <850000>; > > - regulator-max-microvolt = <900000>; > > + regulator-max-microvolt = <950000>; > > regulator-boot-on; > > regulator-always-on; > > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46434C433F5 for ; Tue, 5 Oct 2021 06:51:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CC3F6137F for ; Tue, 5 Oct 2021 06:51:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CC3F6137F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N7IXjpMHWXVAB2Yl05aBgKeZKmz5TzZ1mPjsDy2oldk=; b=0Kqap72Mhaps4n 8aOgvFK7WV9HpxmA1yMf9y18X8QpzKxFKvaAkNXBH2lkM+nf0XmMVQlAXB/7vNR3zoI4lqg4LEu9g XNxgo3RG+h2AXpS8/rvDmPW6/QvbOantw7LVAw40v3CLPmvf/dcuvuXgbulu4nQyCBGlRUy73YbrN ZGMe/s1Zgf5KHZ5NBsxjy4kDcEwxdmcY3t/gOYWV0z9oZ0K1fHF+8eBG0vMmlzXJYiLSmnc85fFng ThSwPPwM7wJtF7lQQatz7Ft/QEvOlJINbQEnjuAWPzxE6XpubTRP1ikKfCLpywGQD+yIFBy0GLPqB zcgc6k117NKjGt5Ix70w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXeGm-009CES-Sg; Tue, 05 Oct 2021 06:49:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXeGj-009CDk-DE for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 06:49:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1683A6137F; Tue, 5 Oct 2021 06:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633416581; bh=am9djVxIkg8W2+HaNT26dMc7/VJKG3pWaAhj9MsVOpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AIxfWutvh/k+OJhI4qaIiphhYrti7ug+t70bHe+cjhOQc+VsrOwXRrXEmmTu5vbXo zS1vDvR31vtFkkCzoiqHljJ4q75CaSFMWg/gTOuCsWiWGMUdxgonnMoTGRxjsxHLOP 4u3WlT9U0saEapGe8VW76AtagEi6ZlO1Nv1I5yVerEPFoyOboXoV9hdRIJ59aKLuY0 Za8gF2OL3A0unIbGK7gGUwx7ywf0VUxrBlLPdBqtPHbwGG/ttWbWcTKutPKX8zgj++ ARWFf+9TUT5/uyOE8eJ0lYEwDd5HZqmk7gWHoAQQcHTLGA+/YbpbqQ+20OVsm/UEHW 1yDnZWF7TouTQ== Date: Tue, 5 Oct 2021 14:49:35 +0800 From: Shawn Guo To: Frieder Schrempf Cc: Frieder Schrempf , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Message-ID: <20211005064934.GY20743@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-3-frieder@fris.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211004_234941_492776_1318C66C X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 06:02:01PM +0200, Frieder Schrempf wrote: > On 30.09.21 17:56, Frieder Schrempf wrote: > > From: Frieder Schrempf > > > > VDD_SOC should be 800 mV in suspend and 850 mV in run mode. VDD_DRAM > > should be 950 mV for DDR clock frequencies of 1.5 GHz. > > > > This information is taken from the datasheet and the uboot-imx code. > > > > Signed-off-by: Frieder Schrempf > > This should also have: > > Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and > baseboards") $ git log 21c4f45b335f fatal: ambiguous argument '21c4f45b335f': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' Shawn > Cc: stable@vger.kernel.org > > > --- > > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > index 03b3516abd64..b12fb7ce6686 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > > @@ -92,10 +92,12 @@ regulators { > > reg_vdd_soc: BUCK1 { > > regulator-name = "buck1"; > > regulator-min-microvolt = <800000>; > > - regulator-max-microvolt = <900000>; > > + regulator-max-microvolt = <850000>; > > regulator-boot-on; > > regulator-always-on; > > regulator-ramp-delay = <3125>; > > + nxp,dvs-run-voltage = <850000>; > > + nxp,dvs-standby-voltage = <800000>; > > }; > > > > reg_vdd_arm: BUCK2 { > > @@ -111,7 +113,7 @@ reg_vdd_arm: BUCK2 { > > reg_vdd_dram: BUCK3 { > > regulator-name = "buck3"; > > regulator-min-microvolt = <850000>; > > - regulator-max-microvolt = <900000>; > > + regulator-max-microvolt = <950000>; > > regulator-boot-on; > > regulator-always-on; > > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel