From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08146C433EF for ; Tue, 5 Oct 2021 09:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E439C617E3 for ; Tue, 5 Oct 2021 09:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233426AbhJEJEZ (ORCPT ); Tue, 5 Oct 2021 05:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232884AbhJEJEY (ORCPT ); Tue, 5 Oct 2021 05:04:24 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40A99C061749 for ; Tue, 5 Oct 2021 02:02:34 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id e2-20020ad45582000000b0037e7bdc88d4so20661210qvx.2 for ; Tue, 05 Oct 2021 02:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=EKFnh/sXPfL6SyxAQSUAY6zRBxqFcb3PSl/vj5lGE5JSiKVIYXjqNkN1c3ma+yItZf Sk0o0NPthUFScy8hUZ0wwOootL0G4y2vL/YJuxg3Dtw4kvPj4ocxd0/gXRLX1ih/LGSv kJieebl7g9OC5vkrvzjJ+WIu1oy3uhPGasNwC17W2CNL4nezRMLhlsl77YmYptBherI1 RgFFqaUthvhyo277EzH+4gHTmvxLf9dWDJ31uiYuUcGjUlwSsAR0phVTLp8+gM3LfCBk kOW+OG0MAYoB5rguVBaWbIDO/tcBdGv7n83nZne3vgNNIs3aqfeDZM4jt3A7FSzg85LE AMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=FokEKW9PbFlLqfSw/qAoRIAw6yD/PuZ2QFjQA4FnerorKavI08XlhSYVy7QxYCObSd gCEWTIqC0SOQxsDppXJq2nNKznVDUhXBAiDybIFvlfXu4f4DUH9SKmox2Rd1UBHOWDmH EMoSmw2tsK8k2IPXe3kFNCy0J4qCnqLV5qDeAs1z4Bh0nYvin95HYttPtizRTeqDnLiM j/zJwCBFMC3Qcjagv1Em19kV6pzfFWiIJszpxuxtNLud1N/n6qxfDvBHDyX1RBIWAQNe kJousTraVkjDIg1ViFGerFVbj6XWRY45lzWJMA0Jws1JfE8cP3ycPETQvKka+T6AFe8f XxlQ== X-Gm-Message-State: AOAM531xipaka7T+0VhnQwme6dVZACD/AtpWMwiT6V9ReoasXI2GIvQ4 GmWm8E6zitFgMUWdufePBBl1e66E3S+v X-Google-Smtp-Source: ABdhPJwLRnkFWRvGHIY32Rqa3Eiquzx86qZPVIsgO2JHnhRBY0a0MNCuAi59I89wj4Q70Jl6kpZxagSP7sBv X-Received: from luke.lon.corp.google.com ([2a00:79e0:d:210:5700:9128:3106:b389]) (user=qperret job=sendgmr) by 2002:a05:6214:1267:: with SMTP id r7mr9710216qvv.16.1633424553449; Tue, 05 Oct 2021 02:02:33 -0700 (PDT) Date: Tue, 5 Oct 2021 10:01:39 +0100 In-Reply-To: <20211005090155.734578-1-qperret@google.com> Message-Id: <20211005090155.734578-3-qperret@google.com> Mime-Version: 1.0 References: <20211005090155.734578-1-qperret@google.com> X-Mailer: git-send-email 2.33.0.800.g4c38ced690-goog Subject: [PATCH 2/2] KVM: arm64: Report corrupted refcount at EL2 From: Quentin Perret To: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Quentin Perret , Fuad Tabba , David Brazdil , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Cc: kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some of the refcount manipulation helpers used at EL2 are instrumented to catch a corrupt state, but not all of them are treated equally. Let's make things more consistent by instrumenting hyp_page_ref_dec_and_test() as well. Suggested-by: Will Deacon Signed-off-by: Quentin Perret --- arch/arm64/kvm/hyp/nvhe/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/hyp/nvhe/page_alloc.c b/arch/arm64/kvm/hyp/nvhe/page_alloc.c index a6e874e61a40..0bd7701ad1df 100644 --- a/arch/arm64/kvm/hyp/nvhe/page_alloc.c +++ b/arch/arm64/kvm/hyp/nvhe/page_alloc.c @@ -152,6 +152,7 @@ static inline void hyp_page_ref_inc(struct hyp_page *p) static inline int hyp_page_ref_dec_and_test(struct hyp_page *p) { + BUG_ON(!p->refcount); p->refcount--; return (p->refcount == 0); } -- 2.33.0.800.g4c38ced690-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26461C433F5 for ; Tue, 5 Oct 2021 09:02:37 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B2CC8613B5 for ; Tue, 5 Oct 2021 09:02:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2CC8613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 661404B2E2; Tue, 5 Oct 2021 05:02:36 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, body has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J06VMGJtVy9i; Tue, 5 Oct 2021 05:02:35 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6CA494B2B4; Tue, 5 Oct 2021 05:02:35 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8B4ED4B2A7 for ; Tue, 5 Oct 2021 05:02:34 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ORXyR3jV2sRb for ; Tue, 5 Oct 2021 05:02:33 -0400 (EDT) Received: from mail-qv1-f73.google.com (mail-qv1-f73.google.com [209.85.219.73]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B6FF94B267 for ; Tue, 5 Oct 2021 05:02:33 -0400 (EDT) Received: by mail-qv1-f73.google.com with SMTP id hf12-20020a0562140e8c00b00382cdfe644eso7099099qvb.23 for ; Tue, 05 Oct 2021 02:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=EKFnh/sXPfL6SyxAQSUAY6zRBxqFcb3PSl/vj5lGE5JSiKVIYXjqNkN1c3ma+yItZf Sk0o0NPthUFScy8hUZ0wwOootL0G4y2vL/YJuxg3Dtw4kvPj4ocxd0/gXRLX1ih/LGSv kJieebl7g9OC5vkrvzjJ+WIu1oy3uhPGasNwC17W2CNL4nezRMLhlsl77YmYptBherI1 RgFFqaUthvhyo277EzH+4gHTmvxLf9dWDJ31uiYuUcGjUlwSsAR0phVTLp8+gM3LfCBk kOW+OG0MAYoB5rguVBaWbIDO/tcBdGv7n83nZne3vgNNIs3aqfeDZM4jt3A7FSzg85LE AMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=Wv+RtrC0PD7x7lnCqzMJBGAFNdVeZlzM+D326BnUK5HgnRrA97NrgoekwcTmWRWBoN 4odcOHo2Esi04pjfay5wM0nGbWbo/ohrWT2aLgAVEOqr9uG/cy2dxzBawolhp0O7Bqz0 x69v+JYvge9cp+23zTHrDnsnQVenht1lTsPAah9K+7XVE7QFgs3o0+yHehGRFB+L7E8k nCLlyW3M8TSing12gqcMAs9TKUNad5+iVLukuLfAM0Nc5Ngz2quX4YeXwE7ZfkeXrsbb mId/SX5BwZWeNtlaYsJwQrDZ/0hoyrSPPVPcoxQJTx4KZ3dtmMzmtGkSKXKe9Cstrus2 8GiQ== X-Gm-Message-State: AOAM530EJLCCNydNgVfmc5T0SuoXWzzo0/NxhVMY2xkHjuY9MIqkK39u PiYwXchu+x1RPsnYMqt+V9Cxvuk/qv0q X-Google-Smtp-Source: ABdhPJwLRnkFWRvGHIY32Rqa3Eiquzx86qZPVIsgO2JHnhRBY0a0MNCuAi59I89wj4Q70Jl6kpZxagSP7sBv X-Received: from luke.lon.corp.google.com ([2a00:79e0:d:210:5700:9128:3106:b389]) (user=qperret job=sendgmr) by 2002:a05:6214:1267:: with SMTP id r7mr9710216qvv.16.1633424553449; Tue, 05 Oct 2021 02:02:33 -0700 (PDT) Date: Tue, 5 Oct 2021 10:01:39 +0100 In-Reply-To: <20211005090155.734578-1-qperret@google.com> Message-Id: <20211005090155.734578-3-qperret@google.com> Mime-Version: 1.0 References: <20211005090155.734578-1-qperret@google.com> X-Mailer: git-send-email 2.33.0.800.g4c38ced690-goog Subject: [PATCH 2/2] KVM: arm64: Report corrupted refcount at EL2 From: Quentin Perret To: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Quentin Perret , Fuad Tabba , David Brazdil , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Cc: kernel-team@android.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Some of the refcount manipulation helpers used at EL2 are instrumented to catch a corrupt state, but not all of them are treated equally. Let's make things more consistent by instrumenting hyp_page_ref_dec_and_test() as well. Suggested-by: Will Deacon Signed-off-by: Quentin Perret --- arch/arm64/kvm/hyp/nvhe/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/hyp/nvhe/page_alloc.c b/arch/arm64/kvm/hyp/nvhe/page_alloc.c index a6e874e61a40..0bd7701ad1df 100644 --- a/arch/arm64/kvm/hyp/nvhe/page_alloc.c +++ b/arch/arm64/kvm/hyp/nvhe/page_alloc.c @@ -152,6 +152,7 @@ static inline void hyp_page_ref_inc(struct hyp_page *p) static inline int hyp_page_ref_dec_and_test(struct hyp_page *p) { + BUG_ON(!p->refcount); p->refcount--; return (p->refcount == 0); } -- 2.33.0.800.g4c38ced690-goog _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95386C433F5 for ; Tue, 5 Oct 2021 09:05:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63EBE61371 for ; Tue, 5 Oct 2021 09:05:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63EBE61371 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=v/SppXpXz3LZCJ4QluIJrWxMVNLV81BnuFiNDNYuwbU=; b=rQzEA9c6SjD42Icq5nztfM2sUy I7Ow0iDwloV+otejO2oIEvFc6UmDx9yOISv/a46fJHSRSFyr1WVHem+mWarPyQ4SWcuat6Vl1gNad Fc6oW9YWGWMSu9zg4BS+vb5Kt5LEWQqmGAYJYio4Yo+zuQXZfS/vqIgTt5vU1gcvOMM5ePYc89z1T Bry4CIrUd6qNkhdvglATy4nXfmB61cXqBFNOjemDTqOmrXTUD+hUZLhlnqjrk3187VsDqlpzJF6r6 MJqs13utVICoa0aZGbW5cRWJr/UjVs2NrLgEUikKRAsNm8F/l8TqCR+dK4U8RV7VADJ6OOD9M+4na XL1BD9bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXgLQ-009dPE-VJ; Tue, 05 Oct 2021 09:02:41 +0000 Received: from mail-qt1-x849.google.com ([2607:f8b0:4864:20::849]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXgLL-009dNA-Rf for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 09:02:37 +0000 Received: by mail-qt1-x849.google.com with SMTP id d9-20020ac86149000000b002a6d33107c5so22630388qtm.8 for ; Tue, 05 Oct 2021 02:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=EKFnh/sXPfL6SyxAQSUAY6zRBxqFcb3PSl/vj5lGE5JSiKVIYXjqNkN1c3ma+yItZf Sk0o0NPthUFScy8hUZ0wwOootL0G4y2vL/YJuxg3Dtw4kvPj4ocxd0/gXRLX1ih/LGSv kJieebl7g9OC5vkrvzjJ+WIu1oy3uhPGasNwC17W2CNL4nezRMLhlsl77YmYptBherI1 RgFFqaUthvhyo277EzH+4gHTmvxLf9dWDJ31uiYuUcGjUlwSsAR0phVTLp8+gM3LfCBk kOW+OG0MAYoB5rguVBaWbIDO/tcBdGv7n83nZne3vgNNIs3aqfeDZM4jt3A7FSzg85LE AMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=wkyuiZINwNBLMyCf2gjjqTHN+Go0IESaSFToIb6F4Fw=; b=h3H/PKCX56o5wOcNLHTasHDNFwDY9Lm4P9gd/rmnM3unnZ9bZgE85jk3Gnw4Uzh6Ux 6ChAz6jiy6ImaD+W/w8MPC877I9ew4cMx5crrRolk6zGmpdvteMBcGj6cPMROphQwkKR FJEeNGsJXeh5f+lo2Fp53McZzulUUGtkR/p4BVxa8jLhbCDHZNe7vq//wfBRT9qmWU5L iBC8m7KLuKuNgUdfOq4H+8MTvTQycUhFZpoZJslfKp0degynnnmUOfoWtazRX0uEga7s dpsqZWyQJZVqKDGXUZKMVIXM+hb0KLebDs0kASa3iIkBXja49BuiPt9ygbE2ufCVB2M7 RvqA== X-Gm-Message-State: AOAM531Tr6Vl/mUuUL/c2ToFWP2ppABjWAKTvS/PIJWbLAmZ++d3udBu nLBKUvUOLyeHpikw0xS7q/aIgOnIy6dX X-Google-Smtp-Source: ABdhPJwLRnkFWRvGHIY32Rqa3Eiquzx86qZPVIsgO2JHnhRBY0a0MNCuAi59I89wj4Q70Jl6kpZxagSP7sBv X-Received: from luke.lon.corp.google.com ([2a00:79e0:d:210:5700:9128:3106:b389]) (user=qperret job=sendgmr) by 2002:a05:6214:1267:: with SMTP id r7mr9710216qvv.16.1633424553449; Tue, 05 Oct 2021 02:02:33 -0700 (PDT) Date: Tue, 5 Oct 2021 10:01:39 +0100 In-Reply-To: <20211005090155.734578-1-qperret@google.com> Message-Id: <20211005090155.734578-3-qperret@google.com> Mime-Version: 1.0 References: <20211005090155.734578-1-qperret@google.com> X-Mailer: git-send-email 2.33.0.800.g4c38ced690-goog Subject: [PATCH 2/2] KVM: arm64: Report corrupted refcount at EL2 From: Quentin Perret To: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Quentin Perret , Fuad Tabba , David Brazdil , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Cc: kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_020235_923582_A9005B17 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some of the refcount manipulation helpers used at EL2 are instrumented to catch a corrupt state, but not all of them are treated equally. Let's make things more consistent by instrumenting hyp_page_ref_dec_and_test() as well. Suggested-by: Will Deacon Signed-off-by: Quentin Perret --- arch/arm64/kvm/hyp/nvhe/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kvm/hyp/nvhe/page_alloc.c b/arch/arm64/kvm/hyp/nvhe/page_alloc.c index a6e874e61a40..0bd7701ad1df 100644 --- a/arch/arm64/kvm/hyp/nvhe/page_alloc.c +++ b/arch/arm64/kvm/hyp/nvhe/page_alloc.c @@ -152,6 +152,7 @@ static inline void hyp_page_ref_inc(struct hyp_page *p) static inline int hyp_page_ref_dec_and_test(struct hyp_page *p) { + BUG_ON(!p->refcount); p->refcount--; return (p->refcount == 0); } -- 2.33.0.800.g4c38ced690-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel