All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Previn <alan.previn.teres.alexis@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [igt-dev] [PATCH i-g-t v13 13/16] Verify execbuf ok with stale PXP buf in opt-out use
Date: Tue,  5 Oct 2021 08:10:19 -0700	[thread overview]
Message-ID: <20211005151022.2161424-14-alan.previn.teres.alexis@intel.com> (raw)
In-Reply-To: <20211005151022.2161424-1-alan.previn.teres.alexis@intel.com>

Add a check to verify that reusing a stale protected
buffer in a gem_execbuff call, but using a regular (not-
protected) context will succeed after a teardown event.
Trigger the teardown via the pxp invalidation debugfs
that simulates a HW teardown IRQ.

This ensures that user space applications that choose
not to opt-in for strict PXP teardown awareness (by
using a regular context) won't suffer gem_execbuff
failures if a protected buffer was among the assets
used in any of its rendering operations.

Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/i915/gem_pxp.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tests/i915/gem_pxp.c b/tests/i915/gem_pxp.c
index 22a2e5a4..8e3bc3cf 100644
--- a/tests/i915/gem_pxp.c
+++ b/tests/i915/gem_pxp.c
@@ -829,6 +829,27 @@ static void test_pxp_stale_buf_execution(int i915)
 	free_exec_assets(i915, &data);
 }
 
+static void test_pxp_stale_buf_optout_execution(int i915)
+{
+	int ret;
+	struct simple_exec_assets data = {0};
+
+	/*
+	 * Use a normal context for testing opt-out behavior
+	 * when executing with a pxp buffer across a teardown event.
+	 */
+	prepare_exec_assets(i915, &data, false, true);
+	ret = gem_execbuf_flush_store_dw(i915, data.ibb, data.ctx, data.fencebuf);
+	igt_assert(ret == 0);
+
+	trigger_pxp_debugfs_forced_teardown(i915);
+
+	ret = gem_execbuf_flush_store_dw(i915, data.ibb, data.ctx, data.fencebuf);
+	igt_assert_f((ret == 0), "Opt-out-execution with stale pxp buffer didn't succeed\n");
+
+	free_exec_assets(i915, &data);
+}
+
 igt_main
 {
 	int i915 = -1;
@@ -922,6 +943,8 @@ igt_main
 			test_pxp_stale_ctx_execution(i915);
 		igt_subtest("verify-pxp-stale-buf-execution")
 			test_pxp_stale_buf_execution(i915);
+		igt_subtest("verify-pxp-stale-buf-optout-execution")
+			test_pxp_stale_buf_optout_execution(i915);
 	}
 
 	igt_fixture {
-- 
2.25.1

  parent reply	other threads:[~2021-10-05 15:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 15:10 [PATCH i-g-t v13 00/16] Introduce PXP Test Alan Previn
2021-10-05 15:10 ` [igt-dev] " Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 01/16] i915_drm.h sync PXP default session Alan Previn
2021-10-05 19:14   ` Rodrigo Vivi
2021-10-05 19:31     ` Teres Alexis, Alan Previn
2021-10-05 19:34       ` Vivi, Rodrigo
2021-10-06 11:51         ` Petri Latvala
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 02/16] i915_drm.h sync PXP object creation Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 03/16] Add basic PXP testing of buffer and context alloc Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 04/16] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 05/16] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 06/16] Add MI_SET_APPID instruction definition Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 07/16] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 08/16] Add subtest to copy raw source to protected dest Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 09/16] Add test where both src and dest are protected Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 10/16] Verify PXP teardown occurred through suspend-resume Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 11/16] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 12/16] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-10-05 15:10 ` Alan Previn [this message]
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 14/16] Verify execution behavior with stale PXP assets through suspend-resume Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 15/16] Verify protected surfaces are dma buffer sharable Alan Previn
2021-10-05 15:10 ` [igt-dev] [PATCH i-g-t v13 16/16] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-10-05 16:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for Introduce PXP Test (rev13) Patchwork
2021-10-05 17:22   ` Teres Alexis, Alan Previn
2021-10-06  7:32     ` Gupta, Anshuman
2021-10-06  9:50       ` Gupta, Anshuman
2021-10-05 19:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev14) Patchwork
2021-10-05 23:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005151022.2161424-14-alan.previn.teres.alexis@intel.com \
    --to=alan.previn.teres.alexis@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.