From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695E1C433EF for ; Tue, 5 Oct 2021 16:53:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C96AC61163 for ; Tue, 5 Oct 2021 16:53:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C96AC61163 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B207582054; Tue, 5 Oct 2021 18:53:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kvWf9EGC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 694FC82054; Tue, 5 Oct 2021 18:53:33 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3CF2D8291E for ; Tue, 5 Oct 2021 18:53:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id r16so19729809qtw.11 for ; Tue, 05 Oct 2021 09:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PeKHyDR/QqzqqHZ0JXAvHzaCzBazXwprWEndUpwsoBM=; b=kvWf9EGC6wM7oOsuSMMbSZVvnsha30cFFcaQuApA5UMINfPhT2ge76MpEWHIh/2QJU h/ZenPiO/5JSWBhxSAhPciidCM6jjhHafi84YltZeZw4bk53+vri+1Y9/AvE14wqoxYm gwsLmOPaSc8bfLuKHYfSRi0ZTYx/jBnzTQ6es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PeKHyDR/QqzqqHZ0JXAvHzaCzBazXwprWEndUpwsoBM=; b=4wOdGWJ6oC1UF2fg+m3lvbzXhYlklFHJ9mFWm93LXAjuPD98aUw5n5H+KHvcg/d6XQ byFIDUOY/hNPTcCf/QfjTRpCBToYGwY72PAJapWQOcFuJz/zIwfH1QTuvMOhxcrQMhJb 5iLB4O87hIOzqfOHExyruYjhceX19nFXaaXZ+IMSvuChKtoGlEHF+J31nA9ORl4ExdWL NpP+mW6oqO/il836A7SIgI7c0beZYeEUyZj4FzuAoyRwOZb4AHMmPFa9MzBsbp6eNeV3 xRVZAyJuqDgJ5J8U/jDmDk9ul0DaP+sS2ujh1wLAr1lyJYjVohx89OrOk+q8tRjidEjU c6vw== X-Gm-Message-State: AOAM532Q4d1rAUoGwU21mb2/U3ZNqM7HZdBatp5KuHy4IlVPzYnju3Bk svEb8MDqS7hyGpfqpTHG8Hiu6g== X-Google-Smtp-Source: ABdhPJxHvZoh8ugKoFTV1VkU/gsYtgKWVeTkZtPUUEpdQVm6BxEMKlttCiR7eXso59Fn6tgvNwZbNA== X-Received: by 2002:ac8:611c:: with SMTP id a28mr21237814qtm.160.1633452808833; Tue, 05 Oct 2021 09:53:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c976-e406-5df5-f01b.res6.spectrum.com. [2603:6081:7b01:cbda:c976:e406:5df5:f01b]) by smtp.gmail.com with ESMTPSA id t24sm1686662qkj.38.2021.10.05.09.53.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Oct 2021 09:53:28 -0700 (PDT) Date: Tue, 5 Oct 2021 12:53:26 -0400 From: Tom Rini To: dsankouski@gmail.com Cc: u-boot@lists.denx.de, Ramon Fried Subject: Re: [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board Message-ID: <20211005165326.GA29167@bill-the-cat> References: <20210923185732.7679-1-dsankouski@gmail.com> <20210923185732.7679-7-dsankouski@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Content-Disposition: inline In-Reply-To: <20210923185732.7679-7-dsankouski@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 23, 2021 at 09:57:32PM +0300, dsankouski@gmail.com wrote: > From: Dzmitry Sankouski >=20 > Samsung S9 SM-G9600 - Snapdragon SDM845 version of the phone, > for China \ Hong Kong markets. > Has unlockable bootloader, unlike SM-G960U (American market version), > which allows running u-boot as a chain-loaded bootloader. >=20 > Signed-off-by: Dzmitry Sankouski > Cc: Ramon Fried > Cc: Tom Rini > --- > Changes for v2: > - Create documentation file for SDM845 boards > - Add starqltechn board documentation > Changes for v3: > - fix comment in starqltechn.c A few things. Aside from needing to migrate a few symbols to Kconfig, to build on current master, we need to: > diff --git a/include/configs/starqltechn.h b/include/configs/starqltechn.h > new file mode 100644 > index 0000000000..c9736a443b > --- /dev/null > +++ b/include/configs/starqltechn.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Board configuration file for Samsung S9(SM-G9600)(starqltechn) > + * > + * (C) Copyright 2017 Jorge Ramirez-Ortiz > + */ > + > +#ifndef __CONFIGS_STARQLTECHN_H > +#define __CONFIGS_STARQLTECHN_H > + > +#include > + > +#define CONFIG_LNX_KRNL_IMG_TEXT_OFFSET_BASE CONFIG_SYS_LOAD_ADDR > +#define CONFIG_LINUX_KERNEL_IMAGE_HEADER These two symbols need to be handled via Kconfig (xenguest_arm64 gets this wrong as well, I see) as done for example on Tegra. At that point, we can delete this file entirely and just use configs/sdm845.h. --=20 Tom --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFcgwAACgkQFHw5/5Y0 tywATwv/Y4iTs2sPHzIAdqXw5GRDc/P0MhrgMIWxFioPzQnY7YrnfZrqxLvA6ES5 r/zaGMV4zEhc6NWYKEr77kYaj62VuxEchgBJV60J7ZvgcDKofvjvZPohMFVk1Ulg M7KlfeGlFiLQtSSvWhEvOd9oGlUJ/lyltRk6XfHEe0fMkdml5+c98Ppp4wLdyUUW y7BTrYBWYy77bbV+oqM/8bxRKsf1EUA9UeMxfKukVKFNa0065r2hRLhXeGCNmOgi cbSMS2oQvfmrdWXABmB0U44B7DAp6PpsDNC/XExaVdbSawbiCSorM5jb5MVD7rd2 nLJnU4kGwII+0LK6fTU/BTFPoKYWVWaBIN3z1jQgOWilV++TEBCVo3umSSHVFXIM U8v8+T1JrXDIYZ89gUcz6nQR4w3mSSdK5L8m7d/TlamBzYlhZuXrGG0brv2QWsj/ 90jlZfAnk+fIiupazr5lihiq3NrzXkiv+baKAh4VKW1ZIDF2AuXtKFJ/pSZkSHem JW7eWAKH =FLWf -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--