From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFCDC433F5 for ; Tue, 5 Oct 2021 16:53:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68DCE611C5 for ; Tue, 5 Oct 2021 16:53:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68DCE611C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5320882D7E; Tue, 5 Oct 2021 18:53:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Qi9Qr4vs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9382082D1C; Tue, 5 Oct 2021 18:53:39 +0200 (CEST) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 39B9C8291E for ; Tue, 5 Oct 2021 18:53:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72f.google.com with SMTP id 138so2192901qko.10 for ; Tue, 05 Oct 2021 09:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=boZyTUEZOnYfszRRMZC5TF1/AfP+4z4+YhSM3cK7ju8=; b=Qi9Qr4vsKy65+0FdnpMWxUS5HloRGwLeJfbpnyoohpskZLCDj6JORDmDTBdHl+hNbj tNldTE3TEQhhz8FDougl7paFJ80ILAuVUhLL3q8/P5bOcOqYOCdAJIFrrEwCM/oK9Qjo p2PENl32gVNtnjhGfDmMr5kwjcULTYsQ2Zyz4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=boZyTUEZOnYfszRRMZC5TF1/AfP+4z4+YhSM3cK7ju8=; b=kdES5mx1kdtjH+W0cgx0pMfpsBgqit9a+UJNKHuXrocgh+uQ/duXp5KKPhCdEkH1Ws A5LYsv8qd7KkHkBfQ8auT080nAAlE7v6RdrwlPDOKgf78M5AnFxaXYw0Bv235danN7IT o1bpcfMJ+XcWQGc70xLU9VTfikNiXgHvDtjuppr0CAiFoE0umiON7mKvYzIYNYEeP+aN OA/JjWLJPOZ+p4uBzpicdQMSN9edWuIZ1T+BEv5GmSOZQqI9dL4VkPjTnLuMNtlnQ1Ol JSkvFA81ebGHqnHRRp8NCe472nesKBu1LHky/XXhrE2L7azGXfQ4Mr5ZKoG/kZgQqmnv hqFA== X-Gm-Message-State: AOAM532GO6ijgluSLFDcH/DWQvwgpL50U6SC+VJ2TqSrizyZX8526HwF 4MBedvN/MVPZpLySvOb8C3N3ygYQLpFfiA== X-Google-Smtp-Source: ABdhPJy8q+2IL6Zfd+I04q8of3INZnyuebrwBQ1hR6GezbVXHM6RjOsxkO1USGQY5iUch9FLWaN5Sw== X-Received: by 2002:a37:afc4:: with SMTP id y187mr15606021qke.520.1633452813853; Tue, 05 Oct 2021 09:53:33 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c976-e406-5df5-f01b.res6.spectrum.com. [2603:6081:7b01:cbda:c976:e406:5df5:f01b]) by smtp.gmail.com with ESMTPSA id l28sm10870426qtn.1.2021.10.05.09.53.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Oct 2021 09:53:33 -0700 (PDT) Date: Tue, 5 Oct 2021 12:53:31 -0400 From: Tom Rini To: dsankouski@gmail.com Cc: u-boot@lists.denx.de, Ramon Fried Subject: Re: [PATCH 2/6 v3] spmi: msm: add arbiter version 5 support Message-ID: <20211005165331.GB29167@bill-the-cat> References: <20210923185732.7679-1-dsankouski@gmail.com> <20210923185732.7679-3-dsankouski@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="St7VIuEGZ6dlpu13" Content-Disposition: inline In-Reply-To: <20210923185732.7679-3-dsankouski@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --St7VIuEGZ6dlpu13 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 23, 2021 at 09:57:28PM +0300, dsankouski@gmail.com wrote: > From: Dzmitry Sankouski >=20 > Currently driver supports only version 1 and 2. > Version 5 has slightly different registers structure >=20 > Signed-off-by: Dzmitry Sankouski > Cc: Ramon Fried > Cc: Tom Rini When building for the new platform, we get warnings such as: In file included from /home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.= c:16: /home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.c: In function 'msm_sp= mi_probe': /home/trini/work/u-boot/u-boot/arch/arm/include/asm/io.h:45:43: warning: ca= st to pointer from integer of different size [-Wint-to-pointer-cast] 45 | #define __arch_getl(a) (*(volatile unsigned int *)= (a)) | ^ /home/trini/work/u-boot/u-boot/arch/arm/include/asm/io.h:127:38: note: in e= xpansion of macro '__arch_getl' 127 | #define readl(c) ({ u32 __v =3D __arch_getl(c); __iormb(); _= _v; }) | ^~~~~~~~~~~ /home/trini/work/u-boot/u-boot/drivers/spmi/spmi-msm.c:202:18: note: in exp= ansion of macro 'readl' 202 | hw_ver =3D readl(config_addr + PMIC_ARB_VERSION); | ^~~~~ /home/trini/work/u-boot/u-boot/drivers/serial/serial_msm_geni.c: In functio= n 'qcom_geni_serial_poll_bit': /home/trini/work/u-boot/u-boot/drivers/serial/serial_msm_geni.c:290:17: war= ning: implicit declaration of function 'udelay' [-Wimplicit-function-declar= ation] 290 | udelay(10); | ^~~~~~ Please fix, thanks. --=20 Tom --St7VIuEGZ6dlpu13 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFcgwsACgkQFHw5/5Y0 tywdvwv9GNThlUp1wwuw4ZJ/+EqcCez7Y73pDHkwza+oN2vCLylh1cuyVagByvDH O4mKYu/eO1FmNP8/cimkpetLHxmcYkCBLoDPguHBXd4rb7vGUCdV5mXxdPrFzsD2 e71Fmwygh3N/HSBm3ETJsagysxL8327wWWQYSsfIOhdhHu0jL8n7rxL1hVHuRbNd ayCSv3980mk1oqQuYtP7LJ8yl0X1+t63iVN/748Z0vuZ1WFyOHpn+Pn7FOY1WfPz sdVjUjKD9eI+diQnbq+Zb4FxPqXEcF6lvQKy8tPqsfey+Oq0qTVapL8jfb1vWHmg ayjMAabtWxBClcTJZja7JPoPYukbMSET9+cNeVa/yTZv6EMT81cqW7x3uzX72rTU UiyGLvWlaZ2j6Jw4k8Y2uBusBdBp6r4KmekdFFFqK4SVrUXImDDGl7Rv3UOe4pi4 P6jfGRkeNLBk/0vpXVTjl+u8gAgLddk51LaBPkIqMnjsrGUcyK8Zg7hgJeWlixt9 c8qPyXk5 =eszN -----END PGP SIGNATURE----- --St7VIuEGZ6dlpu13--