From: Mauro Carvalho Chehab <firstname.lastname@example.org> To: "Pali Rohár" <email@example.com> Cc: "Bjorn Helgaas" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, "Krzysztof Wilczyński" <email@example.com>, "Binghui Wang" <firstname.lastname@example.org>, "Lorenzo Pieralisi" <email@example.com>, "Rob Herring" <firstname.lastname@example.org>, "Xiaowei Song" <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v12 03/11] PCI: kirin: Add support for a PHY layer Date: Wed, 6 Oct 2021 00:33:25 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20211005203148.gn2f34pfvm62w6ca@pali> Hi Pali, Em Tue, 5 Oct 2021 22:31:48 +0200 Pali Rohár <email@example.com> escreveu: > Hello! > > On Tuesday 28 September 2021 09:34:13 Mauro Carvalho Chehab wrote: > > The pcie-kirin driver contains both PHY and generic PCI driver > > on it. > > > > The best would be, instead, to support a PCI PHY driver, making > > the driver more generic. > > > > However, it is too late to remove the Kirin 960 PHY, as a change > > like that would make the DT schema incompatible with past versions. > > I have not looked deeply at it. But is not it really possible to declare > PHY node in DTS file with backward compatible manner? Or cannot Rob help > with it (maybe there was similar issue in past with other driver)? It would be possible to split the Kirin 960 PHY into drivers/phy. It is also possible to hack the phy driver to search for the PHY-specific data inside the PCI compatible string (I did wrote some patches doing that and sent as a RFC several months ago), but the problem is that the PHY driver won't be probed without adding a new compatible inside the DT schema. By doing that, the schema will be incompatible. In any case, the patches on this series split all PHY-specific code inside the driver on a separate part of the source code. Moving it to a new driver would be easy once someone comes with a solution to add some new method at the PHY layer that would allow to load a new module without having a compatible for it. > I was fixing something similar, address space defined in DTS was used by > two HW blocks: clock and UART. And I was able to make both DTS file and > driver backward compatible. Thanks, Mauro
next prev parent reply other threads:[~2021-10-05 22:33 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-28 7:34 [PATCH v12 00/11] Add support for Hikey 970 PCIe Mauro Carvalho Chehab 2021-09-28 7:34 ` Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 01/11] phy: HiSilicon: Add driver for Kirin 970 PCIe PHY Mauro Carvalho Chehab 2021-09-28 7:34 ` Mauro Carvalho Chehab 2021-10-01 8:12 ` Vinod Koul 2021-10-01 8:12 ` Vinod Koul 2021-09-28 7:34 ` [PATCH v12 02/11] PCI: kirin: Reorganize the PHY logic inside the driver Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 03/11] PCI: kirin: Add support for a PHY layer Mauro Carvalho Chehab 2021-10-05 20:31 ` Pali Rohár 2021-10-05 22:33 ` Mauro Carvalho Chehab [this message] 2021-09-28 7:34 ` [PATCH v12 04/11] PCI: kirin: Use regmap for APB registers Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 05/11] PCI: kirin: Add support for bridge slot DT schema Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 06/11] PCI: kirin: Add Kirin 970 compatible Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 07/11] PCI: kirin: Add MODULE_* macros Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 08/11] PCI: kirin: Allow building it as a module Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 09/11] PCI: kirin: Add power_off support for Kirin 960 PHY Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 10/11] PCI: kirin: fix poweroff sequence Mauro Carvalho Chehab 2021-09-28 7:34 ` [PATCH v12 11/11] PCI: kirin: Allow removing the driver Mauro Carvalho Chehab 2021-10-05 9:24 ` [PATCH v12 00/11] Add support for Hikey 970 PCIe Mauro Carvalho Chehab 2021-10-05 9:24 ` Mauro Carvalho Chehab 2021-10-05 18:23 ` Bjorn Helgaas 2021-10-05 18:23 ` Bjorn Helgaas 2021-10-07 14:41 ` Lorenzo Pieralisi 2021-10-07 14:41 ` Lorenzo Pieralisi 2021-10-08 10:55 ` Mauro Carvalho Chehab 2021-10-08 10:55 ` Mauro Carvalho Chehab 2021-10-08 17:34 ` Lorenzo Pieralisi 2021-10-08 17:34 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v12 03/11] PCI: kirin: Add support for a PHY layer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.