All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: "Marek Behún" <kabel@kernel.org>, sashal@kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, pali@kernel.org
Subject: Re: [PATCH v2 07/13] PCI: aardvark: Do not unmask unused interrupts
Date: Wed, 6 Oct 2021 10:13:38 +0100	[thread overview]
Message-ID: <20211006091337.GA9287@lpieralisi> (raw)
In-Reply-To: <20211005180952.6812-8-kabel@kernel.org>

[CC Sasha for stable kernel rules]

On Tue, Oct 05, 2021 at 08:09:46PM +0200, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
> 
> There are lot of undocumented interrupt bits. Fix all *_ALL_MASK macros to
> define all interrupt bits, so that driver can properly mask all interrupts,
> including those which are undocumented.
> 
> Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Cc: stable@vger.kernel.org

I don't think this is a fix and I don't think it should be sent
to stable kernels in _preparation_ for other fixes to come (that
may never land in mainline).

If, for future fixes a depedency is detected they can be added
in the relevant commit log.

That's my understanding, Sasha can clarify if needed.

Patch itself is fine.

Thanks,
Lorenzo

> ---
>  drivers/pci/controller/pci-aardvark.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
> index f7eebf453e83..3448a8c446d4 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -107,13 +107,13 @@
>  #define     PCIE_ISR0_MSI_INT_PENDING		BIT(24)
>  #define     PCIE_ISR0_INTX_ASSERT(val)		BIT(16 + (val))
>  #define     PCIE_ISR0_INTX_DEASSERT(val)	BIT(20 + (val))
> -#define	    PCIE_ISR0_ALL_MASK			GENMASK(26, 0)
> +#define     PCIE_ISR0_ALL_MASK			GENMASK(31, 0)
>  #define PCIE_ISR1_REG				(CONTROL_BASE_ADDR + 0x48)
>  #define PCIE_ISR1_MASK_REG			(CONTROL_BASE_ADDR + 0x4C)
>  #define     PCIE_ISR1_POWER_STATE_CHANGE	BIT(4)
>  #define     PCIE_ISR1_FLUSH			BIT(5)
>  #define     PCIE_ISR1_INTX_ASSERT(val)		BIT(8 + (val))
> -#define     PCIE_ISR1_ALL_MASK			GENMASK(11, 4)
> +#define     PCIE_ISR1_ALL_MASK			GENMASK(31, 0)
>  #define PCIE_MSI_ADDR_LOW_REG			(CONTROL_BASE_ADDR + 0x50)
>  #define PCIE_MSI_ADDR_HIGH_REG			(CONTROL_BASE_ADDR + 0x54)
>  #define PCIE_MSI_STATUS_REG			(CONTROL_BASE_ADDR + 0x58)
> @@ -199,7 +199,7 @@
>  #define     PCIE_IRQ_MSI_INT2_DET		BIT(21)
>  #define     PCIE_IRQ_RC_DBELL_DET		BIT(22)
>  #define     PCIE_IRQ_EP_STATUS			BIT(23)
> -#define     PCIE_IRQ_ALL_MASK			0xfff0fb
> +#define     PCIE_IRQ_ALL_MASK			GENMASK(31, 0)
>  #define     PCIE_IRQ_ENABLE_INTS_MASK		PCIE_IRQ_CORE_INT
>  
>  /* Transaction types */
> -- 
> 2.32.0
> 

  reply	other threads:[~2021-10-06  9:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 18:09 [PATCH v2 00/13] PCI: aardvark controller fixes Marek Behún
2021-10-05 18:09 ` [PATCH v2 01/13] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros Marek Behún
2021-10-05 18:09 ` [PATCH v2 02/13] PCI: aardvark: Fix PCIe Max Payload Size setting Marek Behún
2021-10-05 18:09 ` [PATCH v2 03/13] PCI: aardvark: Don't spam about PIO Response Status Marek Behún
2021-10-05 18:09 ` [PATCH v2 04/13] PCI: aardvark: Fix preserving PCI_EXP_RTCTL_CRSSVE flag on emulated bridge Marek Behún
2021-10-05 18:09 ` [PATCH v2 05/13] PCI: aardvark: Fix configuring Reference clock Marek Behún
2021-10-05 18:09 ` [PATCH v2 06/13] PCI: aardvark: Do not clear status bits of masked interrupts Marek Behún
2021-10-05 18:09 ` [PATCH v2 07/13] PCI: aardvark: Do not unmask unused interrupts Marek Behún
2021-10-06  9:13   ` Lorenzo Pieralisi [this message]
2021-10-06 10:28     ` Marek Behún
2021-10-07 13:27       ` Lorenzo Pieralisi
2021-10-05 18:09 ` [PATCH v2 08/13] PCI: aardvark: Deduplicate code in advk_pcie_rd_conf() Marek Behún
2021-10-05 18:09 ` [PATCH v2 09/13] PCI: aardvark: Implement re-issuing config requests on CRS response Marek Behún
2021-10-05 18:09 ` [PATCH v2 10/13] PCI: aardvark: Simplify initialization of rootcap on virtual bridge Marek Behún
2021-10-05 18:09 ` [PATCH v2 11/13] PCI: aardvark: Fix link training Marek Behún
2021-10-07 11:55   ` Lorenzo Pieralisi
2021-10-07 12:33     ` Marek Behún
2021-10-05 18:09 ` [PATCH v2 12/13] PCI: aardvark: Fix checking for link up via LTSSM state Marek Behún
2021-10-05 18:09 ` [PATCH v2 13/13] PCI: aardvark: Fix reporting Data Link Layer Link Active Marek Behún
2021-10-07 13:38 ` [PATCH v2 00/13] PCI: aardvark controller fixes Lorenzo Pieralisi
2021-10-07 17:36   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006091337.GA9287@lpieralisi \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=kabel@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.