From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B541BC433F5 for ; Wed, 6 Oct 2021 10:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9566D6113E for ; Wed, 6 Oct 2021 10:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238047AbhJFKU6 (ORCPT ); Wed, 6 Oct 2021 06:20:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbhJFKU4 (ORCPT ); Wed, 6 Oct 2021 06:20:56 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35EE1C061749 for ; Wed, 6 Oct 2021 03:19:04 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1mY40n-0000jN-FU; Wed, 06 Oct 2021 12:18:57 +0200 Date: Wed, 6 Oct 2021 12:18:57 +0200 From: Phil Sutter To: Andrea Claudi Cc: netdev@vger.kernel.org, stephen@networkplumber.org, dsahern@gmail.com, bluca@debian.org Subject: Re: [PATCH iproute2 v3 1/3] configure: support --param=value style Message-ID: <20211006101857.GB29206@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Andrea Claudi , netdev@vger.kernel.org, stephen@networkplumber.org, dsahern@gmail.com, bluca@debian.org References: <20211006080944.GA32194@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Andrea, On Wed, Oct 06, 2021 at 11:49:34AM +0200, Andrea Claudi wrote: [...] > That was my first proposal in v1 [1]. I changed it on David's suggestion > to consolidate the two cases into a single one. Oh, sorry. I missed the 'v3' tag and hence didn't check any earlier version. > Looking at the resulting code, v3 code results in an extra check to > discriminate between the two use cases, while v0 uses the "case" > structure to the same end. Given that David explicitly requested the change I'm complaining about in his reply to your initial version, I guess any further debate about it is irrelevant. Thanks, Phil