From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mY63F-0000fl-RW for mharc-grub-devel@gnu.org; Wed, 06 Oct 2021 08:29:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY63E-0000cl-ER for grub-devel@gnu.org; Wed, 06 Oct 2021 08:29:36 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:42645) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1mY63C-0007cF-S9 for grub-devel@gnu.org; Wed, 06 Oct 2021 08:29:36 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:36136 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2102098AbhJFM33 (ORCPT ); Wed, 6 Oct 2021 14:29:29 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Wed, 6 Oct 2021 14:29:26 +0200 From: Daniel Kiper To: Mislav =?utf-8?Q?Stubli=C4=87?= Cc: "grub-devel@gnu.org" Subject: Re: [PATCH] loader/i386/linux: Add device tree support Message-ID: <20211006122926.px3xu6vly35x7umq@tomti.i.net-space.pl> References: <6DF2B90AE826754EAEE52A5F86D6E41C787D78CF@mail.xylon.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6DF2B90AE826754EAEE52A5F86D6E41C787D78CF@mail.xylon.local> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 12:29:36 -0000 Hi Mislav, On Tue, Sep 21, 2021 at 03:37:45PM +0000, Mislav Stublić wrote: > Hi, > > This implements device tree support for x86. Unfortunately I haven't > been able to test this on latest master but I have tested against 2.04 > and it works fine. I will test on master later but I wanted to get > some initial comments if this is going in the right direction. What I > haven't tested is firmware DTB loading support which only calls > grub_efi_get_firmware_fdt from kern/efi implementation as I don't have > hardware to test this scenario. I skimmed through your patch and it seems to me you are duplicating at least some code from grub-core/loader/arm/linux.c. I would do this a bit differently. First of all I would factor out non-UEFI device tree code from grub-core/loader/arm/linux.c to a separate module. This should be a separate patch. Then I would try to unify the interface for UEFI and non-UEFI device tree code (again, separate patch). Of course if needed. Then the last patch should add device tree support to the x86. If you have any questions drop me a line. Anyway, thank you for taking a stab at this. Daniel