All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, crosa@redhat.com, ehabkost@redhat.com,
	hreitz@redhat.com, kwolf@redhat.com, eblake@redhat.com,
	vsementsov@virtuozzo.com, stefanha@redhat.com
Subject: [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter
Date: Wed,  6 Oct 2021 15:17:14 +0200	[thread overview]
Message-ID: <20211006131718.214235-9-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20211006131718.214235-1-vsementsov@virtuozzo.com>

Convert blk_pdiscard, blk_pwrite_compressed, blk_pwrite_zeroes.
These are just wrappers for functions with int64_t argument, so allow
passing int64_t as well. Parameter type becomes wider so all callers
should be OK with it.

Note that requests exceeding INT_MAX are still restricted by
blk_check_byte_request().

Note also that we don't (and are not going to) convert blk_pwrite and
blk_pread: these functions returns number of bytes on success, so to
update them, we should change return type to int64_t as well, which
will lead to investigating and updating all callers which is too much.

So, blk_pread and blk_pwrite remain unchanged.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/sysemu/block-backend.h |  6 +++---
 block/block-backend.c          | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 398e7abb02..69f5cfb1c5 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -155,7 +155,7 @@ static inline int coroutine_fn blk_co_pwrite(BlockBackend *blk, int64_t offset,
 }
 
 int blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,
-                      int bytes, BdrvRequestFlags flags);
+                      int64_t bytes, BdrvRequestFlags flags);
 BlockAIOCB *blk_aio_pwrite_zeroes(BlockBackend *blk, int64_t offset,
                                   int bytes, BdrvRequestFlags flags,
                                   BlockCompletionFunc *cb, void *opaque);
@@ -245,10 +245,10 @@ void *blk_aio_get(const AIOCBInfo *aiocb_info, BlockBackend *blk,
 int coroutine_fn blk_co_pwrite_zeroes(BlockBackend *blk, int64_t offset,
                                       int64_t bytes, BdrvRequestFlags flags);
 int blk_pwrite_compressed(BlockBackend *blk, int64_t offset, const void *buf,
-                          int bytes);
+                          int64_t bytes);
 int blk_truncate(BlockBackend *blk, int64_t offset, bool exact,
                  PreallocMode prealloc, BdrvRequestFlags flags, Error **errp);
-int blk_pdiscard(BlockBackend *blk, int64_t offset, int bytes);
+int blk_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes);
 int blk_save_vmstate(BlockBackend *blk, const uint8_t *buf,
                      int64_t pos, int size);
 int blk_load_vmstate(BlockBackend *blk, uint8_t *buf, int64_t pos, int size);
diff --git a/block/block-backend.c b/block/block-backend.c
index 403cecea98..018684a203 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1330,7 +1330,7 @@ typedef struct BlkRwCo {
 } BlkRwCo;
 
 int blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,
-                      int bytes, BdrvRequestFlags flags)
+                      int64_t bytes, BdrvRequestFlags flags)
 {
     return blk_pwritev_part(blk, offset, bytes, NULL, 0,
                             flags | BDRV_REQ_ZERO_WRITE);
@@ -1637,7 +1637,7 @@ int coroutine_fn blk_co_pdiscard(BlockBackend *blk, int64_t offset,
     return ret;
 }
 
-int blk_pdiscard(BlockBackend *blk, int64_t offset, int bytes)
+int blk_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes)
 {
     int ret;
 
@@ -2180,10 +2180,10 @@ int coroutine_fn blk_co_pwrite_zeroes(BlockBackend *blk, int64_t offset,
 }
 
 int blk_pwrite_compressed(BlockBackend *blk, int64_t offset, const void *buf,
-                          int count)
+                          int64_t bytes)
 {
-    QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, count);
-    return blk_pwritev_part(blk, offset, count, &qiov, 0,
+    QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
+    return blk_pwritev_part(blk, offset, bytes, &qiov, 0,
                             BDRV_REQ_WRITE_COMPRESSED);
 }
 
-- 
2.31.1



  parent reply	other threads:[~2021-10-06 13:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 13:17 [PATCH 00/12] block: 64bit blk io Vladimir Sementsov-Ogievskiy
2021-10-06 13:17 ` [PATCH 01/12] block-backend: blk_check_byte_request(): int64_t bytes Vladimir Sementsov-Ogievskiy
2021-10-06 15:09   ` Eric Blake
2021-10-06 13:17 ` [PATCH 02/12] block-backend: make blk_co_preadv() 64bit Vladimir Sementsov-Ogievskiy
2021-10-06 15:17   ` Eric Blake
2021-10-06 13:17 ` [PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes Vladimir Sementsov-Ogievskiy
2021-10-06 15:25   ` Eric Blake
2021-10-06 13:17 ` [PATCH 04/12] block-backend: convert blk_co_pdiscard " Vladimir Sementsov-Ogievskiy
2021-10-06 15:59   ` Eric Blake
2021-10-06 13:17 ` [PATCH 05/12] block-backend: rename _do_ helper functions to _co_do_ Vladimir Sementsov-Ogievskiy
2021-10-06 16:06   ` Eric Blake
2021-10-06 13:17 ` [PATCH 06/12] block-coroutine-wrapper.py: support BlockBackend first argument Vladimir Sementsov-Ogievskiy
2021-10-06 16:17   ` Eric Blake
2021-10-06 13:17 ` [PATCH 07/12] block-backend: drop blk_prw, use block-coroutine-wrapper Vladimir Sementsov-Ogievskiy
2021-10-06 16:22   ` Eric Blake
2021-10-06 13:17 ` Vladimir Sementsov-Ogievskiy [this message]
2021-10-06 16:29   ` [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter Eric Blake
2021-10-06 13:17 ` [PATCH 09/12] block-backend: convert blk_co_copy_range to int64_t bytes Vladimir Sementsov-Ogievskiy
2021-10-06 20:04   ` Eric Blake
2021-10-06 13:17 ` [PATCH 10/12] block-backend: convert blk_aio_ functions to int64_t bytes paramter Vladimir Sementsov-Ogievskiy
2021-10-06 20:29   ` Eric Blake
2021-10-12 16:13     ` Vladimir Sementsov-Ogievskiy
2021-10-12 21:37       ` Eric Blake
2021-10-12 21:46         ` Vladimir Sementsov-Ogievskiy
2021-10-06 13:17 ` [PATCH 11/12] block-backend: blk_pread, blk_pwrite: rename count parameter to bytes Vladimir Sementsov-Ogievskiy
2021-10-06 20:33   ` Eric Blake
2021-10-06 13:17 ` [PATCH 12/12] block-backend: drop INT_MAX restriction from blk_check_byte_request() Vladimir Sementsov-Ogievskiy
2021-10-06 20:37   ` Eric Blake
2021-10-07 17:52 ` [PATCH 13/12] block-backend: fix blk_co_flush prototype to mention coroutine_fn Vladimir Sementsov-Ogievskiy
2021-10-07 20:36   ` Eric Blake
2021-10-07 17:52 ` [PATCH 14/12] block-backend: update blk_co_pwrite() and blk_co_pread() wrappers Vladimir Sementsov-Ogievskiy
2021-10-07 20:38   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006131718.214235-9-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=crosa@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.