Re: [RFC] add standardized attributes for force_discharge and inhibit_charge

[Sebastian Reichel <sebastian.reichel@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

Hi Hans,

On Wed, Oct 06, 2021 at 10:10:36AM +0200, Hans de Goede wrote:
> On 10/6/21 12:06 AM, Sebastian Reichel wrote:
> > On Tue, Oct 05, 2021 at 08:01:12PM +0200, Hans de Goede wrote:
> >> Right, force-discharge automatically implies charging is
> >> being inhibited, so putting this in one file makes sense.
> >>
> >> Any suggestion for the name of the file?
> > 
> > Maybe like this?
> > 
> > ---------------------------------------------------------------------
> > What: /sys/class/power_supply/<supply_name>/charge_behaviour
> > Date: October 2021
> > Contact: linux-pm@vger.kernel.org
> > Description:
> >  Configure battery behaviour when a charger is being connected.
> > 
> >  Access: Read, Write
> > 
> >  Valid values:
> > 
> >  0: auto / no override
> >     When charger is connected battery should be charged
> >  1: force idle
> >     When charger is connected the battery should neither be charged
> >     nor discharged.
> >  2: force discharge
> >     When charger is connected the battery should be discharged
> >     anyways.
> > ---------------------------------------------------------------------
> 
> That looks good to me. Although I just realized that some hw may
> only support 1. or 2. maybe explicitly document this and that
> EOPNOTSUPP will be reported when the value is not supported
> (vs EINVAL for plain invalid values)?

Sounds good to me.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]