From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0267BC433FE for ; Wed, 6 Oct 2021 15:11:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89B9660E94 for ; Wed, 6 Oct 2021 15:11:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 89B9660E94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY8Zx-0003bn-HO for qemu-devel@archiver.kernel.org; Wed, 06 Oct 2021 11:11:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY8Ye-0002jT-R1 for qemu-devel@nongnu.org; Wed, 06 Oct 2021 11:10:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY8Yb-0006wc-PO for qemu-devel@nongnu.org; Wed, 06 Oct 2021 11:10:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633533008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y1SXQtI/aawCC3ST96oNh3eC94T5PdiGaUrl8AmqC3I=; b=XakZvd3WazD9+fXblJV1F+If0/pWYI6CIcd7AtaTO83XoWGEI8KIv+y2SPf4bwHM7ZEixx JN03a2PJLyKzY/62Jn+N457gq81UCMAgkdXF0saDy1ELDtom/L4YWuMDNqLav2U6F2Cw54 HOxYylujrLbjqHyGu9aeFrJO1J4+6KY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-NSUEuA1LNKit66E3Yd80Og-1; Wed, 06 Oct 2021 11:10:05 -0400 X-MC-Unique: NSUEuA1LNKit66E3Yd80Og-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 440B919067E0; Wed, 6 Oct 2021 15:10:04 +0000 (UTC) Received: from redhat.com (ovpn-113-79.phx2.redhat.com [10.3.113.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 712089AA22; Wed, 6 Oct 2021 15:09:49 +0000 (UTC) Date: Wed, 6 Oct 2021 10:09:47 -0500 From: Eric Blake To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH 01/12] block-backend: blk_check_byte_request(): int64_t bytes Message-ID: <20211006150947.2b54ctzu27ohqmo3@redhat.com> References: <20211006131718.214235-1-vsementsov@virtuozzo.com> <20211006131718.214235-2-vsementsov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <20211006131718.214235-2-vsementsov@virtuozzo.com> User-Agent: NeoMutt/20210205-815-1dd940 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, hreitz@redhat.com, stefanha@redhat.com, crosa@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 06, 2021 at 03:17:07PM +0200, Vladimir Sementsov-Ogievskiy wrote: > Rename size and make it int64_t to correspond to modern block layer, > which always uses int64_t for offset and bytes (not in blk layer yet, > which is a task for following commits). > > All callers pass int or unsigned int. > > So, for bytes in [0, INT_MAX] nothing is changed, for negative bytes we > now fail on "bytes < 0" check instead of "bytes > INT_MAX" check. > > Note, that blk_check_byte_request() still doesn't allow requests > exceeding INT_MAX. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-backend.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org