From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F49C433EF for ; Wed, 6 Oct 2021 16:42:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 089F161037 for ; Wed, 6 Oct 2021 16:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 089F161037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY9ze-00040v-3o for qemu-devel@archiver.kernel.org; Wed, 06 Oct 2021 12:42:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY9oM-0003rT-3N for qemu-devel@nongnu.org; Wed, 06 Oct 2021 12:30:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY9oJ-00026v-8O for qemu-devel@nongnu.org; Wed, 06 Oct 2021 12:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633537825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/kddG63fYbeyM5UUHVkL2GM+7AJ2Qa4Mmuvnk8SOhw=; b=f8skgarmdII03AmjBKA3cidp1vehb8PnK/o+BZr9s4HeKo7oTeMFqIKbRNcuHvO8rjuxRO 3OVIXBN9gjeix+gi03d8cFd1o8km+IOI7klZkr07D9XUOuuxIF5FcWXcohswQMRWp2Blca DNIF7vQtDni1K4dLkXwROY/d6s+ugIY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-bLEweSTRMqGpDDxUxxvCIA-1; Wed, 06 Oct 2021 12:30:14 -0400 X-MC-Unique: bLEweSTRMqGpDDxUxxvCIA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE3BC1923761; Wed, 6 Oct 2021 16:30:12 +0000 (UTC) Received: from redhat.com (ovpn-113-79.phx2.redhat.com [10.3.113.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01F7060657; Wed, 6 Oct 2021 16:29:51 +0000 (UTC) Date: Wed, 6 Oct 2021 11:29:49 -0500 From: Eric Blake To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter Message-ID: <20211006162949.ybwqsqz6lndfl6fb@redhat.com> References: <20211006131718.214235-1-vsementsov@virtuozzo.com> <20211006131718.214235-9-vsementsov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <20211006131718.214235-9-vsementsov@virtuozzo.com> User-Agent: NeoMutt/20210205-815-1dd940 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, hreitz@redhat.com, stefanha@redhat.com, crosa@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 06, 2021 at 03:17:14PM +0200, Vladimir Sementsov-Ogievskiy wrote: > Convert blk_pdiscard, blk_pwrite_compressed, blk_pwrite_zeroes. > These are just wrappers for functions with int64_t argument, so allow > passing int64_t as well. Parameter type becomes wider so all callers > should be OK with it. > > Note that requests exceeding INT_MAX are still restricted by > blk_check_byte_request(). > > Note also that we don't (and are not going to) convert blk_pwrite and > blk_pread: these functions returns number of bytes on success, so to > update them, we should change return type to int64_t as well, which > will lead to investigating and updating all callers which is too much. > > So, blk_pread and blk_pwrite remain unchanged. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/sysemu/block-backend.h | 6 +++--- > block/block-backend.c | 10 +++++----- > 2 files changed, 8 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org