From: Peter Seiderer <ps.report@gmx.net>
To: Takumi Takahashi <takumiiinn@gmail.com>
Cc: Martin Bark <martin@barkynet.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/rpi-firmware: Support Device Tree Overlay
Date: Wed, 6 Oct 2021 19:09:22 +0200 [thread overview]
Message-ID: <20211006190922.5baf43b9@gmx.net> (raw)
In-Reply-To: <20211003175446.3076312-1-takumiiinn@gmail.com>
Hello Takumi,
thanks for suggested patch...., comment below:
On Mon, 4 Oct 2021 02:54:46 +0900, Takumi Takahashi <takumiiinn@gmail.com> wrote:
> Building the Raspberry Pi GitHub official kernel repository
> will generate a Device Tree Overlay Blob files under
> `$(LINUX_DIR)/arch/$(KERNEL_ARCH)/boot/dts/overlays`.
>
> This commit changes to install the Device Tree Overlay Blob file
> generated during kernel build under the following conditions:
>
> - `$(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS)`
> - `n`
> - `$(BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT)`
> - `y`
>
> Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
> ---
> package/rpi-firmware/rpi-firmware.mk | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 181650fa08..39962b3d70 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -30,6 +30,16 @@ else
> define RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> $(INSTALL) -d $(BINARIES_DIR)/rpi-firmware/overlays
> endef
> +ifeq ($(BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT),y)
> +# If you are using the official raspberry pi kernel, dtbo will be created under
> +# the overlays directory, so use that.
> +define RPI_FIRMWARE_INSTALL_KERNEL_DTB_OVERLAYS
> + for dtbo in $(LINUX_DIR)/arch/$(KERNEL_ARCH)/boot/dts/overlays/*.dtbo; do \
> + $(INSTALL) -D -m 0644 $${dtbo} $(BINARIES_DIR)/rpi-firmware/overlays/$${dtbo##*/} || exit 1; \
> + done
> +endef
> +LINUX_POST_INSTALL_IMAGES_HOOKS += RPI_FIRMWARE_INSTALL_KERNEL_DTB_OVERLAYS
> +endif
I believe this is the wrong place to copy the linux-kernel generated overlays
(as they are independent of the rpi-firmware package), a better place would
be a BR2_ROOTFS_POST_BUILD_SCRIPT script...
Regards,
Peter
> endif
>
> ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG),y)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-06 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 17:54 [Buildroot] [PATCH 1/1] package/rpi-firmware: Support Device Tree Overlay Takumi Takahashi
2021-10-06 17:09 ` Peter Seiderer [this message]
2021-10-06 20:57 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006190922.5baf43b9@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=martin@barkynet.com \
--cc=takumiiinn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.