From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C5BC433EF for ; Wed, 6 Oct 2021 21:30:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B6E961090 for ; Wed, 6 Oct 2021 21:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B6E961090 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D1E548349C; Wed, 6 Oct 2021 23:29:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ziswiler.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 39F9F83323; Wed, 6 Oct 2021 23:29:09 +0200 (CEST) Received: from mout.perfora.net (mout.perfora.net [74.208.4.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1A00383404 for ; Wed, 6 Oct 2021 23:28:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=ziswiler.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=marcel@ziswiler.com Received: from toolbox.toradex.int ([66.171.181.186]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPSA (Nemesis) id 0MQ4G5-1mTXlD1Kux-005G8n; Wed, 06 Oct 2021 23:28:24 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Cc: Stefano Babic , Heiko Thiery , Fabio Estevam , Frieder Schrempf , Marcel Ziswiler , "NXP i.MX U-Boot Team" Subject: [PATCH v4 10/10] verdin-imx8mm: fix watchdog pinctrl issue Date: Wed, 6 Oct 2021 23:27:56 +0200 Message-Id: <20211006212757.464740-11-marcel@ziswiler.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20211006212757.464740-1-marcel@ziswiler.com> References: <20211006212757.464740-1-marcel@ziswiler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:MdR4AI30TK0rSl/sLpb40Z0MgTzdzVaeFtc92mSPV+4Tk0TEZpN 4HoTTGHtCKEizGAnbrnq+Y4Q02d5VhF7PrA0I1mJetW+J/SyAcbOioBe5Ogt75/Y+gy8X8q 0UuwFoJvKV82COU8vZojtfKHAigYP1NOkxPOpjBWAIONB5VR04/vSJv7kqntgKN1FmmN5oh gfyfdF+oOfcAAF6+kQIDQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jxNjGBBQxtU=:SLmF+qLMZSp2ap3HxyZPw3 ddzH5UQOC3D8LWiCTky74bNuE/9OGYrNpSFROxh7SP2+sTlN2mlGKU15N/3ZFtjuWxJKZox07 BTDnB2Js3kxG2hRJ4ybvof9MhuSf5xMHsQjqEjBHmulOj0cJzLhhnYICvItgE9C2ZwQPdYCGi 9jA4TtHAixl3cMzqw9+WOVT14QD1KOqXldhuWqeSVmlZiYYbzqDwkdcHsBlAGjoyi7Qk/aByl Gcy998Omy9DZdkK+pyDCT156W1f+/FqufnsXAKkCZQs/G56xvi6joy646cBpvU04ecbh2yFPP MDUtLpjeIvIgBiC4iwsxFRtU2fyx4CORrZyWBowVdw7fObxoZt91hjVQv0wTMGoivZoJ6AVEG 6TGURRz7iHnmnNIB0jrF56WqOcxknNdDwNY8rAJdXk3wQLWUCu6WMkWy5RiW1hAbIwZaTeZg2 x41ha+PwYlDDPmu7mOTb/Bzw9PDk3Ui+I9/nvsTZ+WkHXYc/HEXi0G2I9ZbYEVHDRARw1DWAc 6Unqd44z+6I2DUrsR4+TpCWE3ZmJC+wWcaDPIm/8QEqyhKDzL/C/TdmfI+Cbif6wqis9avwW6 aIJrzFreu9IoDBihfx+hOgfPk2wFxHei28viiBBVKJrmsQqHrSSOi231QjPNJpLtXrjg6uA6I u00cLBqTcE0GlFyVSue7EgspX7u4YHBVr4efNn0hlrzHsq/SkffVCFUQnHlvaypSRktdGQHvX 0YSNZ/M1yp8gToRzT3fF2MqR6WRCWPokMsOO6g== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Marcel Ziswiler Finally, found the root cause of the issue already once mentioned back here [2] which caused the following error message during boot: imx_wdt watchdog@30280000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19 Turns out while the watchdog node itself was already u-boot,dm-spl its pinctrl node was not which caused it to be unavailable at that early stage. Note that any and all other boards I checked also seem to be missing this. However, I can't judge whether or not they might indeed need a similar fix or not. [2] https://marc.info/?l=u-boot&m=161786572422973 Fixes: commit d304e7ace3a6 ("ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin") Signed-off-by: Marcel Ziswiler Reviewed-by: Fabio Estevam --- (no changes since v2) Changes in v2: - New patch fixing watchdog pinctrl issue. arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi index 0c65070cd5f..bf47930c36f 100644 --- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi +++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi @@ -68,6 +68,10 @@ u-boot,dm-spl; }; +&pinctrl_wdog { + u-boot,dm-spl; +}; + &{/soc@0/bus@30800000/i2c@30a20000/pmic} { u-boot,dm-spl; }; -- 2.26.2