All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH] tracing/synthetic_events: Fix use when created by dynamic_events file
Date: Wed, 6 Oct 2021 21:28:03 -0400	[thread overview]
Message-ID: <20211006212803.48151494@rorschach.local.home> (raw)
In-Reply-To: <20211007101952.d9d282257b9c49fe699c0679@kernel.org>

On Thu, 7 Oct 2021 10:19:52 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> >  	raw_command = skip_spaces(raw_command);
> >  	if (raw_command[0] == '\0')
> > -		return ret;
> > +		return -ECANCELED;  
> 
> Good catch! BTW, I thought trace_parse_run_command() skips such empty line.

I think it does, but I was paranoid to remove that part, as this is
going to stable. As a clean up, we could remove that for the next merge
window.

> 
> Anyway,
> 
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

-- Steve

      reply	other threads:[~2021-10-07  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 15:53 [PATCH] tracing/synthetic_events: Fix use when created by dynamic_events file Steven Rostedt
2021-10-07  1:19 ` Masami Hiramatsu
2021-10-07  1:28   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006212803.48151494@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.