All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michael Walle <michael@walle.cc>,
	davem@davemloft.net, netdev@vger.kernel.org,
	vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next 2/3] eth: platform: add a helper for loading netdev->dev_addr
Date: Thu, 7 Oct 2021 07:21:54 -0700	[thread overview]
Message-ID: <20211007072154.32de24dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YV7/0wqmxuuPB/yJ@lunn.ch>

On Thu, 7 Oct 2021 16:10:27 +0200 Andrew Lunn wrote:
> On Thu, Oct 07, 2021 at 06:57:01AM -0700, Jakub Kicinski wrote:
> > > this eventually calls ether_addr_copy(), which has a note:
> > >    Please note: dst & src must both be aligned to u16.
> > > 
> > > Is this true for this addr on the stack?  
> > 
> > It will but I don't think there's anything in the standard that
> > requires it. Let me slap __aligned(2) on it to be sure.  
> 
> Hi Jakub
> 
> I though you changed ether_addr_copy() to be a memcpy?
> Or was that some other helper?

I changed eth_hw_addr_set(), I think Michael is referring to 
a ether_addr_copy() inside eth_platform_get_mac_address().

  reply	other threads:[~2021-10-07 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 13:25 [PATCH net-next 0/3] net: add a helpers for loading netdev->dev_addr from platform Jakub Kicinski
2021-10-07 13:25 ` [PATCH net-next 1/3] ethernet: un-export nvmem_get_mac_address() Jakub Kicinski
2021-10-07 14:08   ` Andrew Lunn
2021-10-07 13:25 ` [PATCH net-next 2/3] eth: platform: add a helper for loading netdev->dev_addr Jakub Kicinski
2021-10-07 13:42   ` Michael Walle
2021-10-07 13:57     ` Jakub Kicinski
2021-10-07 14:10       ` Andrew Lunn
2021-10-07 14:21         ` Jakub Kicinski [this message]
2021-10-07 13:25 ` [PATCH net-next 3/3] ethernet: use platform_get_ethdev_address() Jakub Kicinski
2021-10-07 14:21   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007072154.32de24dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.