[dunfell/master][PATCH 0/2] Package intel 9260 WiFi and BT firmware

[dunfell/master][PATCH 0/2] Package intel 9260 WiFi and BT firmware

[Sinthu Raja]

From: Sinthu Raja <sinthu.raja@ti.com>

Hi,
This patch series adds support to package the intel 9260 linux firmware
into the J7 EVM SDK. The firmware is already available in the linux firmware
repository, so updated the linux-firmware recipe to packaging the firmware.
Currently, the J7 SK platform is using the intel 9260 chipset, so added code to
package it into J7 EVM SDK.

Sinthu Raja (2):
  packagegroups: tisdk-connectivity: package intel-9260 linux firmware
    images
  linux-firmware: Package intel 9260 WiFi and BT firmware

 .../packagegroup-arago-tisdk-connectivity.bb       |  4 +++-
 .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

-- 
2.31.1

[dunfell/master][PATCH 1/2] packagegroups: tisdk-connectivity: package intel-9260 linux firmware images

[Sinthu Raja]

From: Sinthu Raja <sinthu.raja@ti.com>

linux-firmware-iwlwifi-9260 and linux-firmware-ibt-18 containing
firmware for Intel 9260 (WLAN and BT)

Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 .../packagegroups/packagegroup-arago-tisdk-connectivity.bb    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
index 1eb0e072..98a1dacf 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Task to install wireless packages into the target FS"
 LICENSE = "MIT"
-PR = "r41"
+PR = "r42"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
@@ -18,6 +18,7 @@ WLAN_COMMON = "\
     linux-firmware-iwlwifi-8000c \
     linux-firmware-iwlwifi-8265 \
     linux-firmware-iwlwifi-3160-17 \
+    linux-firmware-iwlwifi-9260 \
 "
 
 WLAN_TI = "\
@@ -42,6 +43,7 @@ BT_COMMON = "\
     pulseaudio-module-bluez5-discover \
     pulseaudio-lib-bluez5-util \
     sbc \
+    linux-firmware-ibt-18 \
 "
 
 BT_TI = "\
-- 
2.31.1

[dunfell/master][PATCH 2/2] linux-firmware: Package intel 9260 WiFi and BT firmware

[Sinthu Raja]

From: Sinthu Raja <sinthu.raja@ti.com>

The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
repository.

Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
index 146596ad..2e2ab1c4 100644
--- a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
+++ b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
@@ -1,4 +1,16 @@
-PR_append = ".arago0"
+PR_append = ".arago1"
+
+PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
+PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"
+
+LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
+LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
+
+FILES_${PN}-iwlwifi-9260 =+ "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
+FILES_${PN}-ibt-18 =+ "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
+
+RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
+RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
 
 do_install_append() {
 	rm -rf  ${D}/lib/firmware/ti-connectivity/
-- 
2.31.1

Re: [dunfell/master][PATCH 2/2] linux-firmware: Package intel 9260 WiFi and BT firmware

[Denys Dmytriyenko]

On Thu, Oct 07, 2021 at 07:39:39PM +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> repository.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>  .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> index 146596ad..2e2ab1c4 100644
> --- a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> +++ b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> @@ -1,4 +1,16 @@
> -PR_append = ".arago0"
> +PR_append = ".arago1"
> +
> +PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
> +PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"

Two issues here:

1. use either _prepend or =+ but not both
2. making machine-specific changes to only PACKAGES isn't right for several 
reasons - should probably be a generic change


> +LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
> +LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
> +
> +FILES_${PN}-iwlwifi-9260 =+ "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> +FILES_${PN}-ibt-18 =+ "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> +
> +RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
> +RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
>  
>  do_install_append() {
>  	rm -rf  ${D}/lib/firmware/ti-connectivity/
> -- 
> 2.31.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [meta-arago] [dunfell/master][PATCH 2/2] linux-firmware: Package intel 9260 WiFi and BT firmware

[Denys Dmytriyenko]

On Mon, Oct 11, 2021 at 01:54:35PM +0530, Sinthu Raja M wrote:
> On Thu, Oct 7, 2021 at 11:37 PM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > On Thu, Oct 07, 2021 at 07:39:39PM +0530, Sinthu Raja wrote:
> > > From: Sinthu Raja <sinthu.raja@ti.com>
> > >
> > > The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> > > repository.
> > >
> > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > ---
> > >  .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > index 146596ad..2e2ab1c4 100644
> > > --- a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > +++ b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > @@ -1,4 +1,16 @@
> > > -PR_append = ".arago0"
> > > +PR_append = ".arago1"
> > > +
> > > +PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
> > > +PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"
> >
> > Two issues here:
> >
> > 1. use either _prepend or =+ but not both
> Hi Denys,
> I found an issue that _prepend is not working and throwing error
> during parsing the recipes, below is the error
> Nothing RPROVIDES 'linux-firmware-iwlwifi-9260'

The reason is that += and =+ automatically insert whitespace, while _prepend 
and _append do not, simply concatenating strings as is, so you need to take 
care of whitespaces yourself.


> But when adding only '=+', it is able to parse the recipe. So, I will
> resend the patch with the updated code.
> 
> Regards,
> Sinthu Raja.
> 
> > 2. making machine-specific changes to only PACKAGES isn't right for several
> > reasons - should probably be a generic change
> >
> >
> > > +LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
> > > +LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
> > > +
> > > +FILES_${PN}-iwlwifi-9260 =+ "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> > > +FILES_${PN}-ibt-18 =+ "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> > > +
> > > +RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
> > > +RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
> > >
> > >  do_install_append() {
> > >       rm -rf  ${D}/lib/firmware/ti-connectivity/
> > > --
> > > 2.31.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964