All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>
Cc: meta-arago@arago-project.org, Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [dunfell/master][PATCH 2/2] linux-firmware: Package intel 9260 WiFi and BT firmware
Date: Thu, 7 Oct 2021 14:07:22 -0400	[thread overview]
Message-ID: <20211007180722.GR1528@denix.org> (raw)
In-Reply-To: <20211007140939.19819-3-sinthu.raja@ti.com>

On Thu, Oct 07, 2021 at 07:39:39PM +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> repository.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>  .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> index 146596ad..2e2ab1c4 100644
> --- a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> +++ b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> @@ -1,4 +1,16 @@
> -PR_append = ".arago0"
> +PR_append = ".arago1"
> +
> +PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
> +PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"

Two issues here:

1. use either _prepend or =+ but not both
2. making machine-specific changes to only PACKAGES isn't right for several 
reasons - should probably be a generic change


> +LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
> +LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
> +
> +FILES_${PN}-iwlwifi-9260 =+ "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> +FILES_${PN}-ibt-18 =+ "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> +
> +RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
> +RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
>  
>  do_install_append() {
>  	rm -rf  ${D}/lib/firmware/ti-connectivity/
> -- 
> 2.31.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964


  reply	other threads:[~2021-10-07 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 14:09 [dunfell/master][PATCH 0/2] Package intel 9260 WiFi and BT firmware Sinthu Raja
2021-10-07 14:09 ` [dunfell/master][PATCH 1/2] packagegroups: tisdk-connectivity: package intel-9260 linux firmware images Sinthu Raja
2021-10-07 14:09 ` [dunfell/master][PATCH 2/2] linux-firmware: Package intel 9260 WiFi and BT firmware Sinthu Raja
2021-10-07 18:07   ` Denys Dmytriyenko [this message]
     [not found]     ` <CAEd-yTQdf6kJDD3PL8voJ+b=ciYKrtqi86CUm9DHden-TuNhBw@mail.gmail.com>
2021-10-18 22:37       ` [meta-arago] " Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007180722.GR1528@denix.org \
    --to=denis@denix.org \
    --cc=meta-arago@arago-project.org \
    --cc=sinthu.raja@mistralsolutions.com \
    --cc=sinthu.raja@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.