From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 915CFC433F5 for ; Fri, 8 Oct 2021 18:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 659A561027 for ; Fri, 8 Oct 2021 18:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231377AbhJHS1H (ORCPT ); Fri, 8 Oct 2021 14:27:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:59286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbhJHS1G (ORCPT ); Fri, 8 Oct 2021 14:27:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 34BA760F9D; Fri, 8 Oct 2021 18:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633717511; bh=SgbiS5u71nkMS6kHjowVFgReev15XfsDQWUshj3Snxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S9DUH559j1TtDcJ3DClwlssQsLoEnZr+5kZgAOPXzzhuk8WWJ+L+gaVsgxqq4fwzm BcbLDuWcoWUhdkNognY/LC0VwqrSwXsRxbrk/IJTdg0ZHisvCptzBlPon4tP1CZH38 51sbfsGS8ThD6V8806q0f0/EH6ugqvOOjRUDnd415HMh6ctxiqd2RMQOd/8SWmoCKA IZe4JePP4tjFzxlaOQOZtfrz7g/7/Mnnz5R1jXacgzkTZ5czN4dtMxA4BiD/T6iq0a mV0uOOAyOs7olPs8b+LH6pX8zjtG0cXpKGaGKd43WK2gVdlhVI6Xzh68Xcfr9AGnAJ gJGHPdYIJo9tQ== Date: Fri, 8 Oct 2021 11:25:10 -0700 From: Jakub Kicinski To: Yajun Deng Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: dev_addr_list: Introduce __dev_addr_add() and __dev_addr_del() Message-ID: <20211008112510.56417490@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211008085354.9961-1-yajun.deng@linux.dev> References: <20211008085354.9961-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 8 Oct 2021 16:53:54 +0800 Yajun Deng wrote: > Introduce helper functions __dev_addr_add() and __dev_addr_del() for > the same code, make the code more concise. > > Signed-off-by: Yajun Deng Please leave net/core/dev_addr_lists.c alone for the time being. I have a lot of changes queued to add the main address the the rbtree.