From: Asmaa Mnebhi <asmaa@nvidia.com>
To: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Cc: Asmaa Mnebhi <asmaa@nvidia.com>,
andrew@lunn.ch, kuba@kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, davem@davemloft.net,
rjw@rjwysocki.net, davthompson@nvidia.com
Subject: [PATCH v4 0/2] gpio: mlxbf2: Introduce proper interrupt handling
Date: Fri, 8 Oct 2021 10:49:18 -0400 [thread overview]
Message-ID: <20211008144920.10975-1-asmaa@nvidia.com> (raw)
This is a follow up on a discussion regarding
proper handling of GPIO interrupts within the
gpio-mlxbf2.c driver.
Link to discussion:
https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@linux.intel.com/T/
Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c.
Patch 2 is a follow up removal of custom GPIO IRQ handling
from the mlxbf_gige driver and replacing it with a simple
IRQ request. The ACPI table for the mlxbf_gige driver is
responsible for instantiating the PHY GPIO interrupt via
GpioInt.
Andy Shevchenko, could you please review this patch series.
v4 vs. v3 patch:
- Remove IRQ_TYPE_LEVEL* from mlxbf2_gpio_irq_set_type
since LEVEL interrupts are not supported by internal
BlueField GPIO HW.
Asmaa Mnebhi (2):
gpio: mlxbf2: Introduce IRQ support
net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
drivers/gpio/gpio-mlxbf2.c | 147 +++++++++++-
.../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 -
.../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 -
.../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------
.../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +-
5 files changed, 154 insertions(+), 240 deletions(-)
delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
--
2.30.1
next reply other threads:[~2021-10-08 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 14:49 Asmaa Mnebhi [this message]
2021-10-08 14:49 ` [PATCH v4 1/2] gpio: mlxbf2: Introduce IRQ support Asmaa Mnebhi
2021-10-15 7:01 ` Bartosz Golaszewski
2021-10-15 15:44 ` Asmaa Mnebhi
2021-10-08 14:49 ` [PATCH v4 2/2] net: mellanox: mlxbf_gige: Replace non-standard interrupt handling Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008144920.10975-1-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.