All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v3 45/46] scsi: usb: Switch to attribute groups
Date: Fri,  8 Oct 2021 13:23:52 -0700	[thread overview]
Message-ID: <20211008202353.1448570-46-bvanassche@acm.org> (raw)
In-Reply-To: <20211008202353.1448570-1-bvanassche@acm.org>

struct device supports attribute groups directly but does not support
struct device_attribute directly. Hence switch to attribute groups.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/usb/storage/scsiglue.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index e5a971b83e3f..4e5a928f0368 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -588,11 +588,13 @@ static ssize_t max_sectors_store(struct device *dev, struct device_attribute *at
 }
 static DEVICE_ATTR_RW(max_sectors);
 
-static struct device_attribute *sysfs_device_attr_list[] = {
-	&dev_attr_max_sectors,
+static struct attribute *usb_sdev_attrs[] = {
+	&dev_attr_max_sectors.attr,
 	NULL,
 };
 
+ATTRIBUTE_GROUPS(usb_sdev);
+
 /*
  * this defines our host template, with which we'll allocate hosts
  */
@@ -653,7 +655,7 @@ static const struct scsi_host_template usb_stor_host_template = {
 	.skip_settle_delay =		1,
 
 	/* sysfs device attributes */
-	.sdev_attrs =			sysfs_device_attr_list,
+	.sdev_groups =			usb_sdev_groups,
 
 	/* module management */
 	.module =			THIS_MODULE

  parent reply	other threads:[~2021-10-08 20:25 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 20:23 [PATCH v3 00/46] Register SCSI sysfs attributes earlier Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 01/46] scsi: core: Register " Bart Van Assche
     [not found]   ` <YWQ3mHOZ+881X+j1@t480-pf1aa2c2.linux.ibm.com>
2021-10-11 13:18     ` Benjamin Block
2021-10-11 13:37   ` Benjamin Block
2021-10-08 20:23 ` [PATCH v3 02/46] ata: Switch to attribute groups Bart Van Assche
2021-10-12  0:59   ` Damien Le Moal
2021-10-08 20:23 ` [PATCH v3 03/46] firewire: sbp2: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 04/46] RDMA/srp: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 05/46] scsi: message: fusion: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 06/46] scsi: zfcp: " Bart Van Assche
2021-10-11 13:26   ` Benjamin Block
2021-10-12 20:39     ` Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 07/46] scsi: 3w-9xxx: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 08/46] scsi: 3w-sas: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 09/46] scsi: 3w-xxxx: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 10/46] scsi: 53c700: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 11/46] scsi: aacraid: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 12/46] scsi: arcmsr: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 13/46] scsi: be2iscsi: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 14/46] scsi: bfa: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 15/46] scsi: bnx2fc: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 16/46] scsi: bnx2i: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 17/46] scsi: csiostor: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 18/46] scsi: cxlflash: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 19/46] scsi: fnic: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 20/46] scsi: hisi_sas: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 21/46] scsi: hpsa: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 22/46] scsi: hptiop: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 23/46] scsi: ibmvscsi: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 24/46] scsi: ibmvfc: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 25/46] scsi: ipr: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 26/46] scsi: isci: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 27/46] scsi: lpfc: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 28/46] scsi: megaraid: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 29/46] scsi: mpt3sas: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 30/46] scsi: mvsas: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 31/46] scsi: myrb: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 32/46] scsi: myrs: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 33/46] scsi: ncr53c8xx: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 34/46] scsi: sym53c500_cs: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 35/46] scsi: pm8001: " Bart Van Assche
2021-10-11  4:54   ` Jinpu Wang
2021-10-08 20:23 ` [PATCH v3 36/46] scsi: pmcraid: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 37/46] scsi: qedf: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 38/46] scsi: qedi: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 39/46] scsi: qla2xxx: Remove a declaration Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 40/46] scsi: qla2xxx: Switch to attribute groups Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 41/46] scsi: qla4xxx: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 42/46] scsi: smartpqi: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 43/46] scsi: snic: " Bart Van Assche
2021-10-08 20:23 ` [PATCH v3 44/46] scsi: unisys: Remove the shost_attrs member Bart Van Assche
2021-10-09  2:11   ` Kershner, David A
2021-10-09  5:55   ` Greg Kroah-Hartman
2021-10-08 20:23 ` Bart Van Assche [this message]
2021-10-09  5:55   ` [PATCH v3 45/46] scsi: usb: Switch to attribute groups Greg Kroah-Hartman
2021-10-08 20:23 ` [PATCH v3 46/46] scsi: core: Remove two host template members that are no longer used Bart Van Assche
2021-10-11 13:38   ` Benjamin Block

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008202353.1448570-46-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.