All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/2] driver core: use NUMA_NO_NODE during device_initialize
@ 2021-10-04 13:34 Max Gurtovoy
  2021-10-04 13:34 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
  0 siblings, 1 reply; 6+ messages in thread
From: Max Gurtovoy @ 2021-10-04 13:34 UTC (permalink / raw)
  To: hch, linux-kernel, gregkh, linux-pci, bhelgaas
  Cc: stefanha, oren, kw, Max Gurtovoy

Don't use (-1) constant for setting initial device node. Instead, use
the generic NUMA_NO_NODE definition to indicate that "no node id
specified".

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---

changes from v2:
 - code conventions changes for patch 2/2 (Krzysztof)
 - added Reviewed-by signatures for patch 2/2 (Stefan, Krzysztof)

changes from v1:
 - added patch 2/2 (Krzysztof)
 - added Reviewed-by signature (Stefan)

---

 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 15986cc2fe5e..a705b85656df 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2874,7 +2874,7 @@ void device_initialize(struct device *dev)
 	spin_lock_init(&dev->devres_lock);
 	INIT_LIST_HEAD(&dev->devres_head);
 	device_pm_init(dev);
-	set_dev_node(dev, -1);
+	set_dev_node(dev, NUMA_NO_NODE);
 #ifdef CONFIG_GENERIC_MSI_IRQ
 	raw_spin_lock_init(&dev->msi_lock);
 	INIT_LIST_HEAD(&dev->msi_list);
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
  2021-10-04 13:34 [PATCH v3 1/2] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
@ 2021-10-04 13:34 ` Max Gurtovoy
  2021-10-04 19:04   ` Krzysztof Wilczyński
  2021-10-08 22:25   ` Bjorn Helgaas
  0 siblings, 2 replies; 6+ messages in thread
From: Max Gurtovoy @ 2021-10-04 13:34 UTC (permalink / raw)
  To: hch, linux-kernel, gregkh, linux-pci, bhelgaas
  Cc: stefanha, oren, kw, Max Gurtovoy

Use the proper macro instead of hard-coded (-1) value.

Suggested-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 drivers/pci/pci-sysfs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 7fb5cd17cc98..f807b92afa6c 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
 	const struct cpumask *mask;
 
 #ifdef CONFIG_NUMA
-	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
-					  cpumask_of_node(dev_to_node(dev));
+	if (dev_to_node(dev) == NUMA_NO_NODE)
+		mask = cpu_online_mask;
+	else
+		mask = cpumask_of_node(dev_to_node(dev));
 #else
 	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
 #endif
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
  2021-10-04 13:34 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
@ 2021-10-04 19:04   ` Krzysztof Wilczyński
  2021-10-08 22:25   ` Bjorn Helgaas
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Wilczyński @ 2021-10-04 19:04 UTC (permalink / raw)
  To: Max Gurtovoy
  Cc: hch, linux-kernel, gregkh, linux-pci, bhelgaas, stefanha, oren

Hi Max!

> Use the proper macro instead of hard-coded (-1) value.
> 
> Suggested-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>  drivers/pci/pci-sysfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 7fb5cd17cc98..f807b92afa6c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>  	const struct cpumask *mask;
>  
>  #ifdef CONFIG_NUMA
> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> -					  cpumask_of_node(dev_to_node(dev));
> +	if (dev_to_node(dev) == NUMA_NO_NODE)
> +		mask = cpu_online_mask;
> +	else
> +		mask = cpumask_of_node(dev_to_node(dev));
>  #else
>  	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>  #endif
> -- 
> 2.18.1

Thank you!

	Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
  2021-10-04 13:34 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
  2021-10-04 19:04   ` Krzysztof Wilczyński
@ 2021-10-08 22:25   ` Bjorn Helgaas
  2021-10-10  8:36     ` Max Gurtovoy
  1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2021-10-08 22:25 UTC (permalink / raw)
  To: Max Gurtovoy
  Cc: hch, linux-kernel, gregkh, linux-pci, bhelgaas, stefanha, oren, kw

On Mon, Oct 04, 2021 at 04:34:53PM +0300, Max Gurtovoy wrote:
> Use the proper macro instead of hard-coded (-1) value.
> 
> Suggested-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>

These two patches are independent, so I applied this patch only to
pci/sysfs for v5.16, thanks!

I assume Greg will take the drivers/base patch.

> ---
>  drivers/pci/pci-sysfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 7fb5cd17cc98..f807b92afa6c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>  	const struct cpumask *mask;
>  
>  #ifdef CONFIG_NUMA
> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> -					  cpumask_of_node(dev_to_node(dev));
> +	if (dev_to_node(dev) == NUMA_NO_NODE)
> +		mask = cpu_online_mask;
> +	else
> +		mask = cpumask_of_node(dev_to_node(dev));
>  #else
>  	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>  #endif
> -- 
> 2.18.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
  2021-10-08 22:25   ` Bjorn Helgaas
@ 2021-10-10  8:36     ` Max Gurtovoy
  2021-10-11 14:06       ` Bjorn Helgaas
  0 siblings, 1 reply; 6+ messages in thread
From: Max Gurtovoy @ 2021-10-10  8:36 UTC (permalink / raw)
  To: Bjorn Helgaas, Greg Kroah-Hartman
  Cc: hch, linux-kernel, linux-pci, bhelgaas, stefanha, oren, kw


On 10/9/2021 1:25 AM, Bjorn Helgaas wrote:
> On Mon, Oct 04, 2021 at 04:34:53PM +0300, Max Gurtovoy wrote:
>> Use the proper macro instead of hard-coded (-1) value.
>>
>> Suggested-by: Krzysztof Wilczyński <kw@linux.com>
>> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> These two patches are independent, so I applied this patch only to
> pci/sysfs for v5.16, thanks!
>
> I assume Greg will take the drivers/base patch.

I saw both patches in his 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
driver-core-next

So I guess there is no need for taking it separately, right Greg ?

>> ---
>>   drivers/pci/pci-sysfs.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
>> index 7fb5cd17cc98..f807b92afa6c 100644
>> --- a/drivers/pci/pci-sysfs.c
>> +++ b/drivers/pci/pci-sysfs.c
>> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>>   	const struct cpumask *mask;
>>   
>>   #ifdef CONFIG_NUMA
>> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
>> -					  cpumask_of_node(dev_to_node(dev));
>> +	if (dev_to_node(dev) == NUMA_NO_NODE)
>> +		mask = cpu_online_mask;
>> +	else
>> +		mask = cpumask_of_node(dev_to_node(dev));
>>   #else
>>   	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>>   #endif
>> -- 
>> 2.18.1
>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
  2021-10-10  8:36     ` Max Gurtovoy
@ 2021-10-11 14:06       ` Bjorn Helgaas
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2021-10-11 14:06 UTC (permalink / raw)
  To: Max Gurtovoy
  Cc: Greg Kroah-Hartman, hch, linux-kernel, linux-pci, bhelgaas,
	stefanha, oren, kw

On Sun, Oct 10, 2021 at 11:36:49AM +0300, Max Gurtovoy wrote:
> 
> On 10/9/2021 1:25 AM, Bjorn Helgaas wrote:
> > On Mon, Oct 04, 2021 at 04:34:53PM +0300, Max Gurtovoy wrote:
> > > Use the proper macro instead of hard-coded (-1) value.
> > > 
> > > Suggested-by: Krzysztof Wilczyński <kw@linux.com>
> > > Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > These two patches are independent, so I applied this patch only to
> > pci/sysfs for v5.16, thanks!
> > 
> > I assume Greg will take the drivers/base patch.
> 
> I saw both patches in his
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> driver-core-next
> 
> So I guess there is no need for taking it separately, right Greg ?

No problem, I dropped the pci-sysfs.c patch.  Thanks for letting me
know!

> > > ---
> > >   drivers/pci/pci-sysfs.c | 6 ++++--
> > >   1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> > > index 7fb5cd17cc98..f807b92afa6c 100644
> > > --- a/drivers/pci/pci-sysfs.c
> > > +++ b/drivers/pci/pci-sysfs.c
> > > @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
> > >   	const struct cpumask *mask;
> > >   #ifdef CONFIG_NUMA
> > > -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> > > -					  cpumask_of_node(dev_to_node(dev));
> > > +	if (dev_to_node(dev) == NUMA_NO_NODE)
> > > +		mask = cpu_online_mask;
> > > +	else
> > > +		mask = cpumask_of_node(dev_to_node(dev));
> > >   #else
> > >   	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
> > >   #endif
> > > -- 
> > > 2.18.1
> > > 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-11 14:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 13:34 [PATCH v3 1/2] driver core: use NUMA_NO_NODE during device_initialize Max Gurtovoy
2021-10-04 13:34 ` [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro Max Gurtovoy
2021-10-04 19:04   ` Krzysztof Wilczyński
2021-10-08 22:25   ` Bjorn Helgaas
2021-10-10  8:36     ` Max Gurtovoy
2021-10-11 14:06       ` Bjorn Helgaas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.