[Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70

[Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70

[Fabrice Fontaine]

Fix the following build failure raised since bump of autoconf to version
2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da:

autoreconf: error: cannot create config/autoconf: No such file or directory

Fixes:
 - http://autobuild.buildroot.org/results/433599039d6e1ee301465f9867e169c121a0646f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...ac-fix-autoreconf-with-autoconf-2.70.patch | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch

diff --git a/package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch b/package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch
new file mode 100644
index 0000000000..efe993ec88
--- /dev/null
+++ b/package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch
@@ -0,0 +1,35 @@
+From b8d5d086489ff20339e221323a60c140a9820e67 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sat, 9 Oct 2021 09:39:52 +0200
+Subject: [PATCH] configure.ac: fix autoreconf with autoconf >= 2.70
+
+Drop AC_CONFIG_AUX_DIR to avoid the following build failure with
+autoconf >= 2.70:
+
+autoreconf: error: cannot create config/autoconf: No such file or directory
+
+Fixes:
+ - http://autobuild.buildroot.org/results/433599039d6e1ee301465f9867e169c121a0646f
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: not sent as upstream is unmaintained:
+https://gitlab.com/cespedes/ltrace/-/issues/8]
+---
+ configure.ac | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index b9c39fa..486589b 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -28,7 +28,6 @@ AC_INIT([ltrace],[0.7.91],[ltrace-devel@lists.alioth.debian.org],
+ AC_CONFIG_HEADERS([config.h])
+ AC_CONFIG_SRCDIR(libltrace.c)
+ AC_CONFIG_MACRO_DIR([config/m4])
+-AC_CONFIG_AUX_DIR([config/autoconf])
+ AC_CANONICAL_BUILD
+ AC_CANONICAL_HOST
+ 
+-- 
+2.33.0
+
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70

[Thomas Petazzoni]

On Sat,  9 Oct 2021 09:50:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since bump of autoconf to version
> 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da:
> 
> autoreconf: error: cannot create config/autoconf: No such file or directory
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/433599039d6e1ee301465f9867e169c121a0646f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...ac-fix-autoreconf-with-autoconf-2.70.patch | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch

I've extended the explanation to indicate why removing the
AC_CONFIG_AUX_DIR invocation is OK: it's because there is no
config/autoconf directory. I think your commit log should try to
explain why a change is OK, not just "we're removing stuff to fix a
build failure".

Applied to master with the extended commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot