[PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml

[PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml

[David Heidelberg]

Convert bindings for NXP PN544 NFC driver to YAML syntax.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/net/nfc/nxp,pn544.yaml           | 67 +++++++++++++++++++
 .../devicetree/bindings/net/nfc/pn544.txt     | 33 ---------
 2 files changed, 67 insertions(+), 33 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt

diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
new file mode 100644
index 000000000000..c44f5ee8e2c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/nfc/nxp,pn544.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP Semiconductors PN544 NFC Controller
+
+maintainers:
+  - Rob Herring <robh+dt@kernel.org>
+
+properties:
+  compatible:
+    const: nxp,pn544-i2c
+
+  clock-frequency: true
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  enable-gpios:
+    description: Output GPIO pin used for enabling/disabling the PN544
+
+  firmware-gpios:
+    description: Output GPIO pin used to enter firmware download mode
+
+  pinctrl-names:
+    items:
+      - const: default
+
+  pintctrl-0: true
+
+required:
+  - compatible
+  - clock-frequency
+  - reg
+  - interrupts
+  - enable-gpios
+  - firmware-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pn544@28 {
+        compatible = "nxp,pn544-i2c";
+
+        reg = <0x28>;
+        clock-frequency = <400000>;
+
+        interrupt-parent = <&gpio1>;
+        interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+
+        enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
+        firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+      };
+    };
diff --git a/Documentation/devicetree/bindings/net/nfc/pn544.txt b/Documentation/devicetree/bindings/net/nfc/pn544.txt
deleted file mode 100644
index 2bd82562ce8e..000000000000
--- a/Documentation/devicetree/bindings/net/nfc/pn544.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-* NXP Semiconductors PN544 NFC Controller
-
-Required properties:
-- compatible: Should be "nxp,pn544-i2c".
-- clock-frequency: I²C work frequency.
-- reg: address on the bus
-- interrupts: GPIO interrupt to which the chip is connected
-- enable-gpios: Output GPIO pin used for enabling/disabling the PN544
-- firmware-gpios: Output GPIO pin used to enter firmware download mode
-
-Optional SoC Specific Properties:
-- pinctrl-names: Contains only one value - "default".
-- pintctrl-0: Specifies the pin control groups used for this controller.
-
-Example (for ARM-based BeagleBone with PN544 on I2C2):
-
-&i2c2 {
-
-
-	pn544: pn544@28 {
-
-		compatible = "nxp,pn544-i2c";
-
-		reg = <0x28>;
-		clock-frequency = <400000>;
-
-		interrupt-parent = <&gpio1>;
-		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
-
-		enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
-		firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
-	};
-};
-- 
2.33.0

Re: [PATCH] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml

[Krzysztof Kozlowski]

On 09/10/2021 13:12, David Heidelberg wrote:
> Convert bindings for NXP PN544 NFC driver to YAML syntax.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../bindings/net/nfc/nxp,pn544.yaml           | 67 +++++++++++++++++++
>  .../devicetree/bindings/net/nfc/pn544.txt     | 33 ---------
>  2 files changed, 67 insertions(+), 33 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt
> 

Hi,

Thanks for the patch. Please use get_maintainers.pl to get the list of
folks to Cc. You missed Rob. This is even weirder because you put him as
a maintainer...

> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> new file mode 100644
> index 000000000000..c44f5ee8e2c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nfc/nxp,pn544.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Semiconductors PN544 NFC Controller
> +
> +maintainers:
> +  - Rob Herring <robh+dt@kernel.org>

This should not be Rob but someone responsible for the driver. I see
there is no maintainers entry, so put there me:

Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

> +
> +properties:
> +  compatible:
> +    const: nxp,pn544-i2c
> +
> +  clock-frequency: true
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    description: Output GPIO pin used for enabling/disabling the PN544
> +
> +  firmware-gpios:
> +    description: Output GPIO pin used to enter firmware download mode
> +
> +  pinctrl-names:
> +    items:
> +      - const: default
> +
> +  pintctrl-0: true

Drop pinctrl, there is a typo here and this is already provided by the
schema.

> +
> +required:
> +  - compatible
> +  - clock-frequency
> +  - reg
> +  - interrupts
> +  - enable-gpios
> +  - firmware-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;

Use 4-space indentation for the example. Easier to read.

> +
> +      pn544@28 {

Nodes should have generic name, so "nfc".

> +        compatible = "nxp,pn544-i2c";



Best regards,
Krzysztof