All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Korty <joe.korty@concurrent-rt.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Clark Williams <williams@redhat.com>,
	Jun Miao <jun.miao@windriver.com>,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.10-rt+] drm/i915/gt: transform irq_disable into local_lock.
Date: Sat, 9 Oct 2021 12:49:08 -0400	[thread overview]
Message-ID: <20211009164908.GA21269@zipoli.concurrent-rt.com> (raw)
In-Reply-To: <20211007171929.hegwwqelf46skjyw@linutronix.de>

On Thu, Oct 07, 2021 at 07:19:29PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-10-07 12:59:28 [-0400], Joe Korty wrote:
> > Convert IRQ blocking in intel_breadcrumbs_park() to a local lock.
> > 
> > Affects 5.10-rt and all later releases, up to and including when
> > rt was merged into mainline.
> 
> RT was merged into mainline? Nobody tells me anything anymore??? 
> 
> > This problem has been reported in two other linux-rt-users postings,
> >   
> >    [PREEMPT_RT] i915: fix PREEMPT_RT locking splats (Clark Williams)
> >    [linux-5.12.y-rt] drm/i915/gt: Fix a lockdep warning with interrupts enabled (Jun Miao)
> > 
> > Neither of these submit the obvious solution, nor,
> > AFAICT, has either yet been acted on.  So I muddy the
> > waters further by submitting this, a third fix.
> 
> 5.12 is longer maintained. Could you please take the latest devel tree
> for testing and participate in
>   https://lore.kernel.org/all/20211005150046.1000285-1-bigeasy@linutronix.de/
> 
> If anything I would prefer those patches backported into v5.10 if it is
> affected.


Hi Sebastian,
Please add my 'Tested-by' to the below patch.  

   [linux-5.12.y-rt] drm/i915/gt: Fix a lockdep warning with interrupts enabled (Jun Miao)

What was tested was a backport to 5.10-rt.  One reject
was encountered, trivially resolved.  No other adjustments
were made.

My regression tests of last night all passed without any
of the usual lockdep splats occuring.  Prior to this,
I could be assured of a large enough flood of splats to
overwhelm the kernel log.

My test stand is a Supermicro C7Z170-SQ.  This is tthe
only system I have on which I could trigger the problem.

I could not find this patch in the 5.12-rt or the 5.15-rt
tree, so I fetched a copy out of the linux-rt-users
archives, and backported that.

Tested-by: Joe Korty <joe.korty@concurrent-rt.com>


  reply	other threads:[~2021-10-09 16:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 16:59 [PATCH 5.10-rt+] drm/i915/gt: transform irq_disable into local_lock Joe Korty
2021-10-07 17:19 ` Sebastian Andrzej Siewior
2021-10-09 16:49   ` Joe Korty [this message]
2021-11-16 20:25     ` Steven Rostedt
2021-11-16 21:02       ` Sebastian Andrzej Siewior
2021-11-16 21:39         ` Steven Rostedt
2021-11-22 19:50           ` Joe Korty
2021-11-22 20:32             ` Steven Rostedt
2021-11-30 15:10             ` Sebastian Andrzej Siewior
2021-11-30 22:03               ` Joe Korty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009164908.GA21269@zipoli.concurrent-rt.com \
    --to=joe.korty@concurrent-rt.com \
    --cc=bigeasy@linutronix.de \
    --cc=jun.miao@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.