All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support
@ 2021-10-11  7:03 Cédric Le Goater
  2021-10-11 23:21 ` Joel Stanley
  2021-10-17 12:32 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2021-10-11  7:03 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Cédric Le Goater

CONFIG_PPC64_BOOT_WRAPPER is selected by CPU_LITTLE_ENDIAN which is
used to compile support for other platforms such as Microwatt. There
is no need for OPAL calls on these.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 arch/powerpc/boot/serial.c | 2 +-
 arch/powerpc/boot/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
index 9a19e5905485..54d2522be485 100644
--- a/arch/powerpc/boot/serial.c
+++ b/arch/powerpc/boot/serial.c
@@ -132,7 +132,7 @@ int serial_console_init(void)
 	else if (dt_is_compatible(devp, "fsl,mpc5200-psc-uart"))
 		rc = mpc5200_psc_console_init(devp, &serial_cd);
 #endif
-#ifdef CONFIG_PPC64_BOOT_WRAPPER
+#ifdef CONFIG_PPC_POWERNV
 	else if (dt_is_compatible(devp, "ibm,opal-console-raw"))
 		rc = opal_console_init(devp, &serial_cd);
 #endif
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 089ee3ea55c8..9993c6256ad2 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -123,7 +123,7 @@ src-wlib-y := string.S crt0.S stdio.c decompress.c main.c \
 		oflib.c ofconsole.c cuboot.c
 
 src-wlib-$(CONFIG_PPC_MPC52xx) += mpc52xx-psc.c
-src-wlib-$(CONFIG_PPC64_BOOT_WRAPPER) += opal-calls.S opal.c
+src-wlib-$(CONFIG_PPC_POWERNV) += opal-calls.S opal.c
 ifndef CONFIG_PPC64_BOOT_WRAPPER
 src-wlib-y += crtsavres.S
 endif
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support
  2021-10-11  7:03 [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support Cédric Le Goater
@ 2021-10-11 23:21 ` Joel Stanley
  2021-10-17 12:32 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2021-10-11 23:21 UTC (permalink / raw)
  To: Cédric Le Goater; +Cc: linuxppc-dev

On Mon, 11 Oct 2021 at 07:42, Cédric Le Goater <clg@kaod.org> wrote:
>
> CONFIG_PPC64_BOOT_WRAPPER is selected by CPU_LITTLE_ENDIAN which is
> used to compile support for other platforms such as Microwatt. There
> is no need for OPAL calls on these.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  arch/powerpc/boot/serial.c | 2 +-
>  arch/powerpc/boot/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
> index 9a19e5905485..54d2522be485 100644
> --- a/arch/powerpc/boot/serial.c
> +++ b/arch/powerpc/boot/serial.c
> @@ -132,7 +132,7 @@ int serial_console_init(void)
>         else if (dt_is_compatible(devp, "fsl,mpc5200-psc-uart"))
>                 rc = mpc5200_psc_console_init(devp, &serial_cd);
>  #endif
> -#ifdef CONFIG_PPC64_BOOT_WRAPPER
> +#ifdef CONFIG_PPC_POWERNV
>         else if (dt_is_compatible(devp, "ibm,opal-console-raw"))
>                 rc = opal_console_init(devp, &serial_cd);
>  #endif
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 089ee3ea55c8..9993c6256ad2 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -123,7 +123,7 @@ src-wlib-y := string.S crt0.S stdio.c decompress.c main.c \
>                 oflib.c ofconsole.c cuboot.c
>
>  src-wlib-$(CONFIG_PPC_MPC52xx) += mpc52xx-psc.c
> -src-wlib-$(CONFIG_PPC64_BOOT_WRAPPER) += opal-calls.S opal.c
> +src-wlib-$(CONFIG_PPC_POWERNV) += opal-calls.S opal.c
>  ifndef CONFIG_PPC64_BOOT_WRAPPER
>  src-wlib-y += crtsavres.S
>  endif
> --
> 2.31.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support
  2021-10-11  7:03 [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support Cédric Le Goater
  2021-10-11 23:21 ` Joel Stanley
@ 2021-10-17 12:32 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-10-17 12:32 UTC (permalink / raw)
  To: Cédric Le Goater, linuxppc-dev

On Mon, 11 Oct 2021 09:03:56 +0200, Cédric Le Goater wrote:
> CONFIG_PPC64_BOOT_WRAPPER is selected by CPU_LITTLE_ENDIAN which is
> used to compile support for other platforms such as Microwatt. There
> is no need for OPAL calls on these.
> 
> 

Applied to powerpc/next.

[1/1] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support
      https://git.kernel.org/powerpc/c/6ffeb56ee2109b30a9e393f7e0c22c9b5030ac38

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-17 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11  7:03 [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support Cédric Le Goater
2021-10-11 23:21 ` Joel Stanley
2021-10-17 12:32 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.